From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: usb: xhci: fix incorrect memset() From: Greg Kroah-Hartman Message-Id: <20171211170149.GD9454@kroah.com> Date: Mon, 11 Dec 2017 18:01:49 +0100 To: Mathias Nyman Cc: Arnd Bergmann , Mathias Nyman , Lu Baolu , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org List-ID: T24gTW9uLCBEZWMgMTEsIDIwMTcgYXQgMDI6NTk6MTNQTSArMDIwMCwgTWF0aGlhcyBOeW1hbiB3 cm90ZToKPiBPbiAxMS4xMi4yMDE3IDEzOjI3LCBBcm5kIEJlcmdtYW5uIHdyb3RlOgo+ID4gZ2Nj LTggd2FybmluZ3MgYWJvdXQgdGhlIG5ldyBkcml2ZXIgdXNpbmcgYSBtZW1zZXQgd2l0aCBhIGJv Z3VzIGxlbmd0aDoKPiA+IAo+ID4gZHJpdmVycy91c2IvaG9zdC94aGNpLWRiZ2NhcC5jOiBJbiBm dW5jdGlvbiAneGhjaV9kYmNfZXBzX2V4aXQnOgo+ID4gZHJpdmVycy91c2IvaG9zdC94aGNpLWRi Z2NhcC5jOjM2OToyOiBlcnJvcjogJ21lbXNldCcgdXNlZCB3aXRoIGxlbmd0aCBlcXVhbCB0byBu dW1iZXIgb2YgZWxlbWVudHMgd2l0aG91dCBtdWx0aXBsaWNhdGlvbiBieSBlbGVtZW50IHNpemUg Wy1XZXJyb3I9bWVtc2V0LWVsdC1zaXplXQo+ID4gCj4gPiBJdCBsb29rcyBsaWtlIHRoZSBhdXRo b3IgbWVhbnQgdG8gdXNlIHNpemVvZigpIHJhdGhlciB0aGFuIEFSUkFZX1NJWkUoKQo+ID4gaGVy ZSwgc28gdXNlIHRoYXQuCj4gPiAKPiA+IEZpeGVzOiBkZmJhMjE3NGRjNDIgKCJ1c2I6IHhoY2k6 IEFkZCBEYkMgc3VwcG9ydCBpbiB4SENJIGRyaXZlciIpCj4gPiBTaWduZWQtb2ZmLWJ5OiBBcm5k IEJlcmdtYW5uIDxhcm5kQGFybmRiLmRlPgo+ID4gLS0tCj4gCj4gQW5vdGhlciBwYXRjaCB0byBm aXggdGhlIHNhbWUgdGhpbmcgd2FzIHNlbnQgZWFybGllciBhcyBhIGZvbGxvdyB1cCB0byB0aGUg b3JpZ2luYWwgc2VyaWVzLgo+IGh0dHBzOi8vbWFyYy5pbmZvLz9sPWxpbnV4LXVzYiZtPTE1MTI5 ODEzMzUyNDg3MyZ3PTIKPiAKPiBCdXQgeW91ciBwYXRjaCBpbmNsdWRlcyB0aGUgRml4ZXMgbGlu ZSB3aXRoIHRoZSBjb21taXQgaWQsIHdoaWNoIGlzIG5pY2UuCj4gCj4gQm90aCBmaXggdGhlIHBy b2JsZW0sIEl0IGRvZXNuJ3QgbWF0dGVyIGZvciBtZSB3aGljaCBvbmUgZ2V0cyBhcHBsaWVkCgpU aGV5IGZpeCBpdCBpbiBkaWZmZXJlbnQgd2F5cywgd2hpY2ggaXMgY29ycmVjdD8KCkknbSBndWVz c2luZyB5b3UgdGVzdGVkIHlvdXJzPyAgQW5kIEFybmQgcHJvYmFibHkgZG9lc24ndCBoYXZlIHRo ZQpoYXJkd2FyZSB0byBkbyBzbz8KCnRoYW5rcywKCmdyZWcgay1oCi0tLQpUbyB1bnN1YnNjcmli ZSBmcm9tIHRoaXMgbGlzdDogc2VuZCB0aGUgbGluZSAidW5zdWJzY3JpYmUgbGludXgtdXNiIiBp bgp0aGUgYm9keSBvZiBhIG1lc3NhZ2UgdG8gbWFqb3Jkb21vQHZnZXIua2VybmVsLm9yZwpNb3Jl IG1ham9yZG9tbyBpbmZvIGF0ICBodHRwOi8vdmdlci5rZXJuZWwub3JnL21ham9yZG9tby1pbmZv Lmh0bWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752627AbdLKRBo (ORCPT ); Mon, 11 Dec 2017 12:01:44 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:53204 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750707AbdLKRBn (ORCPT ); Mon, 11 Dec 2017 12:01:43 -0500 Date: Mon, 11 Dec 2017 18:01:49 +0100 From: Greg Kroah-Hartman To: Mathias Nyman Cc: Arnd Bergmann , Mathias Nyman , Lu Baolu , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: xhci: fix incorrect memset() Message-ID: <20171211170149.GD9454@kroah.com> References: <20171211112806.3415781-1-arnd@arndb.de> <70603a0e-15dd-8970-54c9-4f1ac1d005e2@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <70603a0e-15dd-8970-54c9-4f1ac1d005e2@linux.intel.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 11, 2017 at 02:59:13PM +0200, Mathias Nyman wrote: > On 11.12.2017 13:27, Arnd Bergmann wrote: > > gcc-8 warnings about the new driver using a memset with a bogus length: > > > > drivers/usb/host/xhci-dbgcap.c: In function 'xhci_dbc_eps_exit': > > drivers/usb/host/xhci-dbgcap.c:369:2: error: 'memset' used with length equal to number of elements without multiplication by element size [-Werror=memset-elt-size] > > > > It looks like the author meant to use sizeof() rather than ARRAY_SIZE() > > here, so use that. > > > > Fixes: dfba2174dc42 ("usb: xhci: Add DbC support in xHCI driver") > > Signed-off-by: Arnd Bergmann > > --- > > Another patch to fix the same thing was sent earlier as a follow up to the original series. > https://marc.info/?l=linux-usb&m=151298133524873&w=2 > > But your patch includes the Fixes line with the commit id, which is nice. > > Both fix the problem, It doesn't matter for me which one gets applied They fix it in different ways, which is correct? I'm guessing you tested yours? And Arnd probably doesn't have the hardware to do so? thanks, greg k-h