All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Miquel RAYNAL <miquel.raynal@free-electrons.com>
Cc: Antoine Tenart <antoine.tenart@free-electrons.com>,
	Richard Weinberger <richard@nod.at>,
	David Woodhouse <dwmw2@infradead.org>,
	Brian Norris <computersforpeace@gmail.com>,
	Marek Vasut <marek.vasut@gmail.com>,
	Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>,
	linux-mtd@lists.infradead.org,
	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	Gregory Clement <gregory.clement@free-electrons.com>,
	Nadav Haklai <nadavh@marvell.com>,
	Ofer Heifetz <oferh@marvell.com>, Hanna Hawa <hannah@marvell.com>
Subject: Re: [PATCH v2] mtd: nand: add ->exec_op() implementation
Date: Mon, 11 Dec 2017 21:52:55 +0100	[thread overview]
Message-ID: <20171211215255.16b63eec@bbrezillon> (raw)
In-Reply-To: <20171211211750.0e74d951@xps13>

Hi Miquel,

On Mon, 11 Dec 2017 21:17:50 +0100
Miquel RAYNAL <miquel.raynal@free-electrons.com> wrote:

> Hello Antoine,
> 
> On Fri, 8 Dec 2017 08:54:50 +0100
> Antoine Tenart <antoine.tenart@free-electrons.com> wrote:
> 
> > Hi Miquel,
> > 
> > Be careful when defining macros: avoid to name your arguments with a
> > value used in the macro that is not meant to be replaced.  
> 
> That is right, it could have failed the macro.

Fixed the macro.
Also reworded a few comments in the code, and the commit log. I also
moved some prototype changes that belong in patch "mtd: nand: provide
several helpers to do common NAND operations".

The resulting patch is applied to the nand/next branch.

Thanks a lot for the effort you've put in this new infrastructure, I
really like the result. It's not perfect and people will probably have
to extend the existing parser to support their controller, but it
clearly goes in the right direction.

I really hope that more controllers will be converted to this new
interface in a near future (you already converted 2 of them).

Regards,

Boris

      reply	other threads:[~2017-12-11 20:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-07 14:54 [PATCH v2] mtd: nand: add ->exec_op() implementation Miquel Raynal
2017-12-08  7:54 ` Antoine Tenart
2017-12-11 20:17   ` Miquel RAYNAL
2017-12-11 20:52     ` Boris Brezillon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171211215255.16b63eec@bbrezillon \
    --to=boris.brezillon@free-electrons.com \
    --cc=antoine.tenart@free-electrons.com \
    --cc=computersforpeace@gmail.com \
    --cc=cyrille.pitchen@wedev4u.fr \
    --cc=dwmw2@infradead.org \
    --cc=gregory.clement@free-electrons.com \
    --cc=hannah@marvell.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=marek.vasut@gmail.com \
    --cc=miquel.raynal@free-electrons.com \
    --cc=nadavh@marvell.com \
    --cc=oferh@marvell.com \
    --cc=richard@nod.at \
    --cc=thomas.petazzoni@free-electrons.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.