From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:34754 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752377AbdLKWVB (ORCPT ); Mon, 11 Dec 2017 17:21:01 -0500 Date: Mon, 11 Dec 2017 23:21:08 +0100 From: Greg KH To: Jason Gunthorpe Cc: Don Dutile , danielj@mellanox.com, bharat@chelsio.com, leon@kernel.org, parav@mellanox.com, paul@paul-moore.com, stable@vger.kernel.org Subject: Re: FAILED: patch "[PATCH] IB/core: Only enforce security for InfiniBand" failed to apply to 4.14-stable tree Message-ID: <20171211222108.GB22320@kroah.com> References: <1513027151144207@kroah.com> <13c9371d-98db-1d84-c2f8-4300e5334bc1@redhat.com> <20171211215031.GA30276@kroah.com> <20171211215358.GG4797@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171211215358.GG4797@mellanox.com> Sender: stable-owner@vger.kernel.org List-ID: On Mon, Dec 11, 2017 at 02:53:58PM -0700, Jason Gunthorpe wrote: > On Mon, Dec 11, 2017 at 10:50:31PM +0100, Greg KH wrote: > > On Mon, Dec 11, 2017 at 04:43:44PM -0500, Don Dutile wrote: > > > On 12/11/2017 04:19 PM, gregkh@linuxfoundation.org wrote: > > > > > > > > The patch below does not apply to the 4.14-stable tree. > > > > If someone wants it applied there, or to any other stable or longterm > > > > tree, then please email the backport, including the original git commit > > > > id to . > > > > > > > > thanks, > > > > > > > > greg k-h > > > > > > > That's b/c this patch needs to be applied (tagged for stable) first: > > > > > > commit 2e4c85c6edc80fa532b2c7e1eb3597ef4d4bbb8f > > > Author: Parav Pandit > > > Date: Thu Nov 2 15:22:27 2017 +0200 > > > > > > IB/core: Avoid unnecessary return value check > > > Since there is nothing done with non zero return value, such check is > > > avoided. > > > Signed-off-by: Parav Pandit > > > Reviewed-by: Daniel Jurgens > > > Signed-off-by: Leon Romanovsky > > > Signed-off-by: Doug Ledford > > > 2b2c7e1eb3597ef4d4bbb8f > > > > That patch was not tagged for stable at all :( > > It doesn't look like something that should go to -stable to me.. > > I think we will need to make you a proper 4.14 backport for the 'Only > enforce security for InfiniBand' patch. No, I almost always want the same exact patches that are in Linus's tree. Otherwise the patch you make will be wrong 90% of the time. thanks, greg k-h