All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Jonathan.Cameron@huawei.com, Stable@vger.kernel.org
Subject: Re: WTF: patch "[PATCH] iio: fix kernel-doc build errors" was seriously submitted to be applied to the 4.14-stable tree?
Date: Mon, 11 Dec 2017 23:25:32 +0100	[thread overview]
Message-ID: <20171211222532.GA32576@kroah.com> (raw)
In-Reply-To: <3e027e38-624d-3b44-5143-01d2fe63fc6e@infradead.org>

On Mon, Dec 11, 2017 at 02:02:18PM -0800, Randy Dunlap wrote:
> On 12/11/2017 01:14 PM, gregkh@linuxfoundation.org wrote:
> > The patch below was submitted to be applied to the 4.14-stable tree.
> > 
> > I fail to see how this patch meets the stable kernel rules as found at
> > Documentation/process/stable-kernel-rules.rst.
> > 
> > I could be totally wrong, and if so, please respond to 
> > <stable@vger.kernel.org> and let me know why this patch should be
> > applied.  Otherwise, it is now dropped from my patch queues, never to be
> > seen again.
> > 
> > thanks,
> > 
> > greg k-h
> 
> Mind you, I'm not pushing for its inclusion in -stable, but I would say that
> it meets all of the rules listed for inclusion, depending on how loosely or
> how strongly one interprets some of the wording there.
> 
> ta.
> 
> > ------------------ original commit in Linus's tree ------------------
> > 
> > From c175cb7cd953782bbf4e8bdf088ad61440d6dde5 Mon Sep 17 00:00:00 2001
> > From: Randy Dunlap <rdunlap@infradead.org>
> > Date: Sun, 29 Oct 2017 17:06:01 -0700
> > Subject: [PATCH] iio: fix kernel-doc build errors
> > 
> > Fix build errors in kernel-doc notation. Symbols that end in '_'
> > have a special meaning, but adding a '*' makes them OK.
> > 
> > ../drivers/iio/industrialio-core.c:635: ERROR: Unknown target name: "iio_val".
> > ../drivers/iio/industrialio-core.c:642: ERROR: Unknown target name: "iio_val".
> > 
> > Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> > Cc: <Stable@vger.kernel.org>
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > 
> > diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
> > index 9c4cfd19b739..2f0998ebeed2 100644
> > --- a/drivers/iio/industrialio-core.c
> > +++ b/drivers/iio/industrialio-core.c
> > @@ -631,7 +631,7 @@ static ssize_t __iio_format_value(char *buf, size_t len, unsigned int type,
> >   * iio_format_value() - Formats a IIO value into its string representation
> >   * @buf:	The buffer to which the formatted value gets written
> >   *		which is assumed to be big enough (i.e. PAGE_SIZE).
> > - * @type:	One of the IIO_VAL_... constants. This decides how the val
> > + * @type:	One of the IIO_VAL_* constants. This decides how the val
> >   *		and val2 parameters are formatted.
> >   * @size:	Number of IIO value entries contained in vals
> >   * @vals:	Pointer to the values, exact meaning depends on the
> > @@ -639,7 +639,7 @@ static ssize_t __iio_format_value(char *buf, size_t len, unsigned int type,
> >   *
> >   * Return: 0 by default, a negative number on failure or the
> >   *	   total number of characters written for a type that belongs
> > - *	   to the IIO_VAL_... constant.
> > + *	   to the IIO_VAL_* constant.
> >   */
> >  ssize_t iio_format_value(char *buf, unsigned int type, int size, int *vals)
> >  {

I can't duplicate this build error on 4.14 anyway, what do you have to
do to reproduce it?

'make htmldocs' doesn't show it.  It does show a bunch of documentation
build warnings, which maybe I should care about and get cleaned up, as
people will be using this kernel for a while...

thanks,

greg k-h

  parent reply	other threads:[~2017-12-11 22:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-11 21:14 WTF: patch "[PATCH] iio: fix kernel-doc build errors" was seriously submitted to be applied to the 4.14-stable tree? gregkh
2017-12-11 22:02 ` Randy Dunlap
2017-12-11 22:20   ` Greg KH
2017-12-11 22:25   ` Greg KH [this message]
2017-12-11 22:29     ` Randy Dunlap
2017-12-12  8:19       ` Greg KH
2017-12-12  8:47         ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171211222532.GA32576@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=Stable@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.