From: keith.busch@intel.com (Keith Busch)
Subject: Block Integrity Rq Count Question
Date: Mon, 11 Dec 2017 17:00:48 -0700 [thread overview]
Message-ID: <20171212000047.GE11218@localhost.localdomain> (raw)
In-Reply-To: <MWHPR04MB102571849DD1D1ACD58670DBEA370@MWHPR04MB1025.namprd04.prod.outlook.com>
On Mon, Dec 11, 2017@05:54:35PM +0000, Jeffrey Lien wrote:
> Keith,
> Your comment below makes sense, but I still have a question. Where in the driver (or maybe it's block layer) is metadata pointer allocated? I can't find where that happens in the nvme driver so does this happen in the block layer? And how do we control whether or not it's 1 contiguous buffer or not?
The function 'nvme_init_integrity' sets up our metadata
profile and requests single metadata payload segments with
'blk_queue_max_integrity_segments(disk->queue, 1)', so the fact
that you're getting multiple segments in your payload suggests some
inappropriate merging is going on in the block layer. It looks like
blk_integrity_merge_{bio,rq} are doing the right thing.
next prev parent reply other threads:[~2017-12-12 0:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-08 22:04 Block Integrity Rq Count Question Jeffrey Lien
2017-12-08 22:19 ` Keith Busch
2017-12-11 17:54 ` Jeffrey Lien
2017-12-12 0:00 ` Keith Busch [this message]
2017-12-12 8:39 ` Christoph Hellwig
2017-12-12 14:34 ` Jeffrey Lien
2017-12-12 21:17 ` Jeffrey Lien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171212000047.GE11218@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.