From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [13/13] arc: do not use __print_symbol() From: Sergey Senozhatsky Message-Id: <20171212024109.GA7798@jagdpanzerIV> Date: Tue, 12 Dec 2017 11:41:09 +0900 To: Vineet Gupta Cc: Sergey Senozhatsky , Andrew Morton , Russell King , Catalin Marinas , Mark Salter , Tony Luck , David Howells , Yoshinori Sato , Guan Xuetao , Borislav Petkov , Greg Kroah-Hartman , Thomas Gleixner , Peter Zijlstra , Fengguang Wu , Steven Rostedt , Petr Mladek , LKML , "linux-arm-kernel@lists.infradead.org" , "linux-c6x-dev@linux-c6x.org" , "linux-ia64@vger.kernel.org" , "linux-am33-list@redhat.com" , "linux-sh@vger.kernel.org" , "linux-edac@vger.kernel.org" , "x86@kernel.org" , "linux-snps-arc@lists.infradead.org" , Sergey Senozhatsky List-ID: T24gKDEyLzExLzE3IDA4OjI4KSwgVmluZWV0IEd1cHRhIHdyb3RlOgo+IE9uIDEyLzExLzIwMTcg MDQ6NTMgQU0sIFNlcmdleSBTZW5vemhhdHNreSB3cm90ZToKPiA+IF9fcHJpbnRfc3ltYm9sKCkg dXNlcyBleHRyYSBzdGFjayBzcGFjZSB0byBzcHJpbnRmKCkgc3ltYm9sCj4gPiBpbmZvcm1hdGlv biBhbmQgdGhlbiB0byBmZWVkIHRoYXQgYnVmZmVyIHRvIHByaW50aygpCj4gPiAKPiA+ICAgIGNo YXIgYnVmZmVyW0tTWU1fU1lNQk9MX0xFTl07Cj4gPiAKPiA+ICAgIHNwcmludF9zeW1ib2woYnVm ZmVyLCBhZGRyZXNzKTsKPiA+ICAgIHByaW50ayhmbXQsIGJ1ZmZlcik7Cj4gPiAKPiA+IFJlcGxh Y2UgX19wcmludF9zeW1ib2woKSB3aXRoIGEgZGlyZWN0IHByaW50aygiJXBTIikgY2FsbC4KPiA+ IAo+ID4gU2lnbmVkLW9mZi1ieTogU2VyZ2V5IFNlbm96aGF0c2t5IDxzZXJnZXkuc2Vub3poYXRz a3lAZ21haWwuY29tPgo+ID4gQ2M6IFZpbmVldCBHdXB0YSA8dmd1cHRhQHN5bm9wc3lzLmNvbT4K PiAKPiBBcHBsaWVkIHRvIGFyYyBmb3ItY3VycgoKdGhhbmtzLgoKCS1zcwotLS0KVG8gdW5zdWJz Y3JpYmUgZnJvbSB0aGlzIGxpc3Q6IHNlbmQgdGhlIGxpbmUgInVuc3Vic2NyaWJlIGxpbnV4LWVk YWMiIGluCnRoZSBib2R5IG9mIGEgbWVzc2FnZSB0byBtYWpvcmRvbW9Admdlci5rZXJuZWwub3Jn Ck1vcmUgbWFqb3Jkb21vIGluZm8gYXQgIGh0dHA6Ly92Z2VyLmtlcm5lbC5vcmcvbWFqb3Jkb21v LWluZm8uaHRtbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergey Senozhatsky Date: Tue, 12 Dec 2017 02:41:09 +0000 Subject: Re: [PATCH 13/13] arc: do not use __print_symbol() Message-Id: <20171212024109.GA7798@jagdpanzerIV> List-Id: References: <20171211125025.2270-1-sergey.senozhatsky@gmail.com> <20171211125025.2270-14-sergey.senozhatsky@gmail.com> <12708a61-ebc7-8f3f-cef6-4a725047de6d@synopsys.com> In-Reply-To: <12708a61-ebc7-8f3f-cef6-4a725047de6d@synopsys.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org On (12/11/17 08:28), Vineet Gupta wrote: > On 12/11/2017 04:53 AM, Sergey Senozhatsky wrote: > > __print_symbol() uses extra stack space to sprintf() symbol > > information and then to feed that buffer to printk() > > > > char buffer[KSYM_SYMBOL_LEN]; > > > > sprint_symbol(buffer, address); > > printk(fmt, buffer); > > > > Replace __print_symbol() with a direct printk("%pS") call. > > > > Signed-off-by: Sergey Senozhatsky > > Cc: Vineet Gupta > > Applied to arc for-curr thanks. -ss From mboxrd@z Thu Jan 1 00:00:00 1970 From: sergey.senozhatsky.work@gmail.com (Sergey Senozhatsky) Date: Tue, 12 Dec 2017 11:41:09 +0900 Subject: [PATCH 13/13] arc: do not use __print_symbol() In-Reply-To: <12708a61-ebc7-8f3f-cef6-4a725047de6d@synopsys.com> References: <20171211125025.2270-1-sergey.senozhatsky@gmail.com> <20171211125025.2270-14-sergey.senozhatsky@gmail.com> <12708a61-ebc7-8f3f-cef6-4a725047de6d@synopsys.com> List-ID: Message-ID: <20171212024109.GA7798@jagdpanzerIV> To: linux-snps-arc@lists.infradead.org On (12/11/17 08:28), Vineet Gupta wrote: > On 12/11/2017 04:53 AM, Sergey Senozhatsky wrote: > > __print_symbol() uses extra stack space to sprintf() symbol > > information and then to feed that buffer to printk() > > > > char buffer[KSYM_SYMBOL_LEN]; > > > > sprint_symbol(buffer, address); > > printk(fmt, buffer); > > > > Replace __print_symbol() with a direct printk("%pS") call. > > > > Signed-off-by: Sergey Senozhatsky > > Cc: Vineet Gupta > > Applied to arc for-curr thanks. -ss From mboxrd@z Thu Jan 1 00:00:00 1970 From: sergey.senozhatsky.work@gmail.com (Sergey Senozhatsky) Date: Tue, 12 Dec 2017 11:41:09 +0900 Subject: [PATCH 13/13] arc: do not use __print_symbol() In-Reply-To: <12708a61-ebc7-8f3f-cef6-4a725047de6d@synopsys.com> References: <20171211125025.2270-1-sergey.senozhatsky@gmail.com> <20171211125025.2270-14-sergey.senozhatsky@gmail.com> <12708a61-ebc7-8f3f-cef6-4a725047de6d@synopsys.com> Message-ID: <20171212024109.GA7798@jagdpanzerIV> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On (12/11/17 08:28), Vineet Gupta wrote: > On 12/11/2017 04:53 AM, Sergey Senozhatsky wrote: > > __print_symbol() uses extra stack space to sprintf() symbol > > information and then to feed that buffer to printk() > > > > char buffer[KSYM_SYMBOL_LEN]; > > > > sprint_symbol(buffer, address); > > printk(fmt, buffer); > > > > Replace __print_symbol() with a direct printk("%pS") call. > > > > Signed-off-by: Sergey Senozhatsky > > Cc: Vineet Gupta > > Applied to arc for-curr thanks. -ss From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752126AbdLLClR (ORCPT ); Mon, 11 Dec 2017 21:41:17 -0500 Received: from mail-pf0-f193.google.com ([209.85.192.193]:46706 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750759AbdLLClP (ORCPT ); Mon, 11 Dec 2017 21:41:15 -0500 X-Google-Smtp-Source: ACJfBovyt36icK0jjtxK/Qa89y11vPfnRaZr/k1jlWHo/6LX9QZ/4MMjeRk5JL0TtATlSat5YXOSsg== Date: Tue, 12 Dec 2017 11:41:09 +0900 From: Sergey Senozhatsky To: Vineet Gupta Cc: Sergey Senozhatsky , Andrew Morton , Russell King , Catalin Marinas , Mark Salter , Tony Luck , David Howells , Yoshinori Sato , Guan Xuetao , Borislav Petkov , Greg Kroah-Hartman , Thomas Gleixner , Peter Zijlstra , Fengguang Wu , Steven Rostedt , Petr Mladek , LKML , "linux-arm-kernel@lists.infradead.org" , "linux-c6x-dev@linux-c6x.org" , "linux-ia64@vger.kernel.org" , "linux-am33-list@redhat.com" , "linux-sh@vger.kernel.org" , "linux-edac@vger.kernel.org" , "x86@kernel.org" , "linux-snps-arc@lists.infradead.org" , Sergey Senozhatsky Subject: Re: [PATCH 13/13] arc: do not use __print_symbol() Message-ID: <20171212024109.GA7798@jagdpanzerIV> References: <20171211125025.2270-1-sergey.senozhatsky@gmail.com> <20171211125025.2270-14-sergey.senozhatsky@gmail.com> <12708a61-ebc7-8f3f-cef6-4a725047de6d@synopsys.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <12708a61-ebc7-8f3f-cef6-4a725047de6d@synopsys.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (12/11/17 08:28), Vineet Gupta wrote: > On 12/11/2017 04:53 AM, Sergey Senozhatsky wrote: > > __print_symbol() uses extra stack space to sprintf() symbol > > information and then to feed that buffer to printk() > > > > char buffer[KSYM_SYMBOL_LEN]; > > > > sprint_symbol(buffer, address); > > printk(fmt, buffer); > > > > Replace __print_symbol() with a direct printk("%pS") call. > > > > Signed-off-by: Sergey Senozhatsky > > Cc: Vineet Gupta > > Applied to arc for-curr thanks. -ss