From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [11/13] irq debug: do not use print_symbol() From: Sergey Senozhatsky Message-Id: <20171212025052.GD7798@jagdpanzerIV> Date: Tue, 12 Dec 2017 11:50:52 +0900 To: David Laight Cc: 'Sergey Senozhatsky' , Andrew Morton , Russell King , Catalin Marinas , Mark Salter , Tony Luck , David Howells , Yoshinori Sato , Guan Xuetao , Borislav Petkov , Greg Kroah-Hartman , Thomas Gleixner , Peter Zijlstra , Vineet Gupta , Fengguang Wu , Steven Rostedt , Petr Mladek , LKML , "linux-arm-kernel@lists.infradead.org" , "linux-c6x-dev@linux-c6x.org" , "linux-ia64@vger.kernel.org" , "linux-am33-list@redhat.com" , "linux-sh@vger.kernel.org" , "linux-edac@vger.kernel.org" , "x86@kernel.org" , "linux-snps-arc@lists.infradead.org" , Sergey Senozhatsky List-ID: T24gKDEyLzExLzE3IDEyOjU1KSwgRGF2aWQgTGFpZ2h0IHdyb3RlOgo+ID4gIGtlcm5lbC9pcnEv ZGVidWcuaCB8IDggKysrLS0tLS0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCsp LCA1IGRlbGV0aW9ucygtKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEva2VybmVsL2lycS9kZWJ1Zy5o IGIva2VybmVsL2lycS9kZWJ1Zy5oCj4gPiBpbmRleCAxN2YwNWVmOGY1NzUuLjU3NjZlMTVjMTE2 MCAxMDA2NDQKPiA+IC0tLSBhL2tlcm5lbC9pcnEvZGVidWcuaAo+ID4gKysrIGIva2VybmVsL2ly cS9kZWJ1Zy5oCj4gLi4uCj4gPiBAQCAtMTUsMTMgKzEzLDEzIEBAIHN0YXRpYyBpbmxpbmUgdm9p ZCBwcmludF9pcnFfZGVzYyh1bnNpZ25lZCBpbnQgaXJxLCBzdHJ1Y3QgaXJxX2Rlc2MgKmRlc2Mp Cj4gPiAgCXByaW50aygiaXJxICVkLCBkZXNjOiAlcCwgZGVwdGg6ICVkLCBjb3VudDogJWQsIHVu aGFuZGxlZDogJWRcbiIsCj4gPiAgCQlpcnEsIGRlc2MsIGRlc2MtPmRlcHRoLCBkZXNjLT5pcnFf Y291bnQsIGRlc2MtPmlycXNfdW5oYW5kbGVkKTsKPiA+ICAJcHJpbnRrKCItPmhhbmRsZV9pcnEo KTogICVwLCAiLCBkZXNjLT5oYW5kbGVfaXJxKTsKPiA+IC0JcHJpbnRfc3ltYm9sKCIlc1xuIiwg KHVuc2lnbmVkIGxvbmcpZGVzYy0+aGFuZGxlX2lycSk7Cj4gPiArCXByX2NvbnQoIiVwU1xuIiwg ZGVzYy0+aGFuZGxlX2lycSk7Cj4gCj4gTG9va3MgbGlrZSB5b3UgY2FuIChhbmQgc2hvdWxkKSB1 c2UgYSBzaW5nbGUgcHJpbnRrKCkgaW5zdGVhZCBvZiBwcl9jb250LgoKdGhhbmtzLCBnb29kIHBv aW50LiB0aG9zZSBwcl9jb250KCktcyBiYXNpY2FsbHkganVzdCByZXBsaWNhdGUKdGhlIG9sZCBi ZWhhdmlvdXI7IGJ1dCBpdCdsbCBiZSBiZXR0ZXIgdG8gZ2V0IHRpZCBvZiB0aGVtLiB3aWxsCmZv bGxvdyB1cCBzaG9ydGx5LgoKCS1zcwotLS0KVG8gdW5zdWJzY3JpYmUgZnJvbSB0aGlzIGxpc3Q6 IHNlbmQgdGhlIGxpbmUgInVuc3Vic2NyaWJlIGxpbnV4LWVkYWMiIGluCnRoZSBib2R5IG9mIGEg bWVzc2FnZSB0byBtYWpvcmRvbW9Admdlci5rZXJuZWwub3JnCk1vcmUgbWFqb3Jkb21vIGluZm8g YXQgIGh0dHA6Ly92Z2VyLmtlcm5lbC5vcmcvbWFqb3Jkb21vLWluZm8uaHRtbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergey Senozhatsky Date: Tue, 12 Dec 2017 02:50:52 +0000 Subject: Re: [PATCH 11/13] irq debug: do not use print_symbol() Message-Id: <20171212025052.GD7798@jagdpanzerIV> List-Id: References: <20171211125025.2270-1-sergey.senozhatsky@gmail.com> <20171211125025.2270-12-sergey.senozhatsky@gmail.com> <063a776096964e8192c94e38413edbe0@AcuMS.aculab.com> In-Reply-To: <063a776096964e8192c94e38413edbe0@AcuMS.aculab.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org On (12/11/17 12:55), David Laight wrote: > > kernel/irq/debug.h | 8 +++----- > > 1 file changed, 3 insertions(+), 5 deletions(-) > > > > diff --git a/kernel/irq/debug.h b/kernel/irq/debug.h > > index 17f05ef8f575..5766e15c1160 100644 > > --- a/kernel/irq/debug.h > > +++ b/kernel/irq/debug.h > ... > > @@ -15,13 +13,13 @@ static inline void print_irq_desc(unsigned int irq, struct irq_desc *desc) > > printk("irq %d, desc: %p, depth: %d, count: %d, unhandled: %d\n", > > irq, desc, desc->depth, desc->irq_count, desc->irqs_unhandled); > > printk("->handle_irq(): %p, ", desc->handle_irq); > > - print_symbol("%s\n", (unsigned long)desc->handle_irq); > > + pr_cont("%pS\n", desc->handle_irq); > > Looks like you can (and should) use a single printk() instead of pr_cont. thanks, good point. those pr_cont()-s basically just replicate the old behaviour; but it'll be better to get tid of them. will follow up shortly. -ss From mboxrd@z Thu Jan 1 00:00:00 1970 From: sergey.senozhatsky.work@gmail.com (Sergey Senozhatsky) Date: Tue, 12 Dec 2017 11:50:52 +0900 Subject: [PATCH 11/13] irq debug: do not use print_symbol() In-Reply-To: <063a776096964e8192c94e38413edbe0@AcuMS.aculab.com> References: <20171211125025.2270-1-sergey.senozhatsky@gmail.com> <20171211125025.2270-12-sergey.senozhatsky@gmail.com> <063a776096964e8192c94e38413edbe0@AcuMS.aculab.com> List-ID: Message-ID: <20171212025052.GD7798@jagdpanzerIV> To: linux-snps-arc@lists.infradead.org On (12/11/17 12:55), David Laight wrote: > > kernel/irq/debug.h | 8 +++----- > > 1 file changed, 3 insertions(+), 5 deletions(-) > > > > diff --git a/kernel/irq/debug.h b/kernel/irq/debug.h > > index 17f05ef8f575..5766e15c1160 100644 > > --- a/kernel/irq/debug.h > > +++ b/kernel/irq/debug.h > ... > > @@ -15,13 +13,13 @@ static inline void print_irq_desc(unsigned int irq, struct irq_desc *desc) > > printk("irq %d, desc: %p, depth: %d, count: %d, unhandled: %d\n", > > irq, desc, desc->depth, desc->irq_count, desc->irqs_unhandled); > > printk("->handle_irq(): %p, ", desc->handle_irq); > > - print_symbol("%s\n", (unsigned long)desc->handle_irq); > > + pr_cont("%pS\n", desc->handle_irq); > > Looks like you can (and should) use a single printk() instead of pr_cont. thanks, good point. those pr_cont()-s basically just replicate the old behaviour; but it'll be better to get tid of them. will follow up shortly. -ss From mboxrd@z Thu Jan 1 00:00:00 1970 From: sergey.senozhatsky.work@gmail.com (Sergey Senozhatsky) Date: Tue, 12 Dec 2017 11:50:52 +0900 Subject: [PATCH 11/13] irq debug: do not use print_symbol() In-Reply-To: <063a776096964e8192c94e38413edbe0@AcuMS.aculab.com> References: <20171211125025.2270-1-sergey.senozhatsky@gmail.com> <20171211125025.2270-12-sergey.senozhatsky@gmail.com> <063a776096964e8192c94e38413edbe0@AcuMS.aculab.com> Message-ID: <20171212025052.GD7798@jagdpanzerIV> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On (12/11/17 12:55), David Laight wrote: > > kernel/irq/debug.h | 8 +++----- > > 1 file changed, 3 insertions(+), 5 deletions(-) > > > > diff --git a/kernel/irq/debug.h b/kernel/irq/debug.h > > index 17f05ef8f575..5766e15c1160 100644 > > --- a/kernel/irq/debug.h > > +++ b/kernel/irq/debug.h > ... > > @@ -15,13 +13,13 @@ static inline void print_irq_desc(unsigned int irq, struct irq_desc *desc) > > printk("irq %d, desc: %p, depth: %d, count: %d, unhandled: %d\n", > > irq, desc, desc->depth, desc->irq_count, desc->irqs_unhandled); > > printk("->handle_irq(): %p, ", desc->handle_irq); > > - print_symbol("%s\n", (unsigned long)desc->handle_irq); > > + pr_cont("%pS\n", desc->handle_irq); > > Looks like you can (and should) use a single printk() instead of pr_cont. thanks, good point. those pr_cont()-s basically just replicate the old behaviour; but it'll be better to get tid of them. will follow up shortly. -ss From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752172AbdLLCvF (ORCPT ); Mon, 11 Dec 2017 21:51:05 -0500 Received: from mail-pf0-f196.google.com ([209.85.192.196]:33010 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750759AbdLLCvC (ORCPT ); Mon, 11 Dec 2017 21:51:02 -0500 X-Google-Smtp-Source: ACJfBot4VlQMxyXCa74N3UvB3MjP+5UoMUiiDZ4KBVHNysCOJZUGxUvWolTdgbRC+31urai2iCjI6A== Date: Tue, 12 Dec 2017 11:50:52 +0900 From: Sergey Senozhatsky To: David Laight Cc: "'Sergey Senozhatsky'" , Andrew Morton , Russell King , Catalin Marinas , Mark Salter , Tony Luck , David Howells , Yoshinori Sato , Guan Xuetao , Borislav Petkov , Greg Kroah-Hartman , Thomas Gleixner , Peter Zijlstra , Vineet Gupta , Fengguang Wu , Steven Rostedt , Petr Mladek , LKML , "linux-arm-kernel@lists.infradead.org" , "linux-c6x-dev@linux-c6x.org" , "linux-ia64@vger.kernel.org" , "linux-am33-list@redhat.com" , "linux-sh@vger.kernel.org" , "linux-edac@vger.kernel.org" , "x86@kernel.org" , "linux-snps-arc@lists.infradead.org" , Sergey Senozhatsky Subject: Re: [PATCH 11/13] irq debug: do not use print_symbol() Message-ID: <20171212025052.GD7798@jagdpanzerIV> References: <20171211125025.2270-1-sergey.senozhatsky@gmail.com> <20171211125025.2270-12-sergey.senozhatsky@gmail.com> <063a776096964e8192c94e38413edbe0@AcuMS.aculab.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <063a776096964e8192c94e38413edbe0@AcuMS.aculab.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (12/11/17 12:55), David Laight wrote: > > kernel/irq/debug.h | 8 +++----- > > 1 file changed, 3 insertions(+), 5 deletions(-) > > > > diff --git a/kernel/irq/debug.h b/kernel/irq/debug.h > > index 17f05ef8f575..5766e15c1160 100644 > > --- a/kernel/irq/debug.h > > +++ b/kernel/irq/debug.h > ... > > @@ -15,13 +13,13 @@ static inline void print_irq_desc(unsigned int irq, struct irq_desc *desc) > > printk("irq %d, desc: %p, depth: %d, count: %d, unhandled: %d\n", > > irq, desc, desc->depth, desc->irq_count, desc->irqs_unhandled); > > printk("->handle_irq(): %p, ", desc->handle_irq); > > - print_symbol("%s\n", (unsigned long)desc->handle_irq); > > + pr_cont("%pS\n", desc->handle_irq); > > Looks like you can (and should) use a single printk() instead of pr_cont. thanks, good point. those pr_cont()-s basically just replicate the old behaviour; but it'll be better to get tid of them. will follow up shortly. -ss