From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Chen Subject: Re: [PATCH v1 2/2] usb: chipidea: tegra: Select Tegra's PHY in Kconfig Date: Tue, 12 Dec 2017 10:54:44 +0800 Message-ID: <20171212025444.GA22364@b29397-desktop> References: <20171211100400.GE10671@ulmo> <6dddb581-e708-b96e-cf56-f3bf106117e2@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Content-Disposition: inline In-Reply-To: <6dddb581-e708-b96e-cf56-f3bf106117e2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dmitry Osipenko Cc: Thierry Reding , Felipe Balbi , Alan Stern , Greg Kroah-Hartman , Jonathan Hunter , Peter Chen , linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org On Mon, Dec 11, 2017 at 04:09:44PM +0300, Dmitry Osipenko wrote: > On 11.12.2017 13:04, Thierry Reding wrote: > > On Mon, Dec 11, 2017 at 02:10:00AM +0300, Dmitry Osipenko wrote: > >> UDC driver won't probe without Tegra's PHY, hence select it in the > >> Kconfig. > >> > >> Signed-off-by: Dmitry Osipenko > >> --- > >> drivers/usb/chipidea/Kconfig | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/drivers/usb/chipidea/Kconfig b/drivers/usb/chipidea/Kconfig > >> index 785f0ed037f7..2ef3b27ea72b 100644 > >> --- a/drivers/usb/chipidea/Kconfig > >> +++ b/drivers/usb/chipidea/Kconfig > >> @@ -27,6 +27,7 @@ config USB_CHIPIDEA_PCI > >> config USB_CHIPIDEA_UDC > >> bool "ChipIdea device controller" > >> depends on USB_GADGET > >> + select USB_TEGRA_PHY if ARCH_TEGRA > > > > This is kind of pointless given that USB_TEGRA_PHY originally was > > automatically enabled if ARCH_TEGRA was enabled. > > Again, please take a closer look at the patches. USB_TEGRA_PHY was enabled if > USB_EHCI_TEGRA was and not ARCH_TEGRA. > > > What do we gain by these two patches, other than maybe make the driver > > buildable as a module? > > Firstly, tegra-phy is built only if ehci-tegra is built. > > Secondly, I think we need to enforce Tegra PHY to be compiled as built-in if one > of ehci-tegra or chipidea drivers is built-in and the other is compiled as a module. You may not bind controller driver with PHY driver in Kconfig, we need to make sure the controller driver has no build error if the PHY driver is not select. And if the PHY driver is not loaded, the controller driver should return -EPROBE_DEFER for it. -- Best Regards, Peter Chen From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v1,2/2] usb: chipidea: tegra: Select Tegra's PHY in Kconfig From: Peter Chen Message-Id: <20171212025444.GA22364@b29397-desktop> Date: Tue, 12 Dec 2017 10:54:44 +0800 To: Dmitry Osipenko Cc: Thierry Reding , Felipe Balbi , Alan Stern , Greg Kroah-Hartman , Jonathan Hunter , Peter Chen , linux-usb@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org List-ID: T24gTW9uLCBEZWMgMTEsIDIwMTcgYXQgMDQ6MDk6NDRQTSArMDMwMCwgRG1pdHJ5IE9zaXBlbmtv IHdyb3RlOgo+IE9uIDExLjEyLjIwMTcgMTM6MDQsIFRoaWVycnkgUmVkaW5nIHdyb3RlOgo+ID4g T24gTW9uLCBEZWMgMTEsIDIwMTcgYXQgMDI6MTA6MDBBTSArMDMwMCwgRG1pdHJ5IE9zaXBlbmtv IHdyb3RlOgo+ID4+IFVEQyBkcml2ZXIgd29uJ3QgcHJvYmUgd2l0aG91dCBUZWdyYSdzIFBIWSwg aGVuY2Ugc2VsZWN0IGl0IGluIHRoZQo+ID4+IEtjb25maWcuCj4gPj4KPiA+PiBTaWduZWQtb2Zm LWJ5OiBEbWl0cnkgT3NpcGVua28gPGRpZ2V0eEBnbWFpbC5jb20+Cj4gPj4gLS0tCj4gPj4gIGRy aXZlcnMvdXNiL2NoaXBpZGVhL0tjb25maWcgfCAxICsKPiA+PiAgMSBmaWxlIGNoYW5nZWQsIDEg aW5zZXJ0aW9uKCspCj4gPj4KPiA+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy91c2IvY2hpcGlkZWEv S2NvbmZpZyBiL2RyaXZlcnMvdXNiL2NoaXBpZGVhL0tjb25maWcKPiA+PiBpbmRleCA3ODVmMGVk MDM3ZjcuLjJlZjNiMjdlYTcyYiAxMDA2NDQKPiA+PiAtLS0gYS9kcml2ZXJzL3VzYi9jaGlwaWRl YS9LY29uZmlnCj4gPj4gKysrIGIvZHJpdmVycy91c2IvY2hpcGlkZWEvS2NvbmZpZwo+ID4+IEBA IC0yNyw2ICsyNyw3IEBAIGNvbmZpZyBVU0JfQ0hJUElERUFfUENJCj4gPj4gIGNvbmZpZyBVU0Jf Q0hJUElERUFfVURDCj4gPj4gIAlib29sICJDaGlwSWRlYSBkZXZpY2UgY29udHJvbGxlciIKPiA+ PiAgCWRlcGVuZHMgb24gVVNCX0dBREdFVAo+ID4+ICsJc2VsZWN0IFVTQl9URUdSQV9QSFkgaWYg QVJDSF9URUdSQQo+ID4gCj4gPiBUaGlzIGlzIGtpbmQgb2YgcG9pbnRsZXNzIGdpdmVuIHRoYXQg VVNCX1RFR1JBX1BIWSBvcmlnaW5hbGx5IHdhcwo+ID4gYXV0b21hdGljYWxseSBlbmFibGVkIGlm IEFSQ0hfVEVHUkEgd2FzIGVuYWJsZWQuCj4gCj4gQWdhaW4sIHBsZWFzZSB0YWtlIGEgY2xvc2Vy IGxvb2sgYXQgdGhlIHBhdGNoZXMuIFVTQl9URUdSQV9QSFkgd2FzIGVuYWJsZWQgaWYKPiBVU0Jf RUhDSV9URUdSQSB3YXMgYW5kIG5vdCBBUkNIX1RFR1JBLgo+IAo+ID4gV2hhdCBkbyB3ZSBnYWlu IGJ5IHRoZXNlIHR3byBwYXRjaGVzLCBvdGhlciB0aGFuIG1heWJlIG1ha2UgdGhlIGRyaXZlcgo+ ID4gYnVpbGRhYmxlIGFzIGEgbW9kdWxlPwo+IAo+IEZpcnN0bHksIHRlZ3JhLXBoeSBpcyBidWls dCBvbmx5IGlmIGVoY2ktdGVncmEgaXMgYnVpbHQuCj4gCj4gU2Vjb25kbHksIEkgdGhpbmsgd2Ug bmVlZCB0byBlbmZvcmNlIFRlZ3JhIFBIWSB0byBiZSBjb21waWxlZCBhcyBidWlsdC1pbiBpZiBv bmUKPiBvZiBlaGNpLXRlZ3JhIG9yIGNoaXBpZGVhIGRyaXZlcnMgaXMgYnVpbHQtaW4gYW5kIHRo ZSBvdGhlciBpcyBjb21waWxlZCBhcyBhIG1vZHVsZS4KCllvdSBtYXkgbm90IGJpbmQgY29udHJv bGxlciBkcml2ZXIgd2l0aCBQSFkgZHJpdmVyIGluIEtjb25maWcsIHdlIG5lZWQKdG8gbWFrZSBz dXJlIHRoZSBjb250cm9sbGVyIGRyaXZlciBoYXMgbm8gYnVpbGQgZXJyb3IgaWYgdGhlIFBIWSBk cml2ZXIKaXMgbm90IHNlbGVjdC4gQW5kIGlmIHRoZSBQSFkgZHJpdmVyIGlzIG5vdCBsb2FkZWQs IHRoZSBjb250cm9sbGVyCmRyaXZlciBzaG91bGQgcmV0dXJuIC1FUFJPQkVfREVGRVIgZm9yIGl0 Lgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752596AbdLLC4F (ORCPT ); Mon, 11 Dec 2017 21:56:05 -0500 Received: from mail-sn1nam02on0052.outbound.protection.outlook.com ([104.47.36.52]:2724 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751566AbdLLCz4 (ORCPT ); Mon, 11 Dec 2017 21:55:56 -0500 Authentication-Results: spf=softfail (sender IP is 192.88.168.50) smtp.mailfrom=gmail.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=fail action=none header.from=gmail.com; Date: Tue, 12 Dec 2017 10:54:44 +0800 From: Peter Chen To: Dmitry Osipenko CC: Thierry Reding , Felipe Balbi , Alan Stern , Greg Kroah-Hartman , Jonathan Hunter , Peter Chen , , , Subject: Re: [PATCH v1 2/2] usb: chipidea: tegra: Select Tegra's PHY in Kconfig Message-ID: <20171212025444.GA22364@b29397-desktop> References: <20171211100400.GE10671@ulmo> <6dddb581-e708-b96e-cf56-f3bf106117e2@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <6dddb581-e708-b96e-cf56-f3bf106117e2@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-EOPAttributedMessage: 0 X-Matching-Connectors: 131575209490501086;(91ab9b29-cfa4-454e-5278-08d120cd25b8);() X-Forefront-Antispam-Report: CIP:192.88.168.50;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(336005)(39380400002)(39860400002)(346002)(376002)(2980300002)(199004)(189003)(24454002)(316002)(106466001)(104016004)(55016002)(33716001)(1076002)(76482006)(68736007)(76176011)(77096006)(5660300001)(7416002)(87572001)(73392002)(229853002)(83506002)(23726003)(2906002)(4326008)(9686003)(33656002)(105596002)(73972006)(82202002)(8656006)(1411001)(53546010)(498600001)(86362001)(575784001)(50466002)(97736004)(305945005)(81166006)(53936002)(16586007)(81156014)(54906003)(81442002)(2950100002)(8936002)(33896004)(356003)(6666003)(6636002)(47776003)(97756001)(8676002)(6916009)(83322999)(46406003)(39060400002)(6246003)(93886005)(58126008)(18370500001)(54886006);DIR:OUT;SFP:1101;SCL:1;SRVR:CO2PR03MB2359;H:tx30smr01.am.freescale.net;FPR:;SPF:SoftFail;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11FD048;1:YSIFl2A+Z31fOH65+RNfWnLwEScQQ3+h9sFDZ5KZFljsvDGQlWYyIrL13xCw09vTcDqAKTFdpZluf/JxibYaPm1a1FMLF9OHgqT5b1Asd7ZxL10sVR5LPD2qBqymhWyq X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 305e1645-feb8-4b69-cdde-08d5410bd964 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(5600026)(4604075)(4534020)(4628075)(201703131517081)(2017052603307);SRVR:CO2PR03MB2359; X-Microsoft-Exchange-Diagnostics: 1;CO2PR03MB2359;3:di84kI6oi64obTIhJ3lllZU5GL0rBNUBwKYEOdu0s8uBE8ArtL5n/0EsJ/tNPDUWnnTv7+5UuEVTWqATpl/HJWNJgp4lN+Kjd8hnXtzdxe/vsqyhVhZC63WKxQzdqtiRC8BJXz3vWskKrpoFWQYfESpqz0QBqKf8QiDrQXk8EfEI7959s9YZCl+ALeZQtVkFcXtPEyoEDsqGyrrRIVrc0IvC3ZECVx6mdEddwpB1X7GiK+6gNaGNZ/X/PYMXcfuZHQeQgq5ThFfrj8+83tzFEh5oZA/TgGRSV9fLTRCAnPegqffXM61kp/hOPlfIIs/hfK1LEwVxLr8VG/9MzkigEnGrL7gvPxU2NvedkTUKhm8=;25:CZH3vTpuMlv0m806exQemoovIb1rtnv2bplETy0eS4V38l1WOI8Xbo/jzkN1I0JR/CexEQETHoFsrwK6asf340QPg/OaexyZuI2c91qlXZwThrkBKkgnyZxS2qnGVFdaVnsrfZP3+9R6nBjbSzftvhx3UqwZUWzXSZxFEm7AXyCumzdAk83JdtrHfb2kDmUgViU9BKR+J5+9jP10gIBRSKdoAQCUFQng6l0ovFM63UNNMwsLiVO4o3LRcGOQY2oFEhNad+otChtNTDZmbM1WGwE4WUEsCovI5xTvrR+xbtq/5QKMLDU8Sgald+ifK0F9xrw300ffepgIrbHlOdxFKw== X-MS-TrafficTypeDiagnostic: CO2PR03MB2359: X-Microsoft-Exchange-Diagnostics: 1;CO2PR03MB2359;31:gNhiR9NDomfQphu08xtNEcirx+b3kyAnG7RLRhlGSTPqzD1dIGT/p+WYQOOkjt4k7RHbFcv84s/QlOwhKukfrG/QKF+66YxaiWi9NeSncFpFV4AT3SfkMXe04VVXJ9WGQSTMHtP2UEG4o5dD0fKhQawcik2cUQsbXMf/QcgtqJ3zGtZds2BnxbTLtY5wiYTTp1vdMDdTRK8xvdkv6ZPqMwgFKzmIeMhV2qnhrGTLK9k=;4:5lGUhMYiBWFpyMGXP8DR1vXK1Ag65+gq4QlTGamBykKomgYLIXAaK+9r0qp8sXcwTETtgZC9QnVxELbQ9QsdfArx8OK5TGrZzRga7jyafGS0L8dMAJCCt4yzbrK+pR8+hdouuZ35Nq/OadGCA1EGbMFy77sxfdD0754kOusfPtERDyYJu6icYcdsHmTqLlo54EZnyCZXGB0vVCtYMEIySMDdhj8uDYzwdsFJYnHz4PswHhU8y1Ha4SATBzox5xD5cx3HXqd7ISCh11JyyZkMUQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6095135)(2401047)(8121501046)(5005006)(3002001)(10201501046)(3231023)(93006095)(93001095)(6055026)(6096035)(20161123561025)(20161123559100)(20161123563025)(20161123565025)(201703131430075)(201703131448075)(201703131433075)(201703161259150)(201703151042153)(20161123556025)(201708071742011);SRVR:CO2PR03MB2359;BCL:0;PCL:0;RULEID:(100000803101)(100110400095)(400006);SRVR:CO2PR03MB2359; X-Forefront-PRVS: 051900244E X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CO2PR03MB2359;23:jHzzM6IzTOEXx2xnhSpPoKwFm23ZYmc++SkUqjRMj?= =?us-ascii?Q?+x1EjILdlRdHe30pWo0GcZa9iUBJXGN265Lfg56Am8PgPmgrOe/BnWwbISSW?= =?us-ascii?Q?fOE3on/3mAuZuG71dOk/bNdWIhaxbTzlHIWdSgT45+xIqqEjO3XJF6dpbJmQ?= =?us-ascii?Q?X/6eGm0xBSFEFi55PNe++SA5QiA0wAKdd4OdOkLEnaKC1nk0tIjbBPQ5zhZU?= =?us-ascii?Q?UMwrxS7lOOD116OYsGYVyzJ4WEo+iWaXm0nK1Yv/t009r23lB7Khl6Pi1JOv?= =?us-ascii?Q?RzpUQY+ZO2fRg3Gtzq0wMdkLtANg9MWqBrJ1Rd+zsY5MOVf9j+wsd4283//s?= =?us-ascii?Q?pt6mSb1jUQamZJGh/qOI9jDKbzHZWH8nM00G3J4LzlN3De13gPGXNmvsfuUb?= =?us-ascii?Q?2y88R+YcGH35yzFxAzQymiMnuwkDmWi4AyjVG5PtxWduMAE5W5LZN+R3b/s9?= =?us-ascii?Q?LKH1BuwHq5vUmuknQsKtP+Xjj+AxMdjx8OWhIiHXq7yJHq83pTrhGfodlvaf?= =?us-ascii?Q?in1ExJaoH6eAbK/MZjmDCLNYuiBVY31XyfaX7NTz69tFMJt91r+3Dpk/2W7s?= =?us-ascii?Q?5MRgbOVy5qPjBzZxWZ4YyZvDF5BPd2n/k5e3f9O4I/1RcWQpmoh0k9xhf1f4?= =?us-ascii?Q?G+5/1WFyeY9sgWquwVqWfKrHtqXJwzp9l+rwu2NF5I40i7m2pIawmO4AvKcA?= =?us-ascii?Q?4UyiDjLWIynPcvtT5jZ1NtqxM+5siW/HbhI4NJtWMsU12FnIDQ+ZRaz196CU?= =?us-ascii?Q?2vU0uluKmtGak3eFiMYzsSOKfMw3DTzURS61oNfEGfagG4eN1byN5GWoweQv?= =?us-ascii?Q?s82VyKKcP868QYLxc+3CFb8qxa/H2xiKP/Ch8IhY97gyEZKWDsM2JnpQ7ouJ?= =?us-ascii?Q?8hBR//WIJN87NzP5thpDVX90r3By0h2T1QD/YMVi949dthkOQW6wHX7UueTm?= =?us-ascii?Q?urKn9wZE/iy4ExQOTPgGnFjGdLN9tPWiR7yZ0adeBpl2mTpViiiwNlmk18jc?= =?us-ascii?Q?l5+99FansezVNbY6DvX6xA0VNZSVsRtJN+7EV0qhYp82Uwi/E0n5zWmS3znY?= =?us-ascii?Q?Ut3gRbibKrzg7u1IzxjXjSkEKVAShy0csqlQa0IGA01aw7HLq+QkNNg9c7AC?= =?us-ascii?Q?MNWVImFTnGh/uDqFgy7Cw4RRes+nJ4jsAnIltBMHOmgxt9VFQixHYTW0TB5W?= =?us-ascii?Q?9jI+RN3I3Vq74R0h/ZMKq0bVUV7itLRuGQsLIhA8AakBDaqlsWOENjTV1gJq?= =?us-ascii?Q?9FhMD3AhMBZ+GbAQuVqM7gzLPKL2COnlOGEf4Guq3lBdfeUTNauERPCVN/Hi?= =?us-ascii?Q?U0AGPAq38OFOcT3PB9Yax9lneCGuZUbL9ZF9VK7QieHC2nmNYYt8sDHSSC2E?= =?us-ascii?Q?NgW5NbUsVLsF233En5iRo68CEa2ewJlCSUz2r0TyvhEmd+YIXwtAr5Mi6UhF?= =?us-ascii?Q?KTY0Y0oMUMBm6kZTN7LWantSpugVVmlJSmNbfqgOPygkPok6A9ddWAP2MiOK?= =?us-ascii?Q?yQVhw7ok49pvP8q/qfGZ4i1P8u+fyvyPAHkp6nY5f3iqcCeNgguuEQo?= X-Microsoft-Exchange-Diagnostics: 1;CO2PR03MB2359;6:ZZul05XewKhPCGc1Z16tXCu6j8nD/0GBErdbjm7ADoVwXL3Tl5iHsZFE/QCBjsCpXG+9M+T2Me0QaYjv+8qxoCYz3uXZx14hKmdwBIJcmriQELzcpAP1/PFrCuaNKPNYu4jed+0AUMsRD2FqSh21QhfCbMtefuSlnvCt88bha4ojaSzN1EDx0y6fFfgXviPEYcwE70GDkaL1R0vW8NdF/YRkP+FvrKZ563MPaIBsKZPbr2WAtufvwyGPTNqVQsLPRGH48psQY+xcXMCHXlvz2Zq+6NFgD7v2vUaOrpM+UAQxT5tekvVsuea8aHWKA8vo5Yfc06A522PufJixiibpxU0Qn/wQIJxvWaAJu/oDrzE=;5:fBeW/E1JpnBae8JkneCe1k2bPXkJV4SGVTK8lbDGh6I1mdO4rnzSwx/9pEpWzGwc3FoiS7LxnwUoP2YujtqXTy0/wx6ntfBjRlncaKeEEpHNCEIOFiZs6R7rVodQRsqmE3FhANYDQfxovqme8KYfzL86vfuaKQJATEEk2Xj1kJk=;24:tgwdVmdLm/IN+KUGj8InnctXD4XgZXAtIlD7BWcIKryk4k56JpuLmMMCexq3dAKnP8dGuMVy9l6MVXfvauuGLpaDNs8gfINZDSluBLY6C5Q=;7:xpRKprHKzlYh++K1wwnXhZQgOIxdOVVPzpWIuo1V9e9PZeMV6wFV44tCymdYXE8ng7wzCUVmRWJGoY3GyTFPsBh3pa/ELHYwS0DeVv5odSZ4zITxejgWgaSZHR0Ci/xi4R+tFjFEzSVXUA74V+1VZaihkVP0QL+/bFuBZRyOsfn/s7Kr0kODUsDPbCHe4c+djC6YrGcAfwFEg0LbUVtnKFayNC1Pk1jsJG8fggiStQbNB7Da19PyIDbfzTy17ibo SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Dec 2017 02:55:48.8317 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 305e1645-feb8-4b69-cdde-08d5410bd964 X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[192.88.168.50];Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR03MB2359 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 11, 2017 at 04:09:44PM +0300, Dmitry Osipenko wrote: > On 11.12.2017 13:04, Thierry Reding wrote: > > On Mon, Dec 11, 2017 at 02:10:00AM +0300, Dmitry Osipenko wrote: > >> UDC driver won't probe without Tegra's PHY, hence select it in the > >> Kconfig. > >> > >> Signed-off-by: Dmitry Osipenko > >> --- > >> drivers/usb/chipidea/Kconfig | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/drivers/usb/chipidea/Kconfig b/drivers/usb/chipidea/Kconfig > >> index 785f0ed037f7..2ef3b27ea72b 100644 > >> --- a/drivers/usb/chipidea/Kconfig > >> +++ b/drivers/usb/chipidea/Kconfig > >> @@ -27,6 +27,7 @@ config USB_CHIPIDEA_PCI > >> config USB_CHIPIDEA_UDC > >> bool "ChipIdea device controller" > >> depends on USB_GADGET > >> + select USB_TEGRA_PHY if ARCH_TEGRA > > > > This is kind of pointless given that USB_TEGRA_PHY originally was > > automatically enabled if ARCH_TEGRA was enabled. > > Again, please take a closer look at the patches. USB_TEGRA_PHY was enabled if > USB_EHCI_TEGRA was and not ARCH_TEGRA. > > > What do we gain by these two patches, other than maybe make the driver > > buildable as a module? > > Firstly, tegra-phy is built only if ehci-tegra is built. > > Secondly, I think we need to enforce Tegra PHY to be compiled as built-in if one > of ehci-tegra or chipidea drivers is built-in and the other is compiled as a module. You may not bind controller driver with PHY driver in Kconfig, we need to make sure the controller driver has no build error if the PHY driver is not select. And if the PHY driver is not loaded, the controller driver should return -EPROBE_DEFER for it. -- Best Regards, Peter Chen