All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@samsung.com>
To: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Cc: "Linux Media Mailing List" <linux-media@vger.kernel.org>,
	"Mauro Carvalho Chehab" <mchehab@infradead.org>,
	lkml@vger.kernel.org, "Sean Young" <sean@mess.org>,
	"Philippe Ombredanne" <pombredanne@nexb.com>,
	"Colin Ian King" <colin.king@canonical.com>,
	"David Härdeman" <david@hardeman.nu>,
	"Bhumika Goyal" <bhumirks@gmail.com>,
	"Sakari Ailus" <sakari.ailus@linux.intel.com>,
	"Markus Elfring" <elfring@users.sourceforge.net>,
	"Arvind Yadav" <arvind.yadav.cs@gmail.com>,
	"Julia Lawall" <Julia.Lawall@lip6.fr>,
	"Christophe JAILLET" <christophe.jaillet@wanadoo.fr>,
	"Santosh Kumar Singh" <kumar.san1093@gmail.com>,
	"Andi Shyti" <andi.shyti@samsung.com>,
	"Andi Shyti" <andi@etezian.org>
Subject: Re: [PATCH v2 4/7] media: usb: add SPDX identifiers to some code I wrote
Date: Tue, 12 Dec 2017 16:08:04 +0900	[thread overview]
Message-ID: <20171212070804.GA6875@gangnam.samsung> (raw)
In-Reply-To: <e3c101aab92fa400f6ac532b39cdf82b39be6784.1512135871.git.mchehab@s-opensource.com>

Hi Mauro,

> diff --git a/drivers/media/usb/tm6000/tm6000-usb-isoc.h b/drivers/media/usb/tm6000/tm6000-usb-isoc.h
> index 6a13a27c55d7..e69f5cf8fe9f 100644
> --- a/drivers/media/usb/tm6000/tm6000-usb-isoc.h
> +++ b/drivers/media/usb/tm6000/tm6000-usb-isoc.h
> @@ -1,17 +1,7 @@
> -/*
> - *  tm6000-buf.c - driver for TM5600/TM6000/TM6010 USB video capture devices
> - *
> - *  Copyright (C) 2006-2007 Mauro Carvalho Chehab <mchehab@infradead.org>
> - *
> - *  This program is free software; you can redistribute it and/or modify
> - *  it under the terms of the GNU General Public License as published by
> - *  the Free Software Foundation version 2
> - *
> - *  This program is distributed in the hope that it will be useful,
> - *  but WITHOUT ANY WARRANTY; without even the implied warranty of
> - *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> - *  GNU General Public License for more details.
> - */
> +// SPDX-License-Identifier: GPL-2.0
> +// tm6000-buf.c - driver for TM5600/TM6000/TM6010 USB video capture devices
> +//
> +// Copyright (c) 2006-2007 Mauro Carvalho Chehab <mchehab@infradead.org>

shouldn't this and all the header files be of the type:

/* SPDX-License-Identifier: GPL-2.0 ... */

as stated here:

https://lwn.net/Articles/739183/

Andi

  parent reply	other threads:[~2017-12-12  7:08 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-01 13:47 [v2,1/7] edac: adjust GPLv2 license and SPDX identifiers at the code I wrote Mauro Carvalho Chehab
2017-12-01 13:47 ` [PATCH v2 1/7] " Mauro Carvalho Chehab
2017-12-01 13:47 ` [PATCH v2 2/7] media: rc: add SPDX identifiers to " Mauro Carvalho Chehab
2017-12-01 13:47 ` [PATCH v2 3/7] media: tuners: " Mauro Carvalho Chehab
2017-12-01 13:47 ` [PATCH v2 4/7] media: usb: add SPDX identifiers to some " Mauro Carvalho Chehab
2017-12-01 13:52   ` Sakari Ailus
2017-12-01 13:59     ` Mauro Carvalho Chehab
2017-12-01 14:32       ` Sakari Ailus
2017-12-12  7:08   ` Andi Shyti [this message]
2017-12-01 13:47 ` [PATCH v2 5/7] media: rc keymaps: add SPDX identifiers to the " Mauro Carvalho Chehab
2017-12-01 13:47 ` [PATCH v2 6/7] media: i2c: " Mauro Carvalho Chehab
2017-12-01 14:33   ` Sakari Ailus
2017-12-01 13:47 ` [PATCH v2 7/7] media: siano: add SPDX markups Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171212070804.GA6875@gangnam.samsung \
    --to=andi.shyti@samsung.com \
    --cc=Julia.Lawall@lip6.fr \
    --cc=andi@etezian.org \
    --cc=arvind.yadav.cs@gmail.com \
    --cc=bhumirks@gmail.com \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=colin.king@canonical.com \
    --cc=david@hardeman.nu \
    --cc=elfring@users.sourceforge.net \
    --cc=kumar.san1093@gmail.com \
    --cc=linux-media@vger.kernel.org \
    --cc=lkml@vger.kernel.org \
    --cc=mchehab@infradead.org \
    --cc=mchehab@s-opensource.com \
    --cc=pombredanne@nexb.com \
    --cc=sakari.ailus@linux.intel.com \
    --cc=sean@mess.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.