From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752358AbdLLIdk (ORCPT <rfc822;w@1wt.eu>);
        Tue, 12 Dec 2017 03:33:40 -0500
Received: from out3-smtp.messagingengine.com ([66.111.4.27]:60141 "EHLO
        out3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1751281AbdLLIdj (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 12 Dec 2017 03:33:39 -0500
X-ME-Sender: <xms:YpQvWkWGUVHbnlbWBINUxAMP6_HYieYBq1tEgeCCdZ0QwX9Fo7W1Cg>
Date: Tue, 12 Dec 2017 09:33:43 +0100
From: Greg KH <greg@kroah.com>
To: Kees Cook <keescook@chromium.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
        Alexey Dobriyan <adobriyan@gmail.com>,
        Dmitry Vyukov <dvyukov@google.com>, security@kernel.org,
        Akinobu Mita <akinobu.mita@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        "Eric W. Biederman" <ebiederm@xmission.com>,
        Josh Poimboeuf <jpoimboe@redhat.com>,
        LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@kernel.org>,
        syzkaller-bugs@googlegroups.com,
        Vegard Nossum <vegard.nossum@oracle.com>
Subject: Re: general protection fault in show_timer
Message-ID: <20171212083343.GG22935@kroah.com>
References: <94eb2c18a77ce8d832055f2cf263@google.com>
 <CACVxJT-WEm8KbmSCmQ_EWMRVDcoBp0g-DJRg89CJzi5+sekymg@mail.gmail.com>
 <CACT4Y+aTcJq7hu+azvd37XD09F8-PAXz4hNgKqYzXFb_iZndKQ@mail.gmail.com>
 <CACT4Y+ZGPYH5spxW=R5jn7=JCCo-_nfWvQdQLW7iESO+Lpmf9A@mail.gmail.com>
 <CACVxJT9Q+-1xGkVmdz+e6869Few90E+D8fMQWeSpW=MA76_03A@mail.gmail.com>
 <alpine.DEB.2.20.1711301355450.1925@nanos>
 <CAGXu5j+92ZebfVQHKoH0M3OcrqUC++YFj8EYy=kW7iNaa4_aFQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAGXu5j+92ZebfVQHKoH0M3OcrqUC++YFj8EYy=kW7iNaa4_aFQ@mail.gmail.com>
User-Agent: Mutt/1.9.1 (2017-09-22)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Dec 05, 2017 at 11:58:07AM -0800, Kees Cook wrote:
> On Thu, Nov 30, 2017 at 4:57 AM, Thomas Gleixner <tglx@linutronix.de> wrote:
> > On Thu, 30 Nov 2017, Alexey Dobriyan wrote:
> >
> >> [cc security@]
> >> 100% oops with interrupts disabled by nobody
> >> or kernel memory read
> >> [nods]
> >> you named the bug already
> >>
> >> "notify" directly comes from userspace struct sigevent::sigev_notify
> >> without adult supervision.
> >>
> >> Reproducer is timer_create + read(/proc/self/timers)
> >
> > Bah. That's a really old one.
> >
> > Tentative fix below. That needs more though but looking at the existing
> > check there is only one valid combo with SIGEV_THREAD_ID.
> >
> > Thanks,
> >
> >         tglx
> >
> > 8<----------------
> > --- a/kernel/time/posix-timers.c
> > +++ b/kernel/time/posix-timers.c
> > @@ -434,6 +434,16 @@ static struct pid *good_sigevent(sigeven
> >  {
> >         struct task_struct *rtn = current->group_leader;
> >
> > +       switch (event->sigev_notify) {
> > +       case SIGEV_NONE:
> > +       case SIGEV_SIGNAL:
> > +       case SIGEV_SIGNAL | SIGEV_THREAD_ID:
> > +       case SIGEV_THREAD:
> > +               break;
> > +       default:
> > +               return NULL;
> > +       }
> > +
> >         if ((event->sigev_notify & SIGEV_THREAD_ID ) &&
> >                 (!(rtn = find_task_by_vpid(event->sigev_notify_thread_id)) ||
> >                  !same_thread_group(rtn, current) ||
> 
> FWIW, this looks correct to me.

Did this ever go anywhere?  I don't see it in Linus's tree yet...

thanks,

greg k-h