All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Ed Swierk <eswierk@skyportsystems.com>
Cc: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
	Dan Williams <dcbw@redhat.com>, netdev <netdev@vger.kernel.org>,
	Benjamin Warren <ben@skyportsystems.com>,
	Keith Holleman <holleman@skyportsystems.com>
Subject: Re: [PATCH] veth: Optionally pad packets to minimum Ethernet length
Date: Tue, 12 Dec 2017 14:01:27 -0800	[thread overview]
Message-ID: <20171212140127.15bb8b73@xeon-e3> (raw)
In-Reply-To: <CAO_EM_m6XGoCRQPzYM36uP+MdQHQ6rPDY05eJyqkBTT8pjastA@mail.gmail.com>

On Tue, 12 Dec 2017 11:00:38 -0800
Ed Swierk <eswierk@skyportsystems.com> wrote:

> On Tue, Dec 12, 2017 at 10:34 AM, Stephen Hemminger
> <stephen@networkplumber.org> wrote:
> > Why not add to netdevsim rather than cluttering up a normal driver
> > with test support.  We just pulled a bunch of test stuff out of dummy
> > for the same reason.  
> 
> My test setup to trigger an openvswitch conntrack issue
> (https://marc.info/?l=linux-netdev&m=151309548725627) involves a lot
> of moving parts:
> 
> [netns-a: vetha1] - [vetha0] - [ovsbr0] - [vethb0] - [netns-b: vethb1]
> 
> with nc client and server in netns-a and -b, and tweaks like turning
> off tcp_timestamps to make sure the packets in the TCP stream are
> small enough to reproduce the problem. A simpler, less fragile test
> setup would be valuable, especially if it ends up as an automated
> regression test.
> 
> Could netdevsim be useful for that? Are there any existing tests
> producing TCP traffic that might serve as an example?
> 
> --Ed

Maybe add a netem impairment that does padding?

  reply	other threads:[~2017-12-12 22:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-12 16:13 [PATCH] veth: Optionally pad packets to minimum Ethernet length Ed Swierk
2017-12-12 17:32 ` Dan Williams
2017-12-12 18:18   ` Marcelo Ricardo Leitner
2017-12-12 18:34     ` Stephen Hemminger
2017-12-12 19:00       ` Ed Swierk
2017-12-12 22:01         ` Stephen Hemminger [this message]
2017-12-12 21:11 ` Cong Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171212140127.15bb8b73@xeon-e3 \
    --to=stephen@networkplumber.org \
    --cc=ben@skyportsystems.com \
    --cc=dcbw@redhat.com \
    --cc=eswierk@skyportsystems.com \
    --cc=holleman@skyportsystems.com \
    --cc=marcelo.leitner@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.