From: Darren Hart <dvhart@infradead.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Jason Gerecke <killertofu@gmail.com>,
Alex Hung <alex.hung@canonical.com>,
Andy Shevchenko <andy@infradead.org>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
Jason Gerecke <jason.gerecke@wacom.com>
Subject: Re: [PATCH][V2] intel-hid: add a DMI quirk to support Wacom MobileStudio Pro
Date: Tue, 12 Dec 2017 08:00:12 -0800 [thread overview]
Message-ID: <20171212160012.GI27831@fury> (raw)
In-Reply-To: <CAHp75VeDarmDs1tALkv4tiO_NMa7uhC26bF_Yc0Bv98KpK_nHw@mail.gmail.com>
On Tue, Dec 12, 2017 at 10:02:36AM +0200, Andy Shevchenko wrote:
> On Tue, Dec 12, 2017 at 2:51 AM, Darren Hart <dvhart@infradead.org> wrote:
> > On Mon, Dec 11, 2017 at 02:13:40PM -0800, Jason Gerecke wrote:
> >> On Fri, Dec 8, 2017 at 4:04 PM, Darren Hart <dvhart@infradead.org> wrote:
> >> > On Thu, Dec 07, 2017 at 11:40:23AM +0800, Alex Hung wrote:
> >> >> HEBC method reports capabilities of 5 button array but Wacom
> >> >> MobileStudio Pro does not have this control method. A DMI quirk
> >> >> was created to enable 5 button array for this system.
> >> >
> >> > Jason, have you been able to verify this patch with testing?
> >> >
> >>
> >> I tested the attachment at [1], which produces an identical copy of
> >> intel-hid.c as applying this patch to the
> >> platform-drivers-x86/review-dvhart branch of
> >> git://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git.
> >>
> >> Assuming that's the correct code, feel free to attach the following:
> >> Tested-by: Jason Gerecke <jason.gerecke@wacom.com>
> >
> > Great, thanks. Queued up for testing.
>
> Just in case you didn't promote it yet, could you move inclusion to be
> more ordered alphabetically? (After linux/acpi.h I suppose)
I had done that initially, but realized the entire list is in no apparent order
and it wasn't just moving the one line he added. So it'll need to be a cleanup
patch since all the test builds have run already.
--
Darren Hart
VMware Open Source Technology Center
next prev parent reply other threads:[~2017-12-12 16:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-07 3:40 [PATCH][V2] intel-hid: add a DMI quirk to support Wacom MobileStudio Pro Alex Hung
2017-12-09 0:04 ` Darren Hart
2017-12-11 22:13 ` Jason Gerecke
2017-12-12 0:51 ` Darren Hart
2017-12-12 8:02 ` Andy Shevchenko
2017-12-12 16:00 ` Darren Hart [this message]
2017-12-12 16:13 ` Andy Shevchenko
2017-12-14 7:25 ` Alex Hung
2017-12-14 9:09 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171212160012.GI27831@fury \
--to=dvhart@infradead.org \
--cc=alex.hung@canonical.com \
--cc=andy.shevchenko@gmail.com \
--cc=andy@infradead.org \
--cc=jason.gerecke@wacom.com \
--cc=killertofu@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.