All of lore.kernel.org
 help / color / mirror / Atom feed
From: paulmck@linux.vnet.ibm.com (Paul E. McKenney)
To: linux-arm-kernel@lists.infradead.org
Subject: WARNING: suspicious RCU usage
Date: Tue, 12 Dec 2017 09:21:22 -0800	[thread overview]
Message-ID: <20171212172122.GD7829@linux.vnet.ibm.com> (raw)
In-Reply-To: <CAOMZO5AftAWz339Sy+oxQ8K9Dr04Jyf8SV0R0JGrcPaL-VQLMQ@mail.gmail.com>

On Tue, Dec 12, 2017 at 02:56:18PM -0200, Fabio Estevam wrote:
> Hi Paul,
> 
> On Tue, Dec 12, 2017 at 2:49 PM, Paul E. McKenney
> <paulmck@linux.vnet.ibm.com> wrote:
> 
> > On the perhaps unlikely off-chance that it is both useful and welcome,
> > the (untested, probably does not even build) patch below illustrates the
> > use of smp_call_function_single().  This is based on the patch Russell
> > sent -- for all I know, it might well be that there are other places
> > needing similar changes.
> >
> > But something to try out for anyone wishing to do so.
> >
> >                                                         Thanx, Paul
> >
> > ------------------------------------------------------------------------
> >
> > commit c579a1494ccbc7ebf5548115571a2988ea1a1fe5
> > Author: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> > Date:   Mon Dec 11 09:40:58 2017 -0800
> >
> >     ARM: CPU hotplug: Delegate complete() to surviving CPU
> >
> >     The ARM implementation of arch_cpu_idle_dead() invokes complete(), but
> >     does so after RCU has stopped watching the outgoing CPU, which results
> >     in lockdep complaints because complete() invokes functions containing RCU
> >     readers.  This patch therefore uses Thomas Gleixner's trick of delegating
> >     the complete() call to a surviving CPU via smp_call_function_single().
> >
> >     This patch is untested, and probably does not even build.
> >
> >     Reported-by: Peng Fan <van.freenix@gmail.com>
> >     Reported-by: Russell King - ARM Linux <linux@armlinux.org.uk>
> >     Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> 
> With your patch applied I no longer get the RCU warning, thanks:
> 
> Tested-by: Fabio Estevam <fabio.estevam@nxp.com>

Well, I guess that it is no longer untested, and thank you for that.  ;-)

I sent a more official posting of the patch.

							Thanx, Paul

  reply	other threads:[~2017-12-12 17:21 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-10 11:39 WARNING: suspicious RCU usage Peng Fan
2017-12-10 12:00 ` Russell King - ARM Linux
2017-12-10 19:07   ` Paul E. McKenney
2017-12-10 19:34     ` Russell King - ARM Linux
2017-12-10 21:39       ` Paul E. McKenney
2017-12-10 21:54         ` Russell King - ARM Linux
2017-12-10 23:16           ` Paul E. McKenney
2017-12-12 16:49         ` Paul E. McKenney
2017-12-12 16:56           ` Fabio Estevam
2017-12-12 17:21             ` Paul E. McKenney [this message]
2017-12-12 17:34             ` Russell King - ARM Linux
2017-12-12 18:11               ` Fabio Estevam
2017-12-12 19:36                 ` Paul E. McKenney
2017-12-12 19:44                   ` Fabio Estevam
2017-12-12 19:54                     ` Russell King - ARM Linux
2017-12-12 21:05                       ` Fabio Estevam
2017-12-13  9:12                 ` Russell King - ARM Linux
2017-12-15  6:38                   ` Paul E. McKenney
2017-12-15 13:16                     ` Fabio Estevam
2017-12-15 15:52                       ` Paul E. McKenney
2017-12-15 18:23                         ` Paul E. McKenney
2017-12-15 20:36                           ` Fabio Estevam
2017-12-15 21:34                             ` Paul E. McKenney
2017-12-15 21:43                               ` Fabio Estevam
2017-12-15 22:56                                 ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171212172122.GD7829@linux.vnet.ibm.com \
    --to=paulmck@linux.vnet.ibm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.