All of lore.kernel.org
 help / color / mirror / Atom feed
From: Helge Deller <deller@gmx.de>
To: John David Anglin <dave.anglin@bell.net>,
	linux-parisc@vger.kernel.org,
	James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Frank Scheiner <frank.scheiner@web.de>, debian-hppa@lists.debian.org
Subject: Re: Have my PA8800 back online...
Date: Tue, 12 Dec 2017 21:52:26 +0100	[thread overview]
Message-ID: <20171212205226.GA22082@ls3530.fritz.box> (raw)
In-Reply-To: <c02fe6c5-9564-21ab-3012-a0a5d0509fc4@bell.net>

* John David Anglin <dave.anglin@bell.net>:
> On 2017-12-11 9:46 AM, Helge Deller wrote:
> > Strange. The attached patch does work for me on panama up until boot.
> > Haven't tested what lspci reports afterwards...

> Yes, it also works for me applied to v4.13.16.  ttyS1 is now ttyS0.

Good.

> Haven't tried boot without console argument yet.
> lspci still sees the hidden devices which I think is good.

Agreed.

> I removed period from one of the dev_info strings.  We probably don't need
> printk's that I added.

Yes, I dropped them.
Here is an updated patch for patchwork:

_________

Hide serial AUX and ATI functions on Diva GSP card

Signed-off-by: Helge Deller <deller@gmx.de>

diff --git a/drivers/parisc/lba_pci.c b/drivers/parisc/lba_pci.c
index a25fed52f7e9..55fb30057d5e 100644
--- a/drivers/parisc/lba_pci.c
+++ b/drivers/parisc/lba_pci.c
@@ -1692,3 +1692,37 @@ void lba_set_iregs(struct parisc_device *lba, u32 ibase, u32 imask)
 	iounmap(base_addr);
 }
 
+
+/*
+ * The design of the Diva management card in rp34x0 machines (rp3410, rp3440)
+ * seems rushed, so that many built-in components simply don't work.
+ * The following quirks disable the serial AUX port and the built-in ATI RV100
+ * Radeon 7000 graphics card which both don't have any external connectors and
+ * thus are useless, and even worse, e.g. the AUX port occupies ttyS0 and as
+ * such makes those machines the only PARISC machines on which we can't use
+ * ttyS0 as boot console.
+ */
+static void quirk_diva_ati_card(struct pci_dev *dev)
+{
+	if (dev->subsystem_vendor != PCI_VENDOR_ID_HP ||
+	    dev->subsystem_device != 0x1292)
+		return;
+
+	dev_info(&dev->dev, "Hiding Diva built-in ATI card");
+	dev->device = 0;
+}
+DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_RADEON_QY,
+	quirk_diva_ati_card);
+
+static void quirk_diva_aux_disable(struct pci_dev *dev)
+{
+	if (dev->subsystem_vendor != PCI_VENDOR_ID_HP ||
+	    dev->subsystem_device != 0x1291)
+		return;
+
+	dev_info(&dev->dev, "Hiding Diva built-in AUX serial device");
+	dev->device = 0;
+}
+DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_HP, PCI_DEVICE_ID_HP_DIVA_AUX,
+	quirk_diva_aux_disable);
+

      reply	other threads:[~2017-12-12 20:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <2ADB5C8A-DFEB-4CA5-92BA-96E459A3575E@bell.net>
     [not found] ` <8314a5d6-7df7-3282-0d91-a9b414a122e0@web.de>
     [not found]   ` <526274E4-88D8-4DF8-8F74-5B775186BBEC@bell.net>
     [not found]     ` <cc22ee64-e9f3-aeb4-a9a0-a503f20f9634@web.de>
     [not found]       ` <48320506-f7fa-822b-fb45-40eab1dbda02@bell.net>
     [not found]         ` <17707adb-4f71-1d66-2a19-3cdfaff047f3@gmx.de>
     [not found]           ` <53815372-58e8-70e2-bab4-1777e848cf5e@web.de>
2017-12-08 19:06             ` Have my PA8800 back online... (serial port missing on v4.14) Helge Deller
2017-12-11  8:26               ` Andy Shevchenko
2017-12-12 20:11                 ` Helge Deller
2017-12-13 15:16                   ` Andy Shevchenko
2017-12-18 20:07                     ` Helge Deller
2017-12-19 10:53                       ` Andy Shevchenko
     [not found]             ` <79c110ec-2975-a827-4b9d-1351ab77779b@gmx.de>
     [not found]               ` <d3c1e035-6486-c0b5-e87a-22d26c0c95f5@bell.net>
2017-12-09 21:03                 ` Have my PA8800 back online Helge Deller
     [not found]                   ` <897B27DE-04A1-4906-8DF2-C037393139C3@bell.net>
2017-12-11 14:46                     ` Helge Deller
2017-12-11 15:25                       ` John David Anglin
2017-12-12 15:59                       ` John David Anglin
2017-12-12 20:52                         ` Helge Deller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171212205226.GA22082@ls3530.fritz.box \
    --to=deller@gmx.de \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=dave.anglin@bell.net \
    --cc=debian-hppa@lists.debian.org \
    --cc=frank.scheiner@web.de \
    --cc=linux-parisc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.