From: Yaowei Bai <baiyaowei@cmss.chinamobile.com>
To: David Rientjes <rientjes@google.com>
Cc: Randy Dunlap <rdunlap@infradead.org>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/8] make some functions return bool
Date: Tue, 12 Dec 2017 23:16:41 -0500 [thread overview]
Message-ID: <20171213041641.GA30654@byw> (raw)
In-Reply-To: <alpine.DEB.2.10.1712121946120.83765@chino.kir.corp.google.com>
On Tue, Dec 12, 2017 at 07:47:09PM -0800, David Rientjes wrote:
> On Tue, 12 Dec 2017, Randy Dunlap wrote:
>
> > Sure, but I didn't keep the patch emails.
> >
> > Acked-by: Randy Dunlap <rdunlap@infradead.org>
> >
>
> You may have noticed changing functions like is_file_lru() to bool when it
> is used to index into an array or as part of an arithmetic operation for
Yes, you're right. is_file_lru should not return bool. I'm using some
automitic ways to detect this type of functions. Pls ignore that patch
or i'll resend patchset without that one later. Thanks.
> ZVC stats. I'm not sure why you would ack such code.
prev parent reply other threads:[~2017-12-13 4:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-12 2:55 [PATCH 0/8] make some functions return bool Yaowei Bai
2017-12-12 2:55 ` [PATCH 1/8] mm/memblock: memblock_is_map/region_memory can be boolean Yaowei Bai
2017-12-12 16:03 ` Joe Perches
2017-12-13 2:32 ` Yaowei Bai
2017-12-12 2:55 ` [PATCH 2/8] mm/mmzone: mm/lru: is_file/active_lru " Yaowei Bai
2017-12-12 2:55 ` [PATCH 3/8] lib/lockref: __lockref_is_dead " Yaowei Bai
2017-12-12 2:55 ` [PATCH 4/8] kernel/cpuset: current_cpuset_is_being_rebound " Yaowei Bai
2017-12-12 2:55 ` [PATCH 5/8] kernel/resource: iomem_is_exclusive " Yaowei Bai
2017-12-12 2:55 ` [PATCH 6/8] kernel/module: module_is_live " Yaowei Bai
2017-12-12 2:55 ` [PATCH 7/8] kernel/mutex: mutex_is_locked " Yaowei Bai
2017-12-12 2:55 ` [PATCH 8/8] crash_dump: is_kdump_kernel " Yaowei Bai
2017-12-12 5:50 ` [PATCH 0/8] make some functions return bool David Rientjes
2017-12-12 7:21 ` Yaowei Bai
2017-12-12 8:12 ` Nikolay Borisov
2017-12-12 17:20 ` Randy Dunlap
2017-12-13 2:14 ` Yaowei Bai
2017-12-13 2:32 ` Randy Dunlap
2017-12-13 2:58 ` Yaowei Bai
2017-12-13 3:47 ` David Rientjes
2017-12-13 4:16 ` Yaowei Bai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171213041641.GA30654@byw \
--to=baiyaowei@cmss.chinamobile.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.