From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Mimi Zohar <zohar@linux.vnet.ibm.com>,
Christoph Hellwig <hch@infradead.org>,
linux-xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] xfs: include the XFS magic number in magic.h
Date: Wed, 13 Dec 2017 00:43:31 -0800 [thread overview]
Message-ID: <20171213084331.GA19323@infradead.org> (raw)
In-Reply-To: <20171213025928.GZ5858@dastard>
On Wed, Dec 13, 2017 at 01:59:28PM +1100, Dave Chinner wrote:
> IOWs, if you need to identify a filesystem *type*, using internal
> magic numbers is not the way to do it. selinux, for example, checks
> sb->s_type->name quite a lot....
And that is bad enough to start with. It should check for specific
features, and not the file system driver name.
next prev parent reply other threads:[~2017-12-13 8:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-12 14:21 [PATCH] xfs: include the XFS magic number in magic.h Mimi Zohar
2017-12-12 14:26 ` Christoph Hellwig
2017-12-12 14:34 ` Mimi Zohar
2017-12-12 14:36 ` Christoph Hellwig
2017-12-12 15:04 ` Mimi Zohar
2017-12-12 23:30 ` Dave Chinner
2017-12-12 23:55 ` Mimi Zohar
2017-12-13 0:13 ` Dave Chinner
2017-12-13 1:21 ` Mimi Zohar
2017-12-13 2:59 ` Dave Chinner
2017-12-13 8:43 ` Christoph Hellwig [this message]
2017-12-13 14:04 ` Mimi Zohar
2017-12-12 21:13 ` Dave Chinner
2017-12-12 23:35 ` Mimi Zohar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171213084331.GA19323@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.