From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/drm_lease: Do not call drm_master_put() twice in case drm_lease_create() fails Date: Wed, 13 Dec 2017 11:44:06 +0100 Message-ID: <20171213104406.GG526@phenom.ffwll.local> References: <20171212120414.8675-1-marius-cristian.vlad@nxp.com> <20171212153020.GD526@phenom.ffwll.local> <1513093446.3780.13.camel@nxp.com> <20171213082310.GF526@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x231.google.com (mail-wm0-x231.google.com [IPv6:2a00:1450:400c:c09::231]) by gabe.freedesktop.org (Postfix) with ESMTPS id 241476E1D5 for ; Wed, 13 Dec 2017 10:44:10 +0000 (UTC) Received: by mail-wm0-x231.google.com with SMTP id f140so4114396wmd.2 for ; Wed, 13 Dec 2017 02:44:10 -0800 (PST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Marius-cristian Vlad Cc: "daniel.vetter@ffwll.ch" , "keithp@keithp.com" , "dri-devel@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBEZWMgMTMsIDIwMTcgYXQgMDk6MTg6NTVBTSArMDAwMCwgTWFyaXVzLWNyaXN0aWFu IFZsYWQgd3JvdGU6Cj4gV2VsbCBJIGRvbid0IGhhdmUgYW4gaWd0IHRlc3QgZm9yIGl0LCBidXQg aGVyZSdzIHdoYXQgaGFwcGVucyB3aGVuIEkgdHJ5IHRvCj4gY3JlYXRlIGEgbmV3IGxlYXNlIHdo aWNoIGhhc24ndCBiZWVuIHJldm9rZWQgKHNvLCBpdCdzIGN1cnJlbnRseSBjcmVhdGVkIGJ1dCBu b3QgcmV2b2tlZCBhbmQKPiB0cnlpbmcgdG8gY3JlYXRlIGEgbmV3IG9uZSk6Cj4gCj4gWyAgMjEw LjM0NzA1Ml0gW2RybTpkcm1faW9jdGxdIHBpZD0zMzA5LCBkZXY9MHhlMjAwLCBhdXRoPTEsIERS TV9JT0NUTF9NT0RFX0NSRUFURV9MRUFTRQo+IFsgIDIxMC4zNDcwNjhdIFtkcm06ZHJtX21vZGVf Y3JlYXRlX2xlYXNlX2lvY3RsXSBBZGRpbmcgb2JqZWN0IDQ0IHRvIGxlYXNlCj4gWyAgMjEwLjM0 NzA4MV0gW2RybTpkcm1fbW9kZV9jcmVhdGVfbGVhc2VfaW9jdGxdIEFkZGluZyBvYmplY3QgMjUg dG8gbGVhc2UKPiBbICAyMTAuMzQ3MDkxXSBbZHJtOmRybV9tb2RlX2NyZWF0ZV9sZWFzZV9pb2N0 bF0gQWRkaW5nIG9iamVjdCAyNiB0byBsZWFzZQo+IFsgIDIxMC4zNDcxMDBdIFtkcm06ZHJtX21v ZGVfb2JqZWN0X3VucmVmZXJlbmNlXSBPQkogSUQ6IDQ0ICg1KQo+IFsgIDIxMC4zNDcxMTFdIFtk cm06ZHJtX21vZGVfY3JlYXRlX2xlYXNlX2lvY3RsXSBDcmVhdGluZyBsZWFzZQo+IFsgIDIxMC4z NDcxMjBdIFtkcm06ZHJtX21vZGVfY3JlYXRlX2xlYXNlX2lvY3RsXSBsZXNzb3IgMAo+IFsgIDIx MC4zNDcxMzZdIFtkcm06ZHJtX21vZGVfY3JlYXRlX2xlYXNlX2lvY3RsXSBvYmplY3QgMjMgZmFp bGVkIC0xNgo+IFsgbm90aGluZyBwcmludGVkIGFueW1vcmUgXSBwcm9jZXNzIGlzIHN0dWNrCj4g Cj4gRG9pbmcgYW4gZWNobyB3ID4gL3Byb2Mvc3lzcnEtdHJpZ2dlciBzaG93cyB0aGUgZm9sbG93 aW5nOgo+IAo+IFsgIDI2Ny43MzI5NTRdIHN5c3JxOiBTeXNScSA6IFNob3cgQmxvY2tlZCBTdGF0 ZQo+IFsgIDI2Ny43MzczNTldICAgdGFzayAgICAgICAgICAgICAgICAgICAgICAgIFBDIHN0YWNr ICAgcGlkIGZhdGhlcgo+IFsgIDI2Ny43NDM1NDNdIHdlc3RvbiAgICAgICAgICBEICAgIDAgIDMz MDkgICAzMjc4IDB4MDAwMDAyMDAKPiBbICAyNjcuNzQ5MjQ5XSBDYWxsIHRyYWNlOgo+IFsgIDI2 Ny43NTE3MDhdIFs8ZmZmZjAwMDAwODA4NTYwND5dIF9fc3dpdGNoX3RvKzB4OGMvMHhhMAo+IFsg IDI2Ny43NTY4OThdIFs8ZmZmZjAwMDAwOGJjZmUxMD5dIF9fc2NoZWR1bGUrMHgxNzgvMHg1ODAK PiBbICAyNjcuNzYyMTYxXSBbPGZmZmYwMDAwMDhiZDAyNTQ+XSBzY2hlZHVsZSsweDNjLzB4YTgK PiBbICAyNjcuNzY3MDc5XSBbPGZmZmYwMDAwMDhiZDA2NTA+XSBzY2hlZHVsZV9wcmVlbXB0X2Rp c2FibGVkKzB4MjAvMHgzOAo+IFsgIDI2Ny43NzM0NzddIFs8ZmZmZjAwMDAwOGJkMWI5MD5dIF9f bXV0ZXhfbG9ja19zbG93cGF0aCsweGMwLzB4MTQwCj4gWyAgMjY3Ljc3OTYwNV0gWzxmZmZmMDAw MDA4YmQxYzU0Pl0gbXV0ZXhfbG9jaysweDQ0LzB4NjAKPiBbICAyNjcuNzg0NzAwXSBbPGZmZmYw MDAwMDg1ZDRmNTA+XSBkcm1fbGVhc2VfZGVzdHJveSsweDI4LzB4MTA4Cj4gWyAgMjY3Ljc5MDQ4 M10gWzxmZmZmMDAwMDA4NWIzMWMwPl0gZHJtX21hc3Rlcl9wdXQrMHhjMC8weGM4Cj4gWyAgMjY3 Ljc5NTkyMl0gWzxmZmZmMDAwMDA4NWQ1NGQ4Pl0gZHJtX21vZGVfY3JlYXRlX2xlYXNlX2lvY3Rs KzB4NDY4LzB4ODA4Cj4gWyAgMjY3LjgwMjY2NF0gWzxmZmZmMDAwMDA4NWI4N2UwPl0gZHJtX2lv Y3RsKzB4MTk4LzB4NDQ4Cj4gWyAgMjY3LjgwNzg0MF0gWzxmZmZmMDAwMDA4MWYwNjdjPl0gZG9f dmZzX2lvY3RsKzB4YTQvMHg3NDgKPiBbICAyNjcuODEzMTg3XSBbPGZmZmYwMDAwMDgxZjBkYWM+ XSBTeVNfaW9jdGwrMHg4Yy8weGEwCj4gWyAgMjY3LjgxOTUyMl0gWzxmZmZmMDAwMDA4MDgyZjRj Pl0gX19zeXNfdHJhY2VfcmV0dXJuKzB4MC8weDQKPiAKPiBJIHdhcyB1bmRlciB0aGUgaW1wcmVz c2lvbiB0aGF0IGRybV9sZWFzZV9kZXN0cm95KCkgZ2V0cyBjYWxsZWQgdHdpY2UuIAoKVGhhdCdz IGEgZGVhZGxvY2ssIG5vdCBhIGRvdWJsZSBmcmVlLiBQbGVhc2UgaW5jbHVkZSBjcnVjaWFsIGlu Zm9ybWF0aW9uCmxpa2UgdGhpcyBpbiB5b3VyIHBhdGNoIG5leHQgdGltZSBhcm91bmQuIEVuYWJs aW5nIGxvY2tkZXAgc2hvdWxkIGhlbHAgeW91CmZpZ3VyZSBvdXQgd2hhdCdzIGdvaW5nIHdyb25n IGhlcmUuCi1EYW5pZWwKPiAKPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQo+IEZyb206IERh bmllbCBWZXR0ZXIgW21haWx0bzpkYW5pZWwudmV0dGVyQGZmd2xsLmNoXSBPbiBCZWhhbGYgT2Yg RGFuaWVsIFZldHRlcgo+IFNlbnQ6IFdlZG5lc2RheSwgRGVjZW1iZXIgMTMsIDIwMTcgMTA6MjMg QU0KPiBUbzogTWFyaXVzLWNyaXN0aWFuIFZsYWQgPG1hcml1cy1jcmlzdGlhbi52bGFkQG54cC5j b20+Cj4gQ2M6IGRhbmllbEBmZndsbC5jaDsgZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9y Zzsga2VpdGhwQGtlaXRocC5jb207IGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2gKPiBTdWJqZWN0OiBS ZTogW1BBVENIXSBkcm0vZHJtX2xlYXNlOiBEbyBub3QgY2FsbCBkcm1fbWFzdGVyX3B1dCgpIHR3 aWNlIGluIGNhc2UgZHJtX2xlYXNlX2NyZWF0ZSgpIGZhaWxzCj4gCj4gT24gVHVlLCBEZWMgMTIs IDIwMTcgYXQgMDM6NDQ6MDdQTSArMDAwMCwgTWFyaXVzLWNyaXN0aWFuIFZsYWQgd3JvdGU6Cj4g PiBkcm1fbW9kZV9jcmVhdGVfbGVhc2VfaW9jdGwoKSAtPiBkcm1fbGVhc2VfY3JlYXRlKCkKPiA+ IAo+ID4gZHJtX2xlYXNlX2NyZWF0ZSgpIC0+IGZhaWxzIGFuZCBkcm1fbWFzdGVyX3B1dCgpIGlz IGNhbGxlZAo+ID4gdHdpY2U6IG9uY2UgaW4gZHJtX2xlYXNlX2NyZWF0ZSgpIGFuZCBvbmNlIGlu IAo+ID4gZHJtX21vZGVfY3JlYXRlX2xlYXNlX2lvY3RsKCkuCj4gPiAKPiA+IEZyb20gZHJtX21v ZGVfY3JlYXRlX2xlYXNlX2lvY3RsKCk6Cj4gPiAKPiA+IAlsZXNzZWUgPSBkcm1fbGVhc2VfY3Jl YXRlKGxlc3NvciwgJmxlYXNlcyk7Cj4gPiDCoMKgwqDCoMKgwqDCoMKgaWYgKElTX0VSUihsZXNz ZWUpKSB7Cj4gPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoHJldCA9IFBUUl9FUlIo bGVzc2VlKTsKPiA+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgZ290byBvdXRfbGVh c2VzOwo+ID4gwqDCoMKgwqDCoMKgwqDCoH0KPiA+IC4uLi4KPiA+IG91dF9sZXNzZWU6Cj4gCj4g b3V0X2xlc3NlZSAhPSBvdXRfbGVhc2VzCj4gCj4gPiDCoMKgwqDCoMKgwqDCoMKgZHJtX21hc3Rl cl9wdXQoJmxlc3NlZSk7IDwtIGJ1dCB3ZSBhbHJlYWR5IGRvbmUgdGhpcyBpbiAKPiA+IGRybV9s ZWFzZV9jcmVhdGUoKS4KPiAKPiBUaGlzIGlzIHRoZSBwYXRoIEkgY2hlY2tlZCwgbG9va3MgYWxs IGNvcnJlY3QgdG8gbWUuIFdoZXJlIGV4YWN0bHkgaGF2ZSB5b3Ugb2JzZXJ2ZWQgdGhlIGxlYWs/ IERvIHdlIGhhdmUgYSB0ZXN0Y2FzZSAoaWd0IHZlcnkgbXVjaCBwcmVmZXJyZWQsIHNpY25lIHRo ZW4gYXQgbGVhc3QgdGhlIGludGVsIHRlYW0gd2lsbCBDSSBpdCBjb25zdGFudGx5KSB0aGF0IHJl cHJvZHVjZXMgdGhlIGxlYWs/Cj4gLURhbmllbAo+IAo+ID4gCj4gPiAKPiA+IE9uIFR1ZSwgMjAx Ny0xMi0xMiBhdCAxNjozMCArMDEwMCwgRGFuaWVsIFZldHRlciB3cm90ZToKPiA+ID4gT24gVHVl LCBEZWMgMTIsIDIwMTcgYXQgMDI6MDQ6MTRQTSArMDIwMCwgTWFyaXVzIFZsYWQgd3JvdGU6Cj4g PiA+ID4gVGhpcyBjYXNlIGNhbiBiZWVuIHNlZW4gd2hlbiBjcmVhdGluZyB0aGUgbGVhc2Ugd2l0 aCBzYW1lIG9iamVjdHMgCj4gPiA+ID4gcGFzc2VkLgo+ID4gPiA+IAo+ID4gPiA+IFNpZ25lZC1v ZmYtYnk6IE1hcml1cyBWbGFkIDxtYXJpdXMtY3Jpc3RpYW4udmxhZEBueHAuY29tPgo+ID4gPiA+ IC0tLQo+ID4gPiA+IMKgZHJpdmVycy9ncHUvZHJtL2RybV9sZWFzZS5jIHwgMiAtLQo+ID4gPiA+ IMKgMSBmaWxlIGNoYW5nZWQsIDIgZGVsZXRpb25zKC0pCj4gPiA+ID4gCj4gPiA+ID4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fbGVhc2UuYyAKPiA+ID4gPiBiL2RyaXZlcnMvZ3B1 L2RybS9kcm1fbGVhc2UuYyBpbmRleCBkMWViNTZhLi5hZTU3ZjMzIDEwMDY0NAo+ID4gPiA+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fbGVhc2UuYwo+ID4gPiA+ICsrKyBiL2RyaXZlcnMvZ3B1 L2RybS9kcm1fbGVhc2UuYwo+ID4gPiA+IEBAIC0yNTQsOCArMjU0LDYgQEAgc3RhdGljIHN0cnVj dCBkcm1fbWFzdGVyIAo+ID4gPiA+ICpkcm1fbGVhc2VfY3JlYXRlKHN0cnVjdCBkcm1fbWFzdGVy ICpsZXNzb3IsIHN0cnVjdCBpZHIKPiA+ID4gPiDCoAlyZXR1cm4gbGVzc2VlOwo+ID4gPiA+IMKg Cj4gPiA+ID4gwqBvdXRfbGVzc2VlOgo+ID4gPiA+IC0JZHJtX21hc3Rlcl9wdXQoJmxlc3NlZSk7 Cj4gPiA+IAo+ID4gPiBJJ20gbm90IHJlYWxseSBmb2xsb3dpbmcgaGVyZSAuLi4gdGhlIGxlc3Nl ZSByZWZlcmVuY2Ugd2UncmUgCj4gPiA+IGRyb3BwaW5nIGhlcmUgaXMgY3JlYXRlZCBpbiBkcm1f bWFzdGVyX2NyZWF0ZS4gV2UncmUgb25seSBjYWxsaW5nIAo+ID4gPiBkcm1fbWFzdGVyX3B1dCBp ZiB0aGF0IHN1Y2NlZWRlZC4gUmVtb3ZpbmcgdGhpcyBsaW5lIGhlcmUgbG9va3MgbGlrZSAKPiA+ ID4gbm93IHdlJ3JlIGxlYWtpbmcuCj4gPiA+IAo+ID4gPiBXaGVyZSBpcyB0aGUgZG91YmxlLWZy ZWU/IEkgZG9uJ3Qgc2VlIHRoZSAybmQgZHJtX21hc3Rlcl9wdXQoKSAKPiA+ID4gYW55d2hlcmUg Li4uIGRybV9tb2RlX2NyZWF0ZV9sZWFzZV9pb2N0bCBhbHNvIHNlZW1zIHRvIGJlIGRvaW5nIHRo ZSAKPiA+ID4gcmlnaHQgdGhpbmcgZnJvbSBqdXN0IHN0YXJpbmcgYXQgaXQuCj4gPiA+IC1EYW5p ZWwKPiAKPiAtLQo+IERhbmllbCBWZXR0ZXIKPiBTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29y cG9yYXRpb24KPiBodHRwczovL2VtZWEwMS5zYWZlbGlua3MucHJvdGVjdGlvbi5vdXRsb29rLmNv bS8/dXJsPWh0dHAlM0ElMkYlMkZibG9nLmZmd2xsLmNoJmRhdGE9MDIlN0MwMSU3Q21hcml1cy1j cmlzdGlhbi52bGFkJTQwbnhwLmNvbSU3QzNmNTNmOWY2YjRmMzQ1MzU5NWM4MDhkNTQyMDJjMTYx JTdDNjg2ZWExZDNiYzJiNGM2ZmE5MmNkOTljNWMzMDE2MzUlN0MwJTdDMCU3QzYzNjQ4NzUwMTk2 NDI1NzA0OCZzZGF0YT1WRTlvanJKMEhqYTF3VnVZJTJGbU4lMkZlREdYVDVwbGpYSks3YkNLU0N6 Zjg3RSUzRCZyZXNlcnZlZD0wCgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwg SW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmkt ZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==