From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752833AbdLMMeF (ORCPT ); Wed, 13 Dec 2017 07:34:05 -0500 Received: from mail.kernel.org ([198.145.29.99]:51554 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752175AbdLMMeE (ORCPT ); Wed, 13 Dec 2017 07:34:04 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BC21120C0F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Wed, 13 Dec 2017 09:33:58 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: David Ahern , Steven Rostedt , lkml , Ingo Molnar , Namhyung Kim , Peter Zijlstra Subject: Re: [PATCH] perf tools: Fix swap for samples with raw data Message-ID: <20171213123358.GR3958@kernel.org> References: <20171129184346.3656-1-jolsa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171129184346.3656-1-jolsa@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, Nov 29, 2017 at 07:43:46PM +0100, Jiri Olsa escreveu: > The fix is basically to swap back the raw data if different > endianity is detected. > +++ b/tools/perf/util/evsel.c > @@ -36,6 +36,7 @@ > #include "trace-event.h" > #include "stat.h" > +#include "memswap.h" > @@ -2131,14 +2132,27 @@ int perf_evsel__parse_sample(struct perf_evsel *evsel, union perf_event *event, > if (type & PERF_SAMPLE_RAW) { > + if (swapped) > + mem_bswap_64((void *) array, data->raw_size); > + you forgot to add util/memswap.c to tools/perf/util/python-ext-sources, breaking 'perf test python'. Please run 'perf test' before sending pull requests :-) Fixed it this time. - Arnaldo