From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cyril Hrubis Date: Wed, 13 Dec 2017 17:12:00 +0100 Subject: [LTP] [RFC PATCH 3/3] build.sh: Allow to overwrite prefix In-Reply-To: <20171213144101.54egpm2q4nbb5asc@dell5510> References: <20171213131334.26863-1-pvorel@suse.cz> <20171213135943.GF11493@rei> <20171213144101.54egpm2q4nbb5asc@dell5510> Message-ID: <20171213161159.GB22116@rei> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ltp@lists.linux.it Hi! > Yes. It works well how it is, I just find it quite unusual not to use getopt(s). And > mixing parameters with and without '-' as I did is bad. > Whole point of these changes is to make the script usable also for local development > (sometimes one may want to run two builds, thats why it's good to allow overwrite prefix). > > Maybe I should have used getopts short option with values, even I don't like short values: > > ./build.sh [ -t 32|cross|out ] [ -p PREFIX_DIR ] [ -c CC ] This does not seem that bad to me. I would like to avoid passing half of the parameters via argv and half via env variables if possible. > I decided leave out-of-tree on it's own (native only). But it would be possible to have > e.g. out-of-tree 32-bit compilation, but I don't see much advantages for it. I think that as well, the out/in tree build is orthogonal problem to the compiler and it's unlikely that things would break. -- Cyril Hrubis chrubis@suse.cz