All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jens Axboe <axboe@fb.com>, linux-block@vger.kernel.org
Subject: Re: [PATCH 00/10] block: cleanup on direct access to bvec table(prepare for multipage bvec)
Date: Thu, 14 Dec 2017 01:55:07 +0800	[thread overview]
Message-ID: <20171213175506.GA17305@ming.t460p> (raw)
In-Reply-To: <20171212091844.GB8529@ming.t460p>

On Tue, Dec 12, 2017 at 05:18:44PM +0800, Ming Lei wrote:
> On Mon, Dec 11, 2017 at 11:57:38PM -0800, Christoph Hellwig wrote:
> > Most of this looks sane, but I'd really like to see it in context
> > of the actual multipage bvec patches.  Do you have an updated branch
> > on top of these?
> 
> I will post it out soon after addressing some of last comments.

You can find the actual multipage bvec patches in the following tree,
which is on top this prepare patchset.

	tree: https://github.com/ming1/linux.git #v4.15-rc-mp-bvec_v4-rc1
	gitweb: https://github.com/ming1/linux/commits/v4.15-rc-mp-bvec_v4-rc1

In this tree, all the current bio_for_each_segment* are converted to
bio_for_each_page*() first, then after multipage bvec is enabled, we
have the following helpers:

1) bio_for_each_segment()/bio_for_each_segment_all()
	
	iterate bio segment by segment which is real multipage bvec

2) bio_for_each_page()/bio_for_each_page_all()

	iterate bio page by page, which is the current in-tree bio_for_each_segment()/
	bio_for_each_segment_all()

3) rq_for_each_page()/rq_for_each_segment()
	similar with above


Not run full test yet, but it works on my VM, will start xfstest later.

Thanks,
Ming

  reply	other threads:[~2017-12-13 17:55 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-08 13:13 [PATCH 00/10] block: cleanup on direct access to bvec table(prepare for multipage bvec) Ming Lei
2017-12-08 13:14 ` [PATCH 01/10] block: introduce bio helpers for converting to multipage bvec Ming Lei
2017-12-08 13:14 ` [PATCH 02/10] block: conver to bio_first_bvec() & bio_first_page() Ming Lei
2017-12-08 13:14 ` [PATCH 03/10] fs: convert to bio_last_bvec() Ming Lei
2017-12-08 13:14 ` [PATCH 04/10] block: bounce: avoid direct access to bvec table Ming Lei
2017-12-08 13:14 ` [PATCH 05/10] block: bounce: don't access bio->bi_io_vec in copy_to_high_bio_irq Ming Lei
2017-12-08 13:14 ` [PATCH 06/10] dm: limit the max bio size as BIO_MAX_PAGES * PAGE_SIZE Ming Lei
2017-12-08 13:14 ` [PATCH 07/10] bcache: comment on direct access to bvec table Ming Lei
2017-12-08 13:14 ` [PATCH 08/10] block: move bio_alloc_pages() to bcache Ming Lei
2018-01-08 18:05   ` Michael Lyle
2018-01-09  1:21     ` Ming Lei
2017-12-08 13:14 ` [PATCH 09/10] btrfs: avoid access to .bi_vcnt directly Ming Lei
2017-12-08 13:14 ` [PATCH 10/10] btrfs: avoid to access bvec table directly for a cloned bio Ming Lei
2017-12-12  7:57 ` [PATCH 00/10] block: cleanup on direct access to bvec table(prepare for multipage bvec) Christoph Hellwig
2017-12-12  9:18   ` Ming Lei
2017-12-13 17:55     ` Ming Lei [this message]
2018-01-05 19:02 ` Jens Axboe
2018-01-06  9:18   ` Ming Lei
2018-01-06 16:21     ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171213175506.GA17305@ming.t460p \
    --to=ming.lei@redhat.com \
    --cc=axboe@fb.com \
    --cc=hch@infradead.org \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.