From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Date: Wed, 13 Dec 2017 18:19:56 +0000 Subject: Re: iw_cxgb4: make pointer reg_workq static Message-Id: <20171213181956.GD5984@ziepe.ca> List-Id: References: <20171130133006.19699-1-colin.king@canonical.com> In-Reply-To: <20171130133006.19699-1-colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin Ian King Cc: Steve Wise , Doug Ledford , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On Thu, Nov 30, 2017 at 01:30:06PM +0000, Colin Ian King wrote: > From: Colin Ian King > > The pointer reg_workq is local to the source and does not need to be > in global scope, so make it static. > > Cleans up sparse warning: > drivers/infiniband/hw/cxgb4/device.c:69:25: warning: symbol 'reg_workq' > was not declared. Should it be static? > > Signed-off-by: Colin Ian King > Reviewed-by: Leon Romanovsky > Reviewed-by: Steve Wise > drivers/infiniband/hw/cxgb4/device.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied to -next Jason From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: iw_cxgb4: make pointer reg_workq static Date: Wed, 13 Dec 2017 11:19:56 -0700 Message-ID: <20171213181956.GD5984@ziepe.ca> References: <20171130133006.19699-1-colin.king@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20171130133006.19699-1-colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Colin Ian King Cc: Steve Wise , Doug Ledford , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org On Thu, Nov 30, 2017 at 01:30:06PM +0000, Colin Ian King wrote: > From: Colin Ian King > > The pointer reg_workq is local to the source and does not need to be > in global scope, so make it static. > > Cleans up sparse warning: > drivers/infiniband/hw/cxgb4/device.c:69:25: warning: symbol 'reg_workq' > was not declared. Should it be static? > > Signed-off-by: Colin Ian King > Reviewed-by: Leon Romanovsky > Reviewed-by: Steve Wise > drivers/infiniband/hw/cxgb4/device.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied to -next Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753855AbdLMSUK (ORCPT ); Wed, 13 Dec 2017 13:20:10 -0500 Received: from mail-wr0-f194.google.com ([209.85.128.194]:43409 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753840AbdLMSUG (ORCPT ); Wed, 13 Dec 2017 13:20:06 -0500 X-Google-Smtp-Source: ACJfBougBWfTD8UXXVg/EjjdhEofUZDGyjaz/Wicl3aa7wbfJOgltNHDCJ3B59uHBnviv1285aIpZg== Date: Wed, 13 Dec 2017 11:19:56 -0700 From: Jason Gunthorpe To: Colin Ian King Cc: Steve Wise , Doug Ledford , linux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: iw_cxgb4: make pointer reg_workq static Message-ID: <20171213181956.GD5984@ziepe.ca> References: <20171130133006.19699-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171130133006.19699-1-colin.king@canonical.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 30, 2017 at 01:30:06PM +0000, Colin Ian King wrote: > From: Colin Ian King > > The pointer reg_workq is local to the source and does not need to be > in global scope, so make it static. > > Cleans up sparse warning: > drivers/infiniband/hw/cxgb4/device.c:69:25: warning: symbol 'reg_workq' > was not declared. Should it be static? > > Signed-off-by: Colin Ian King > Reviewed-by: Leon Romanovsky > Reviewed-by: Steve Wise > drivers/infiniband/hw/cxgb4/device.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied to -next Jason