From: Dave Chinner <david@fromorbit.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: eguan@redhat.com, linux-xfs@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH 8/8] xfs/068: fix variability problems in file/dir count output
Date: Thu, 14 Dec 2017 09:20:46 +1100 [thread overview]
Message-ID: <20171213222046.GA4094@dastard> (raw)
In-Reply-To: <151314505158.18893.11894289091110903029.stgit@magnolia>
On Tue, Dec 12, 2017 at 10:04:11PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> In this test we use fsstress to create some number of files and then
> exercise xfsdump/xfsrestore on them. Depending on the fsstress config
> we may end up with a different number of files than is hardcoded in the
> golden output (particularly after adding reflink support to fsstress)
> and thereby fail the test. Since we're not really testing how many
> files fsstress can create, just turn the counts into XXX/YYY.
Hmmmm. those numbers were in the golden output specifically because
fsstress is supposed to be deterministic for a given random seed.
What it is supposed to be testing is that xfsdump actually dumped
all the files that were created, and xfs-restore was able to process
them all. If either barf on a file, they'll silently skip it, and
the numbers won't come out properly.
The typical class of bug this test finds is bulkstat iteration
problems - if bulkstat misses an inode it shouldn't, then the
xfsrestore numbers come out wrong. By making the data set
non-deterministic and not checking the numbers, we end up losing the
ability of this test to check bulkstat iteration and dump/restore
completeness....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2017-12-13 22:20 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-13 6:03 [PATCH 0/8] weekly fstests changes Darrick J. Wong
2017-12-13 6:03 ` [PATCH 1/8] common/rc: report kmemleak errors Darrick J. Wong
2017-12-14 9:37 ` Eryu Guan
2017-12-14 18:15 ` Darrick J. Wong
2018-01-05 8:02 ` Eryu Guan
2018-01-05 17:02 ` Darrick J. Wong
2018-01-07 15:25 ` Eryu Guan
2017-12-13 6:03 ` [PATCH 2/8] common/xfs: fix scrub support probing again Darrick J. Wong
2017-12-13 6:03 ` [PATCH 3/8] generic/45[34]: test line draw characters in file/attr names Darrick J. Wong
2017-12-13 6:03 ` [PATCH 4/8] xfs: fix tests to handle removal of no-alloc create nonfeature Darrick J. Wong
2017-12-13 22:12 ` Dave Chinner
2017-12-13 22:45 ` [PATCH v2 " Darrick J. Wong
2017-12-13 6:03 ` [PATCH 5/8] generic: test error shutdown while stressing filesystem Darrick J. Wong
2017-12-13 6:03 ` [PATCH 6/8] fsstress: implement the clonerange/deduperange ioctls Darrick J. Wong
2017-12-14 6:39 ` Amir Goldstein
2017-12-14 7:32 ` Eryu Guan
2017-12-14 20:20 ` Darrick J. Wong
2017-12-15 2:07 ` [PATCH v2 " Darrick J. Wong
2018-01-03 8:48 ` Eryu Guan
2018-01-03 17:12 ` Darrick J. Wong
2018-01-05 4:35 ` Eryu Guan
2018-01-05 4:54 ` Darrick J. Wong
2018-01-06 1:46 ` Darrick J. Wong
2018-01-09 7:09 ` Darrick J. Wong
2018-02-22 16:06 ` Luis Henriques
2018-02-22 17:27 ` Darrick J. Wong
2018-02-22 18:17 ` Luis Henriques
2018-02-22 18:34 ` Darrick J. Wong
2018-02-23 10:17 ` Luis Henriques
2017-12-13 6:04 ` [PATCH 7/8] generic: run a long-soak write-only fsstress test Darrick J. Wong
2018-01-07 15:34 ` Eryu Guan
2017-12-13 6:04 ` [PATCH 8/8] xfs/068: fix variability problems in file/dir count output Darrick J. Wong
2017-12-13 22:20 ` Dave Chinner [this message]
2017-12-13 22:23 ` Darrick J. Wong
2017-12-13 22:45 ` Dave Chinner
2017-12-13 23:17 ` Darrick J. Wong
2017-12-13 23:42 ` Dave Chinner
2017-12-13 23:28 ` [PATCH v2 8/8] xfs/068: fix clonerange " Darrick J. Wong
2017-12-13 23:44 ` Dave Chinner
2017-12-14 6:52 ` Amir Goldstein
2017-12-14 7:37 ` Amir Goldstein
2017-12-14 7:49 ` Eryu Guan
2017-12-14 8:15 ` Amir Goldstein
2017-12-14 21:35 ` Dave Chinner
2017-12-15 2:04 ` Darrick J. Wong
2017-12-15 4:37 ` Dave Chinner
2017-12-15 7:06 ` Amir Goldstein
2017-12-15 2:08 ` [PATCH v3 8/8] xfs/068: fix variability " Darrick J. Wong
2017-12-15 2:16 ` Darrick J. Wong
2017-12-15 2:17 ` [PATCH v4 " Darrick J. Wong
2017-12-15 8:55 ` [PATCH 0/8] weekly fstests changes Eryu Guan
2018-01-03 19:22 ` [PATCH 9/8] xfs: find libxfs api violations Darrick J. Wong
2018-01-03 19:26 ` [PATCH 10/8] xfs: check that fs freeze minimizes required recovery Darrick J. Wong
2018-01-09 11:33 ` Eryu Guan
2018-01-10 0:03 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171213222046.GA4094@dastard \
--to=david@fromorbit.com \
--cc=darrick.wong@oracle.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.