diff for duplicates of <20171214100927.GA26167@localhost.didichuxing.com> diff --git a/a/1.txt b/N1/1.txt index e4a10a8..4b91384 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -15,86 +15,3 @@ Hi, It seems something wrong with bdi debugfs register, could you help test the forllowing debug patch, I add some debug log, no function change, thanks. - - ->From d2728c07589e8b83115a51e0c629451bff7308db Mon Sep 17 00:00:00 2001 -From: weiping zhang <zhangweiping@didichuxing.com> -Date: Thu, 14 Dec 2017 17:56:22 +0800 -Subject: [PATCH] bdi debugfs - -Signed-off-by: weiping zhang <zhangweiping@didichuxing.com> ---- - mm/backing-dev.c | 28 +++++++++++++++++++++++++--- - 1 file changed, 25 insertions(+), 3 deletions(-) - -diff --git a/mm/backing-dev.c b/mm/backing-dev.c -index 84b2dc7..fbbb9a6 100644 ---- a/mm/backing-dev.c -+++ b/mm/backing-dev.c -@@ -39,6 +39,10 @@ static struct dentry *bdi_debug_root; - static void bdi_debug_init(void) - { - bdi_debug_root = debugfs_create_dir("bdi", NULL); -+ if (!bdi_debug_root) -+ pr_err("DEBUG:bdi_debug_root fail\n"); -+ else -+ pr_err("DEBUG:bdi_debug_root success\n"); - } - - static int bdi_debug_stats_show(struct seq_file *m, void *v) -@@ -115,18 +119,29 @@ static const struct file_operations bdi_debug_stats_fops = { - - static int bdi_debug_register(struct backing_dev_info *bdi, const char *name) - { -- if (!bdi_debug_root) -+ if (!bdi_debug_root) { -+ pr_err("DEBUG:dev:%s, bdi_debug_root fail\n", name); - return -ENOMEM; -+ } else { -+ pr_err("DEBUG:dev:%s, bdi_debug_root success\n", name); -+ } - - bdi->debug_dir = debugfs_create_dir(name, bdi_debug_root); -- if (!bdi->debug_dir) -+ if (!bdi->debug_dir) { -+ pr_err("DEBUG:dev:%s, debug_dir fail\n", name); - return -ENOMEM; -+ } else { -+ pr_err("DEBUG:dev:%s, debug_dir success\n", name); -+ } - - bdi->debug_stats = debugfs_create_file("stats", 0444, bdi->debug_dir, - bdi, &bdi_debug_stats_fops); - if (!bdi->debug_stats) { - debugfs_remove(bdi->debug_dir); -+ pr_err("DEBUG:dev:%s, debug_stats fail\n", name); - return -ENOMEM; -+ } else { -+ pr_err("DEBUG:dev:%s, debug_stats success\n", name); - } - - return 0; -@@ -879,13 +894,20 @@ int bdi_register_va(struct backing_dev_info *bdi, const char *fmt, va_list args) - return 0; - - dev = device_create_vargs(bdi_class, NULL, MKDEV(0, 0), bdi, fmt, args); -- if (IS_ERR(dev)) -+ if (IS_ERR(dev)) { -+ pr_err("DEBUG: bdi device_create_vargs fail\n"); - return PTR_ERR(dev); -+ } -+ pr_err("DEBUG: bdi(0x%p) device_create_vargs sucess\n", bdi); - - if (bdi_debug_register(bdi, dev_name(dev))) { -+ pr_err("DEBUG: dev:%s, bdi(0x%p) bdi_debug_register fail\n", -+ dev_name(dev), bdi); - device_destroy(bdi_class, dev->devt); - return -ENOMEM; - } -+ pr_err("DEBUG: dev:%s, bdi(0x%p) bdi_debug_register success\n", -+ dev_name(dev), bdi); - cgwb_bdi_register(bdi); - bdi->dev = dev; - --- -2.9.4 diff --git a/a/content_digest b/N1/content_digest index aa7385f..6aead6c 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -7,10 +7,10 @@ "Cc\0Laura Abbott <labbott@redhat.com>" Jan Kara <jack@suse.cz> Jens Axboe <axboe@kernel.dk> - <linux-mm@kvack.org> + linux-mm@kvack.org Linux Kernel Mailing List <linux-kernel@vger.kernel.org> - <regressions@leemhuis.info> - " <linux-block@vger.kernel.org>\0" + regressions@leemhuis.info + " linux-block@vger.kernel.org\0" "\00:1\0" "b\0" "On Thu, Dec 14, 2017 at 02:24:52AM -0600, Bruno Wolff III wrote:\n" @@ -29,89 +29,6 @@ "\n" "It seems something wrong with bdi debugfs register, could you help\n" "test the forllowing debug patch, I add some debug log, no function\n" - "change, thanks.\n" - "\n" - "\n" - ">From d2728c07589e8b83115a51e0c629451bff7308db Mon Sep 17 00:00:00 2001\n" - "From: weiping zhang <zhangweiping@didichuxing.com>\n" - "Date: Thu, 14 Dec 2017 17:56:22 +0800\n" - "Subject: [PATCH] bdi debugfs\n" - "\n" - "Signed-off-by: weiping zhang <zhangweiping@didichuxing.com>\n" - "---\n" - " mm/backing-dev.c | 28 +++++++++++++++++++++++++---\n" - " 1 file changed, 25 insertions(+), 3 deletions(-)\n" - "\n" - "diff --git a/mm/backing-dev.c b/mm/backing-dev.c\n" - "index 84b2dc7..fbbb9a6 100644\n" - "--- a/mm/backing-dev.c\n" - "+++ b/mm/backing-dev.c\n" - "@@ -39,6 +39,10 @@ static struct dentry *bdi_debug_root;\n" - " static void bdi_debug_init(void)\n" - " {\n" - " \tbdi_debug_root = debugfs_create_dir(\"bdi\", NULL);\n" - "+\tif (!bdi_debug_root)\n" - "+\t\tpr_err(\"DEBUG:bdi_debug_root fail\\n\");\n" - "+\telse\n" - "+\t\tpr_err(\"DEBUG:bdi_debug_root success\\n\");\n" - " }\n" - " \n" - " static int bdi_debug_stats_show(struct seq_file *m, void *v)\n" - "@@ -115,18 +119,29 @@ static const struct file_operations bdi_debug_stats_fops = {\n" - " \n" - " static int bdi_debug_register(struct backing_dev_info *bdi, const char *name)\n" - " {\n" - "-\tif (!bdi_debug_root)\n" - "+\tif (!bdi_debug_root) {\n" - "+\t\tpr_err(\"DEBUG:dev:%s, bdi_debug_root fail\\n\", name);\n" - " \t\treturn -ENOMEM;\n" - "+\t} else {\n" - "+\t\tpr_err(\"DEBUG:dev:%s, bdi_debug_root success\\n\", name);\n" - "+\t}\n" - " \n" - " \tbdi->debug_dir = debugfs_create_dir(name, bdi_debug_root);\n" - "-\tif (!bdi->debug_dir)\n" - "+\tif (!bdi->debug_dir) {\n" - "+\t\tpr_err(\"DEBUG:dev:%s, debug_dir fail\\n\", name);\n" - " \t\treturn -ENOMEM;\n" - "+\t} else {\n" - "+\t\tpr_err(\"DEBUG:dev:%s, debug_dir success\\n\", name);\n" - "+\t}\n" - " \n" - " \tbdi->debug_stats = debugfs_create_file(\"stats\", 0444, bdi->debug_dir,\n" - " \t\t\t\t\t bdi, &bdi_debug_stats_fops);\n" - " \tif (!bdi->debug_stats) {\n" - " \t\tdebugfs_remove(bdi->debug_dir);\n" - "+\t\tpr_err(\"DEBUG:dev:%s, debug_stats fail\\n\", name);\n" - " \t\treturn -ENOMEM;\n" - "+\t} else {\n" - "+\t\tpr_err(\"DEBUG:dev:%s, debug_stats success\\n\", name);\n" - " \t}\n" - " \n" - " \treturn 0;\n" - "@@ -879,13 +894,20 @@ int bdi_register_va(struct backing_dev_info *bdi, const char *fmt, va_list args)\n" - " \t\treturn 0;\n" - " \n" - " \tdev = device_create_vargs(bdi_class, NULL, MKDEV(0, 0), bdi, fmt, args);\n" - "-\tif (IS_ERR(dev))\n" - "+\tif (IS_ERR(dev)) {\n" - "+\t\tpr_err(\"DEBUG: bdi device_create_vargs fail\\n\");\n" - " \t\treturn PTR_ERR(dev);\n" - "+\t}\n" - "+\tpr_err(\"DEBUG: bdi(0x%p) device_create_vargs sucess\\n\", bdi);\n" - " \n" - " \tif (bdi_debug_register(bdi, dev_name(dev))) {\n" - "+\t\tpr_err(\"DEBUG: dev:%s, bdi(0x%p) bdi_debug_register fail\\n\",\n" - "+\t\t\tdev_name(dev), bdi);\n" - " \t\tdevice_destroy(bdi_class, dev->devt);\n" - " \t\treturn -ENOMEM;\n" - " \t}\n" - "+\tpr_err(\"DEBUG: dev:%s, bdi(0x%p) bdi_debug_register success\\n\",\n" - "+\t\tdev_name(dev), bdi);\n" - " \tcgwb_bdi_register(bdi);\n" - " \tbdi->dev = dev;\n" - " \n" - "-- \n" - 2.9.4 + change, thanks. -ecce260ab1fb757205c139155072bb10a6633048d7d634da41995790d574a481 +8bad2ed65d7801ab0405e5caf212d2af7d2a35966751635859387d6200f766be
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.