From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753382AbdLNP2a (ORCPT ); Thu, 14 Dec 2017 10:28:30 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43348 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752687AbdLNP21 (ORCPT ); Thu, 14 Dec 2017 10:28:27 -0500 Date: Thu, 14 Dec 2017 16:28:15 +0100 From: Jiri Olsa To: Mathieu Poirier Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org, alexander.shishkin@linux.intel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] perf report: Fix regression when decoding intelPT traces Message-ID: <20171214152815.GA3987@krava> References: <1513213074-25173-1-git-send-email-mathieu.poirier@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1513213074-25173-1-git-send-email-mathieu.poirier@linaro.org> User-Agent: Mutt/1.9.1 (2017-09-22) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Thu, 14 Dec 2017 15:28:27 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 13, 2017 at 05:57:54PM -0700, Mathieu Poirier wrote: > Commit (93d10af26bb7 perf tools: Optimize sample parsing for ordered > events) breaks intelPT trace decoding by invariably returning an error if > the event type isn't a PERF_SAMPLE_TIME. right, thanks for catchng that > > With this patch the timestamp is initialised and processing is allowed to > continue even if an error is returned by function > perf_evlist__parse_sample_timestamp(). > > Signed-off-by: Mathieu Poirier > --- > tools/perf/util/session.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c > index 54e30f1bcbd7..20cdcf14232b 100644 > --- a/tools/perf/util/session.c > +++ b/tools/perf/util/session.c > @@ -1512,7 +1512,7 @@ static s64 perf_session__process_event(struct perf_session *session, > > ret = perf_evlist__parse_sample_timestamp(evlist, event, ×tamp); > if (ret) > - return ret; > + timestamp = -1ULL; we still have some -EFAULT error codes in there that we want to catch.. should it be more like in below? thanks, jirka --- diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c index 54e30f1bcbd7..9498aa0efe39 100644 --- a/tools/perf/util/session.c +++ b/tools/perf/util/session.c @@ -1508,10 +1508,10 @@ static s64 perf_session__process_event(struct perf_session *session, return perf_session__process_user_event(session, event, file_offset); if (tool->ordered_events) { - u64 timestamp; + u64 timestamp = -1ULL ret = perf_evlist__parse_sample_timestamp(evlist, event, ×tamp); - if (ret) + if (ret != -1) return ret; ret = perf_session__queue_event(session, event, timestamp, file_offset);