From: "Michael S. Tsirkin" <mst@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>,
qemu-devel@nongnu.org, pbonzini@redhat.com,
maxime.coquelin@redhat.com, groug@kaod.org
Subject: Re: [Qemu-devel] [PATCH v4 4/6] vhost: add regions to temporary list
Date: Thu, 14 Dec 2017 20:43:41 +0200 [thread overview]
Message-ID: <20171214204310-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20171214162731.50a95633@redhat.com>
On Thu, Dec 14, 2017 at 04:27:31PM +0100, Igor Mammedov wrote:
> Also it seems that we have a race in current code where
> region_del() unrefs memory region first and then by the
> commit time memory region could be gone since old flatview
> is unreffed before commit callback is called, but guest still
> uses old memory map until vhost_set_mem_table() is complete.
> We probably should unref deleted(old) sections after
> guest gets new memmap.
Care trying to post a patch for stable? Might be a good idea
to merge before this rework, for the sake of downstreams.
>
> > }
> >
> > static int vhost_virtqueue_set_addr(struct vhost_dev *dev,
next prev parent reply other threads:[~2017-12-14 18:43 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-13 18:08 [Qemu-devel] [PATCH v4 0/6] Rework vhost memory region updates Dr. David Alan Gilbert (git)
2017-12-13 18:08 ` [Qemu-devel] [PATCH v4 1/6] vhost: Move log_dirty check Dr. David Alan Gilbert (git)
2017-12-14 14:30 ` Igor Mammedov
2017-12-14 15:20 ` Dr. David Alan Gilbert
2017-12-15 10:01 ` Igor Mammedov
2017-12-27 12:10 ` Igor Mammedov
2018-01-09 18:42 ` Dr. David Alan Gilbert
2017-12-13 18:08 ` [Qemu-devel] [PATCH v4 2/6] vhost: Simplify ring verification checks Dr. David Alan Gilbert (git)
2017-12-14 14:07 ` Igor Mammedov
2017-12-15 12:24 ` Dr. David Alan Gilbert
2017-12-13 18:08 ` [Qemu-devel] [PATCH v4 3/6] vhost: Add temporary memory structure Dr. David Alan Gilbert (git)
2017-12-14 15:15 ` Igor Mammedov
2017-12-15 13:15 ` Dr. David Alan Gilbert
2017-12-13 18:08 ` [Qemu-devel] [PATCH v4 4/6] vhost: add regions to temporary list Dr. David Alan Gilbert (git)
2017-12-13 21:31 ` Paolo Bonzini
2017-12-14 15:53 ` Dr. David Alan Gilbert
2017-12-14 15:27 ` Igor Mammedov
2017-12-14 18:43 ` Michael S. Tsirkin [this message]
2017-12-18 20:29 ` Dr. David Alan Gilbert
2017-12-15 13:30 ` Dr. David Alan Gilbert
2017-12-15 14:50 ` Paolo Bonzini
2017-12-15 16:11 ` Dr. David Alan Gilbert
2017-12-13 18:08 ` [Qemu-devel] [PATCH v4 5/6] vhost: compare and flip in new memory region list Dr. David Alan Gilbert (git)
2017-12-13 18:08 ` [Qemu-devel] [PATCH v4 6/6] vhost: Clean out old vhost_set_memory and friends Dr. David Alan Gilbert (git)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171214204310-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=dgilbert@redhat.com \
--cc=groug@kaod.org \
--cc=imammedo@redhat.com \
--cc=maxime.coquelin@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.