From: Stephen Hemminger <stephen@networkplumber.org>
To: Chris Mi <chrism@mellanox.com>
Cc: netdev@vger.kernel.org, jiri@resnulli.us
Subject: Re: [patch iproute2] tc: fix command "tc actions del" hang issue
Date: Thu, 14 Dec 2017 21:16:58 -0800 [thread overview]
Message-ID: <20171214211658.40eb8290@xeon-e3> (raw)
In-Reply-To: <20171214090900.14336-1-chrism@mellanox.com>
On Thu, 14 Dec 2017 18:09:00 +0900
Chris Mi <chrism@mellanox.com> wrote:
> If command is RTM_DELACTION, a non-NULL pointer is passed to rtnl_talk().
> Then flag NLM_F_ACK is not set on n->nlmsg_flags and netlink_ack() will
> not be called. Command tc will wait for the reply for ever.
>
> Fixes: 86bf43c7c2fd ("lib/libnetlink: update rtnl_talk to support malloc
> buff at run time")
> Signed-off-by: Chris Mi <chrism@mellanox.com>
> Reviewed-by: Jiri Pirko <jiri@mellanox.com>
Thanks for fixing this.
Applied, but please don't linewrap the fixes tag.
next prev parent reply other threads:[~2017-12-15 5:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-14 9:09 [patch iproute2] tc: fix command "tc actions del" hang issue Chris Mi
2017-12-15 5:16 ` Stephen Hemminger [this message]
2017-12-18 1:41 ` Chris Mi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171214211658.40eb8290@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=chrism@mellanox.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.