From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:58786 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752587AbdLNV3X (ORCPT ); Thu, 14 Dec 2017 16:29:23 -0500 Date: Thu, 14 Dec 2017 22:29:25 +0100 From: Greg KH To: Christoffer Dall Cc: Stable , Marc Zyngier Subject: Re: [PATCH v4.14 backport] KVM: arm/arm64: vgic-its: Preserve the revious read from the pending table Message-ID: <20171214212925.GD27981@kroah.com> References: <20171212164232.2908-1-christoffer.dall@linaro.org> <20171214204027.GC32443@kroah.com> <20171214204831.GA32502@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: stable-owner@vger.kernel.org List-ID: On Thu, Dec 14, 2017 at 09:57:54PM +0100, Christoffer Dall wrote: > On Thu, Dec 14, 2017 at 9:48 PM, Greg KH wrote: > > On Thu, Dec 14, 2017 at 09:40:27PM +0100, Greg KH wrote: > >> On Tue, Dec 12, 2017 at 05:42:31PM +0100, Christoffer Dall wrote: > >> > From: Marc Zyngier > >> > > >> > Commit 64afe6e9eb4841f35317da4393de21a047a883b3 upstream. > >> > > >> > The current pending table parsing code assumes that we keep the > >> > previous read of the pending bits, but keep that variable in > >> > the current block, making sure it is discarded on each loop. > >> > > >> > We end-up using whatever is on the stack. Who knows, it might > >> > just be the right thing... > >> > > >> > Fixes: 33d3bc9556a7d ("KVM: arm64: vgic-its: Read initial LPI pending table") > >> > Cc: # 4.8 > >> > Reported-by: AKASHI Takahiro > >> > Reviewed-by: Christoffer Dall > >> > Signed-off-by: Marc Zyngier > >> > Signed-off-by: Christoffer Dall > >> > --- > >> > virt/kvm/arm/vgic/vgic-its.c | 2 +- > >> > 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> All 4 backports queued up, many thanks for them. > > > > Hm, no, I messed up. I'm totally confused by the emails you sent and > > the "drop this" and "this is real" :) > > > > Yeah, I had a bad day. Sorry about the confusion. > > > Can you resend just the patches you want applied? > > > > Yes, all four incoming now. Thanks, I should have this all now queued up properly, thanks for the resend. greg k-h