From: Johan Hovold <johan@kernel.org>
To: Reinhard Speyerer <rspmn@arcor.de>
Cc: johan@kernel.org, linux-usb@vger.kernel.org,
"Sebastian Sjoholm" <sebastian.sjoholm@gmail.com>,
"Bjørn Mork" <bjorn@mork.no>
Subject: [v2] USB: serial: qcserial: add Sierra Wireless EM7565
Date: Fri, 15 Dec 2017 09:45:05 +0100 [thread overview]
Message-ID: <20171215084505.GE3831@localhost> (raw)
On Fri, Dec 15, 2017 at 12:39:27AM +0100, Reinhard Speyerer wrote:
> Sierra Wireless EM7565 devices use the QCSERIAL_SWI layout for their
> serial ports
>
> T: Bus=01 Lev=03 Prnt=29 Port=01 Cnt=02 Dev#= 31 Spd=480 MxCh= 0
> D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1
> P: Vendor=1199 ProdID=9091 Rev= 0.06
> S: Manufacturer=Sierra Wireless, Incorporated
> S: Product=Sierra Wireless EM7565 Qualcomm Snapdragon X16 LTE-A
> S: SerialNumber=xxxxxxxx
> C:* #Ifs= 4 Cfg#= 1 Atr=a0 MxPwr=500mA
> I:* If#= 0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=qcserial
> E: Ad=81(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> E: Ad=01(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> I:* If#= 2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=qcserial
> E: Ad=83(I) Atr=03(Int.) MxPS= 10 Ivl=32ms
> E: Ad=82(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> E: Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> I:* If#= 3 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=qcserial
> E: Ad=85(I) Atr=03(Int.) MxPS= 10 Ivl=32ms
> E: Ad=84(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> E: Ad=03(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> I:* If#= 8 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=qmi_wwan
> E: Ad=86(I) Atr=03(Int.) MxPS= 8 Ivl=32ms
> E: Ad=8e(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> E: Ad=0f(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
>
> but need sendsetup = true for the NMEA port to make it work properly.
>
> Simplify the patch compared to v1 as suggested by Bjørn Mork by taking
> advantage of the fact that existing devices work with sendsetup = true
> too.
>
> Use sendsetup = true for the NMEA interface of QCSERIAL_SWI and add
> DEVICE_SWI entries for the EM7565 PID 0x9091 and the EM7565 QDL PID
> 0x9090.
>
> Tests with several MC73xx/MC74xx/MC77xx devices have been performed in
> order to verify backward compatibility.
>
> Signed-off-by: Reinhard Speyerer <rspmn@arcor.de>
> ---
> v2: Simplify the patch as suggested by Bjørn Mork by using
> sendsetup = true for the NMEA port of the QCSERIAL_SWI layout.
That seems like the right thing to do here. Now applied.
Thanks,
Johan
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2017-12-15 8:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-15 8:45 Johan Hovold [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-12-14 23:39 [v2] USB: serial: qcserial: add Sierra Wireless EM7565 Reinhard Speyerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171215084505.GE3831@localhost \
--to=johan@kernel.org \
--cc=bjorn@mork.no \
--cc=linux-usb@vger.kernel.org \
--cc=rspmn@arcor.de \
--cc=sebastian.sjoholm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.