From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH net-next] net: phy: broadcom: Add entry for 5395 switch
 PHYs
Date: Fri, 15 Dec 2017 10:10:44 +0100
Message-ID: <20171215091044.GE929@lunn.ch>
References: <1513302496-22888-1-git-send-email-f.fainelli@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: netdev@vger.kernel.org, cphealy@gmail.com
To: Florian Fainelli <f.fainelli@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from vps0.lunn.ch ([185.16.172.187]:33719 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1754515AbdLOJKp (ORCPT <rfc822;netdev@vger.kernel.org>);
        Fri, 15 Dec 2017 04:10:45 -0500
Content-Disposition: inline
In-Reply-To: <1513302496-22888-1-git-send-email-f.fainelli@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Thu, Dec 14, 2017 at 05:48:16PM -0800, Florian Fainelli wrote:
> Add an entry for the builtin PHYs present in the Broadcom BCM5395 switch. This
> allows us to retrieve the PHY statistics among other things.

>  static struct phy_driver broadcom_drivers[] = {
>  {
>  	.phy_id		= PHY_ID_BCM5411,
> @@ -679,6 +710,16 @@ static struct phy_driver broadcom_drivers[] = {
>  	.config_init	= brcm_fet_config_init,
>  	.ack_interrupt	= brcm_fet_ack_interrupt,
>  	.config_intr	= brcm_fet_config_intr,
> +}, {
> +	.phy_id		= PHY_ID_BCM5395,
> +	.phy_id_mask	= 0xfffffff0,
> +	.name		= "Broadcom BCM5395",
> +	.flags		= PHY_IS_INTERNAL,
> +	.features	= PHY_GBIT_FEATURES,
> +	.get_sset_count	= bcm_phy_get_sset_count,
> +	.get_strings	= bcm_phy_get_strings,
> +	.get_stats	= bcm53xx_phy_get_stats,
> +	.probe		= bcm53xx_phy_probe,
>  } };

Hi Florian

Is this the only PHY supported by this driver which has statistics?

   Andrew