All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: "Richard Schütz" <rschuetz@uni-koblenz.de>
Cc: stable@vger.kernel.org, Ilan peer <ilan.peer@intel.com>,
	Johannes Berg <johannes.berg@intel.com>
Subject: Re: [PATCH] mac80211: Fix addition of mesh configuration element
Date: Fri, 15 Dec 2017 10:49:56 +0100	[thread overview]
Message-ID: <20171215094956.GA12127@kroah.com> (raw)
In-Reply-To: <20171215092929.3569-1-rschuetz@uni-koblenz.de>

On Fri, Dec 15, 2017 at 10:29:29AM +0100, Richard Sch�tz wrote:
> From: Ilan peer <ilan.peer@intel.com>
> 
> commit 57629915d568c522ac1422df7bba4bee5b5c7a7c upstream.
> 
> The code was setting the capabilities byte to zero,
> after it was already properly set previously. Fix it.
> 
> The bug was found while debugging hwsim mesh tests failures
> that happened since the commit mentioned below.
> 
> Fixes: 76f43b4c0a93 ("mac80211: Remove invalid flag operations in mesh TSF synchronization")
> Signed-off-by: Ilan Peer <ilan.peer@intel.com>
> Reviewed-by: Masashi Honma <masashi.honma@gmail.com>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> Signed-off-by: Richard Sch�tz <rschuetz@uni-koblenz.de>
> ---
>  net/mac80211/mesh.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/net/mac80211/mesh.c b/net/mac80211/mesh.c
> index cc2a63bd233f..9c23172feba0 100644
> --- a/net/mac80211/mesh.c
> +++ b/net/mac80211/mesh.c
> @@ -279,8 +279,6 @@ int mesh_add_meshconf_ie(struct ieee80211_sub_if_data *sdata,
>  	/* Mesh PS mode. See IEEE802.11-2012 8.4.2.100.8 */
>  	*pos |= ifmsh->ps_peers_deep_sleep ?
>  			IEEE80211_MESHCONF_CAPAB_POWER_SAVE_LEVEL : 0x00;
> -	*pos++ = 0x00;
> -
>  	return 0;
>  }
>  
> -- 
> 2.15.1


I'm sorry, I don't understand what you want done with this patch.  Why
send it to stable@?

confused,

greg k-h

  reply	other threads:[~2017-12-15  9:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-15  9:29 [PATCH] mac80211: Fix addition of mesh configuration element Richard Schütz
2017-12-15  9:49 ` Greg KH [this message]
2017-12-15 10:31   ` Richard Schütz
2017-12-18 12:10     ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2016-12-26 16:17 Ilan Peer
2016-12-26 21:49 ` Masashi Honma
2017-01-02 10:59 ` Johannes Berg
2017-01-02 11:28   ` Peer, Ilan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171215094956.GA12127@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=ilan.peer@intel.com \
    --cc=johannes.berg@intel.com \
    --cc=rschuetz@uni-koblenz.de \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.