From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cornelia Huck Subject: Re: [PATCH v2 1/3] virtio_pci: use put_device instead of kfree Date: Fri, 15 Dec 2017 13:32:56 +0100 Message-ID: <20171215133256.4262ac9d.cohuck@redhat.com> References: <20171214205538-mutt-send-email-mst@kernel.org> <20171215034700-mutt-send-email-mst@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20171215034700-mutt-send-email-mst@kernel.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: "Michael S. Tsirkin" Cc: Greg Kroah-Hartman , weiping zhang , virtualization@lists.linux-foundation.org List-Id: virtualization@lists.linuxfoundation.org On Fri, 15 Dec 2017 03:48:09 +0200 "Michael S. Tsirkin" wrote: > Also just to make sure, none of this is a regression and none > of this causes actual known issues right? > > I think it's preferrable to defer to next merge cycle unless this > is a regression. I noticed this while looking at the cleanup path for regsiter_virtio_device(), I don't think any actual problems have been seen in the wild (just a latent bug). Deferring to the next merge window seems reasonable.