Re: [Qemu-devel] Key code conflict in keycodemapdb

["Daniel P. Berrange" <berrange@redhat.com>]

On Fri, Dec 15, 2017 at 03:51:19PM +0200, Miika S wrote:
> Hi
> 
> I tried to add JIS keyboard support to virtio-input-hid but ran
> into a problem with keys that have the "Linux Name" KEY_ISO and
> KEY_KATAKANAHIRAGANA. The problem appears to be that they have
> the same "AT set1 keycode" 0x70. I worked around it by removing
> KEY_ISO from keycodemapdb and got the keys working, but that
> doesn't work for the rest of QEMU. Is it intended that the keys
> have the same "AT set1 keycode"?

It is probably a misake


> @@ -246,7 +246,6 @@
> KEY_STOPCD,166,,,0xe024,0xe03b,0x98,233,VK_MEDIA_STOP,0xb2,,,,,MediaStop,I174,au
>  KEY_RECORD,167,,,0xe031,,0x9e,,,,,,,,,I175,,,
>  KEY_REWIND,168,,,0xe018,,0x9f,,,,,,,,,I176,,,
>  KEY_PHONE,169,,,0x63,,,,,,,,,,,I177,,,
> -KEY_ISO,170,ISO_Section,0xa,0x70,,,,,,,,,,,I178,,,

Instead of deleteing this line entirely, the right fix is probably to just
blank out the 0x70 value here.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|