All of lore.kernel.org
 help / color / mirror / Atom feed
From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH 1/2] nvme-cli: update Firmware Activate command for new feature
Date: Fri, 15 Dec 2017 11:23:33 -0700	[thread overview]
Message-ID: <20171215182333.GG26752@localhost.localdomain> (raw)
In-Reply-To: <1513360971-15566-2-git-send-email-minwoo.im.dev@gmail.com>

On Sat, Dec 16, 2017@03:02:50AM +0900, Minwoo Im wrote:
> Firmware Activate command were known as "Firmware Activate" in NVMe 1.0 and 1.1.
> It has been changed to Firmware Commit since 1.2.
> Also NVMe 1.3 spec introduced boot partition feature to Firmware Commit
> command.
> 
> Update Firmware Activate command name and add a few new feature of boot
> partition.

Hm, I can't really accept this. The tool existed when the command was
still called firmware activate in the spec. There are scripts in people's
environments that automate firmware updates, and we can't just break them
by changing a command name.

What I would accept is an alias command so we can deprecate/hide the
old command name. I've wanted to add infrastructure for creating aliased
commands, but I've not had time to get around to it.

  reply	other threads:[~2017-12-15 18:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-15 18:02 [PATCH 0/2] nvme-cli: update Firmware Activate command Minwoo Im
2017-12-15 18:02 ` [PATCH 1/2] nvme-cli: update Firmware Activate command for new feature Minwoo Im
2017-12-15 18:23   ` Keith Busch [this message]
2017-12-17  3:02     ` Minwoo Im
2017-12-15 18:02 ` [PATCH 2/2] nvme-cli: add a status code of Firmware Commit command Minwoo Im

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171215182333.GG26752@localhost.localdomain \
    --to=keith.busch@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.