From: "Hervé Poussineau" <hpoussin@reactos.org>
To: Aurelien Jarno <aurelien@aurel32.net>,
Yongbok Kim <yongbok.kim@mips.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org
Cc: "Hervé Poussineau" <hpoussin@reactos.org>
Subject: [Qemu-devel] [PATCH v2 05/15] piix4: rename some variables in realize function
Date: Sat, 16 Dec 2017 22:29:54 +0100 [thread overview]
Message-ID: <20171216213004.30393-6-hpoussin@reactos.org> (raw)
In-Reply-To: <20171216213004.30393-1-hpoussin@reactos.org>
PIIX4 structure is now 's'
PCI device is now 'pci'
DeviceState is now 'dev'
Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
---
hw/isa/piix4.c | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/hw/isa/piix4.c b/hw/isa/piix4.c
index 6b8bc3faf0..4f476dc7e6 100644
--- a/hw/isa/piix4.c
+++ b/hw/isa/piix4.c
@@ -87,16 +87,17 @@ static const VMStateDescription vmstate_piix4 = {
}
};
-static void piix4_realize(PCIDevice *dev, Error **errp)
+static void piix4_realize(PCIDevice *pci, Error **errp)
{
- PIIX4State *d = PIIX4_PCI_DEVICE(dev);
+ DeviceState *dev = DEVICE(pci);
+ PIIX4State *s = DO_UPCAST(PIIX4State, dev, pci);
- if (!isa_bus_new(DEVICE(d), pci_address_space(dev),
- pci_address_space_io(dev), errp)) {
+ if (!isa_bus_new(dev, pci_address_space(pci),
+ pci_address_space_io(pci), errp)) {
return;
}
- piix4_dev = &d->dev;
- qemu_register_reset(piix4_reset, d);
+ piix4_dev = pci;
+ qemu_register_reset(piix4_reset, s);
}
int piix4_init(PCIBus *bus, ISABus **isa_bus, int devfn)
--
2.11.0
next prev parent reply other threads:[~2017-12-16 21:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-16 21:29 [Qemu-devel] [PATCH 00/15] piix4: cleanup and improvements Hervé Poussineau
2017-12-16 21:29 ` [Qemu-devel] [PATCH v2 01/15] fdc: move object structures to header file Hervé Poussineau
2017-12-16 21:29 ` [Qemu-devel] [PATCH v2 02/15] serial/parallel: " Hervé Poussineau
2017-12-16 21:29 ` [Qemu-devel] [PATCH v2 03/15] mc146818rtc: move structure " Hervé Poussineau
2017-12-16 21:29 ` [Qemu-devel] [PATCH v2 04/15] mc146818rtc: always register rtc to rtc list Hervé Poussineau
2017-12-16 21:29 ` Hervé Poussineau [this message]
2017-12-16 21:29 ` [Qemu-devel] [PATCH v2 06/15] piix4: add Reset Control Register Hervé Poussineau
2017-12-16 21:29 ` [Qemu-devel] [PATCH v2 07/15] piix4: add a i8259 interrupt controller as specified in datasheet Hervé Poussineau
2017-12-16 21:29 ` [Qemu-devel] [PATCH v2 08/15] piix4: add a i8257 dma " Hervé Poussineau
2017-12-16 21:29 ` [Qemu-devel] [PATCH v2 09/15] piix4: add a i8254 pit " Hervé Poussineau
2017-12-16 21:29 ` [Qemu-devel] [PATCH v2 10/15] piix4: add a i8042 keyboard/mouse " Hervé Poussineau
2017-12-16 21:30 ` [Qemu-devel] [PATCH v2 11/15] piix4: add a floppy controller, 1 parallel port and 2 serial ports Hervé Poussineau
2017-12-16 21:30 ` [Qemu-devel] [PATCH v2 12/15] piix4: add a mc146818rtc controller as specified in datasheet Hervé Poussineau
2017-12-16 21:30 ` [Qemu-devel] [PATCH v2 13/15] piix4: add a speaker " Hervé Poussineau
2017-12-16 21:30 ` [Qemu-devel] [PATCH v2 14/15] piix4: rename PIIX4 object to piix4-isa Hervé Poussineau
2017-12-17 1:14 ` Philippe Mathieu-Daudé
2017-12-16 21:30 ` [Qemu-devel] [PATCH v2 15/15] piix4: we can now instanciate a PIIX4 with -device Hervé Poussineau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171216213004.30393-6-hpoussin@reactos.org \
--to=hpoussin@reactos.org \
--cc=aurelien@aurel32.net \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yongbok.kim@mips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.