All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/3] add new package proj
Date: Sun, 17 Dec 2017 10:21:13 +0100	[thread overview]
Message-ID: <20171217102113.4d65cf6d@windsurf> (raw)
In-Reply-To: <1513468381-8875-1-git-send-email-mr.zoltan.gyarmati@gmail.com>

Hello,

I've applied your patch, after doing a number of changes. First of all,
I've renamed it to "proj: new package", which is the convention when
adding new package. Then, the DEVELOPERS change has been squashed in
the patch adding the package.

On Sun, 17 Dec 2017 00:52:59 +0100, Zoltan Gyarmati wrote:

> diff --git a/package/proj/Config.in b/package/proj/Config.in
> new file mode 100644
> index 0000000..0dd92cc
> --- /dev/null
> +++ b/package/proj/Config.in
> @@ -0,0 +1,13 @@
> +config BR2_PACKAGE_PROJ
> +	bool "proj"
> +	depends on BR2_TOOLCHAIN_HAS_THREADS
> +	help
> +	  proj.4 is a standard UNIX filter function which converts geographic 
> +	  longitude and latitude coordinates into cartesian coordinates
> +	  (and vice versa), and it is a C API for software developers to include
> +	  coordinate transformation in their own software.

Lines too long and trailing whitespace here, I've fixed this up.

> +# Fetched from http://download.osgeo.org/proj/proj-4.9.3.tar.gz.md5
> +md5 d598336ca834742735137c5674b214a1 proj-4.9.3.tar.gz

A md5 hash alone is not sufficient, so I've added a sha256 hash. While
I was at it, I've added a hash for the license file as well.

> +PROJ_VERSION = 4.9.3
> +PROJ_SOURCE = proj-$(PROJ_VERSION).tar.gz
> +PROJ_SITE = http://download.osgeo.org/proj
> +PROJ_LICENSE = MIT

I've added PROJ_LICENSE_FILES

> +PROJ_INSTALL_STAGING = YES
> +
> +$(eval $(cmake-package))

Last but not least, I've switched to using the provided autotools build
system, because it correctly handled building a static library. Indeed,
your package using CMake was failing to build in static-only
configurations.

Applied with those fixes. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

      parent reply	other threads:[~2017-12-17  9:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-16 23:52 [Buildroot] [PATCH 1/3] add new package proj Zoltan Gyarmati
2017-12-16 23:53 ` [Buildroot] [PATCH 2/3] add myself as maintainer for the proj package Zoltan Gyarmati
2017-12-16 23:53 ` [Buildroot] [PATCH 3/3] package/shapelib: version bump, use the new autotools build config and add new dependency on proj Zoltan Gyarmati
2017-12-17  6:13   ` Baruch Siach
2017-12-17  9:32   ` Thomas Petazzoni
2017-12-17  9:42     ` Zoltan Gyarmati
2017-12-17  9:21 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171217102113.4d65cf6d@windsurf \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.