From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v1] DMA:omap-dma:Avoid build error by changing the function name From: Vinod Koul Message-Id: <20171218052925.GP18649@localhost> Date: Mon, 18 Dec 2017 10:59:25 +0530 To: venkat.prashanth2498@gmail.com, Peter Ujfalusi Cc: dan.j.williams@intel.com, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org List-ID: T24gVHVlLCBEZWMgMTIsIDIwMTcgYXQgMTI6NTg6NDFQTSArMDUzMCwgdmVua2F0LnByYXNoYW50 aDI0OThAZ21haWwuY29tIHdyb3RlOgo+IEZyb206IFZlbmthdCBQcmFzaGFudGggQiBVIDx2ZW5r YXQucHJhc2hhbnRoMjQ5OEBnbWFpbC5jb20+Cj4gCj4gQ2hhbmdlIHRoZSBuYW1lIG9mIHRoZSBm dW5jdGlvbiBvbWFwX2RtYV9maWx0ZXJfZm4gdG8gYXZvaWQKPiB0aGUgZm9sbG93aW5nIGJ1aWxk IGVycm9yIGluIGxpbnV4IGtlcm5lbCB2ZXJzaW9uIDQuNCA6Cj4gCj4gZHJpdmVycy9kbWEvZG1h LW9tYXAuYzoxMjczOjY6IGVycm9yOgo+IHJlZGVmaW5pdGlvbiBvZiAnb21hcF9kbWFfZmlsdGVy X2ZuJwoKT2theSBJIGRvIG5vdCBzZWUgdGhpcyBlcnJvciwgd2hpY2ggdHJlZSBhcmUgeW91IHJ1 bm5pbmc/CgpJbiBjb2RlIGlzIHNlZSBvbWFwX2RtYV9maWx0ZXJfZm4gaXMgdXNlZCBldmVyeXdo ZXJlIGFuZCBubyByZWZlcmVuY2UgdG8Kb21hcF9kbWFfZmlsdGVyX2Z1bmMKCkFkZGluZyBwZXRl ciB0b28uLgoKCj4gCj4gU2lnbmVkLW9mZi1ieTogVmVua2F0IFByYXNoYW50aCBCIFUgPHZlbmth dC5wcmFzaGFudGgyNDk4QGdtYWlsLmNvbT4KPiBDaGFuZ2VzIGZvciB2MToKPiAtIEVkaXRlZCBz dWJqZWN0IGFuZCBkZXNjcmlwdGlvbiBvZiB0aGUgcGF0Y2ggdG8gZml0IHdpdGggdGhlIGNoYW5n ZQo+ICAgZG9uZSBpbiB0aGUgY29kZSBiYXNlLCBhcyBzdWdnZXN0ZWQgYnkgVmlub2QgS291bC4K PiAKPiAtIEluIG9yZGVyIHRvIGF2b2lkICBpc3N1ZXMgbGlrZSBiYWNrcG9ydGluZyBvbiBzdGFi bGUgdGhlCj4gICBjaGVja3BhdGNoLnBsIGlzc3VlcyBhcmUgZHJvcHBlZCBhcyBzdWdnZXN0ZWQg YnkgVmlub2QgS291bC4KPiAtLS0KPiAgZHJpdmVycy9kbWEvb21hcC1kbWEuYyB8IDIgKy0KPiAg MSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCj4gCj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvZG1hL29tYXAtZG1hLmMgYi9kcml2ZXJzL2RtYS9vbWFwLWRtYS5jCj4g aW5kZXggMWRmYzcxYy4uODU0NWRkYSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2RtYS9vbWFwLWRt YS5jCj4gKysrIGIvZHJpdmVycy9kbWEvb21hcC1kbWEuYwo+IEBAIC0xMjY5LDcgKzEyNjksNyBA QCBzdGF0aWMgc3RydWN0IHBsYXRmb3JtX2RyaXZlciBvbWFwX2RtYV9kcml2ZXIgPSB7Cj4gIAl9 LAo+ICB9Owo+ICAKPiAtYm9vbCBvbWFwX2RtYV9maWx0ZXJfZm4oc3RydWN0IGRtYV9jaGFuICpj aGFuLCB2b2lkICpwYXJhbSkKPiArYm9vbCBvbWFwX2RtYV9maWx0ZXJfZnVuYyhzdHJ1Y3QgZG1h X2NoYW4gKmNoYW4sIHZvaWQgKnBhcmFtKQo+ICB7Cj4gIAlpZiAoY2hhbi0+ZGV2aWNlLT5kZXYt PmRyaXZlciA9PSAmb21hcF9kbWFfZHJpdmVyLmRyaXZlcikgewo+ICAJCXN0cnVjdCBvbWFwX2Rt YWRldiAqb2QgPSB0b19vbWFwX2RtYV9kZXYoY2hhbi0+ZGV2aWNlKTsKPiAtLSAKPiAxLjkuMQo+ IC0tCj4gVG8gdW5zdWJzY3JpYmUgZnJvbSB0aGlzIGxpc3Q6IHNlbmQgdGhlIGxpbmUgInVuc3Vi c2NyaWJlIGRtYWVuZ2luZSIgaW4KPiB0aGUgYm9keSBvZiBhIG1lc3NhZ2UgdG8gbWFqb3Jkb21v QHZnZXIua2VybmVsLm9yZwo+IE1vcmUgbWFqb3Jkb21vIGluZm8gYXQgIGh0dHA6Ly92Z2VyLmtl cm5lbC5vcmcvbWFqb3Jkb21vLWluZm8uaHRtbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757907AbdLRFZg (ORCPT ); Mon, 18 Dec 2017 00:25:36 -0500 Received: from mga11.intel.com ([192.55.52.93]:4675 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750953AbdLRFZe (ORCPT ); Mon, 18 Dec 2017 00:25:34 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,420,1508828400"; d="scan'208";a="14431401" Date: Mon, 18 Dec 2017 10:59:25 +0530 From: Vinod Koul To: venkat.prashanth2498@gmail.com, Peter Ujfalusi Cc: dan.j.williams@intel.com, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] DMA:omap-dma:Avoid build error by changing the function name Message-ID: <20171218052925.GP18649@localhost> References: <1513063721-13688-1-git-send-email-venkat.prashanth2498@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1513063721-13688-1-git-send-email-venkat.prashanth2498@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 12, 2017 at 12:58:41PM +0530, venkat.prashanth2498@gmail.com wrote: > From: Venkat Prashanth B U > > Change the name of the function omap_dma_filter_fn to avoid > the following build error in linux kernel version 4.4 : > > drivers/dma/dma-omap.c:1273:6: error: > redefinition of 'omap_dma_filter_fn' Okay I do not see this error, which tree are you running? In code is see omap_dma_filter_fn is used everywhere and no reference to omap_dma_filter_func Adding peter too.. > > Signed-off-by: Venkat Prashanth B U > Changes for v1: > - Edited subject and description of the patch to fit with the change > done in the code base, as suggested by Vinod Koul. > > - In order to avoid issues like backporting on stable the > checkpatch.pl issues are dropped as suggested by Vinod Koul. > --- > drivers/dma/omap-dma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/dma/omap-dma.c b/drivers/dma/omap-dma.c > index 1dfc71c..8545dda 100644 > --- a/drivers/dma/omap-dma.c > +++ b/drivers/dma/omap-dma.c > @@ -1269,7 +1269,7 @@ static struct platform_driver omap_dma_driver = { > }, > }; > > -bool omap_dma_filter_fn(struct dma_chan *chan, void *param) > +bool omap_dma_filter_func(struct dma_chan *chan, void *param) > { > if (chan->device->dev->driver == &omap_dma_driver.driver) { > struct omap_dmadev *od = to_omap_dma_dev(chan->device); > -- > 1.9.1 > -- > To unsubscribe from this list: send the line "unsubscribe dmaengine" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- ~Vinod