From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v8 0/9] Add support for the Rust programming language
Date: Mon, 18 Dec 2017 11:31:22 +0100 [thread overview]
Message-ID: <20171218113122.76db1f02@windsurf> (raw)
In-Reply-To: <706201859.95242518.1513592711039.JavaMail.root@zimbra32-e6>
Hello,
On Mon, 18 Dec 2017 11:25:11 +0100 (CET), Eric Le Bihan wrote:
> The patch which adds the package to build Rust from source provides a
> patch to fix a problem involving files ending with *.orig.
>
> As the Rust compiler is built using Cargo, the tarball contains vendored
> versions of the crates (e.g. src/vendor/backtrace-sys). Each crate
> contains a file named Cargo.toml.orig. An associated file named
> .cargo-checksum.json will contain a checksum for Cargo.toml.orig (and
> the other source files).
>
> But support/scripts/apply-patches.sh will delete the Cargo.toml.orig
> files. This will cause the build to fail, as Cargo will not be able to
> find the file and verify the checksum.
>
> So the patch included in the rust package removes all Cargo.toml.orig
> entries from the affected .cargo-checksum.json. As these files list all
> the source files, this results in a huge patch.
>
> Besides, as these are non-indented JSON files, some are one-lined and
> thus the 998 characters limit enforced by git-send-email is exceeded.
>
> So, if there a way to stop support/scripts/apply-patches.sh from pruning
> Cargo.toml.orig files, so this patch can be dropped?
Do we really have a reason to remove *.orig files in
apply-patches.sh ? .orig backup files are only produced if -b is passed
to patch, which we are not using.
Are there other cases where .orig files are produced by patch *and* we
really need to remove them?
Peter, Arnout, Yann?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-12-18 10:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-17 17:57 [Buildroot] [PATCH v8 0/9] Add support for the Rust programming language Eric Le Bihan
2017-12-17 17:58 ` [Buildroot] [PATCH 1/9] rustc: new virtual package Eric Le Bihan
2017-12-17 17:58 ` [Buildroot] [PATCH 2/9] rust-bin: new package Eric Le Bihan
2017-12-17 17:58 ` [Buildroot] [PATCH 3/9] cargo-bin: " Eric Le Bihan
2017-12-17 17:58 ` [Buildroot] [PATCH 5/9] libssh2: add host variant Eric Le Bihan
2017-12-17 17:58 ` [Buildroot] [PATCH 6/9] libhttpparser: " Eric Le Bihan
2017-12-17 17:58 ` [Buildroot] [PATCH 7/9] libcurl: " Eric Le Bihan
2017-12-18 5:40 ` Baruch Siach
2017-12-27 18:53 ` Eric Le Bihan
2017-12-17 17:58 ` [Buildroot] [PATCH 8/9] cargo: new package Eric Le Bihan
2017-12-17 17:58 ` [Buildroot] [PATCH 9/9] rust-cargo: new virtual package Eric Le Bihan
2017-12-17 18:17 ` [Buildroot] [PATCH v8 0/9] Add support for the Rust programming language Eric Le Bihan
2017-12-18 6:54 ` Thomas Petazzoni
2017-12-18 10:25 ` Eric Le Bihan
2017-12-18 10:31 ` Thomas Petazzoni [this message]
2017-12-18 15:26 ` Yann E. MORIN
2017-12-18 10:49 ` Eric Le Bihan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171218113122.76db1f02@windsurf \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.