From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v1 1/3] net/hyperv: introduce MS Hyper-V
 platform driver
Date: Mon, 18 Dec 2017 13:17:51 -0800
Message-ID: <20171218131751.5c5d9467@xeon-e3>
References: <20171124172132.GW4062@6wind.com>
 <20171218162443.12971-2-adrien.mazarguil@6wind.com>
 <20171218102835.7602545f@xeon-e3> <7420927.98Cnld71HS@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: Adrien Mazarguil <adrien.mazarguil@6wind.com>, dev@dpdk.org, Ferruh
 Yigit <ferruh.yigit@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pl0-f66.google.com (mail-pl0-f66.google.com
 [209.85.160.66]) by dpdk.org (Postfix) with ESMTP id 67A7E271
 for <dev@dpdk.org>; Mon, 18 Dec 2017 22:17:55 +0100 (CET)
Received: by mail-pl0-f66.google.com with SMTP id s3so5589552plp.4
 for <dev@dpdk.org>; Mon, 18 Dec 2017 13:17:55 -0800 (PST)
In-Reply-To: <7420927.98Cnld71HS@xps>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, 18 Dec 2017 20:54:16 +0100
Thomas Monjalon <thomas@monjalon.net> wrote:

> > > +#endif /* RTE_LIBRTE_HYPERV_DEBUG */
> > > +
> > > +#define DEBUG(...) PMD_DRV_LOG(DEBUG, __VA_ARGS__)
> > > +#define INFO(...) PMD_DRV_LOG(INFO, __VA_ARGS__)
> > > +#define WARN(...) PMD_DRV_LOG(WARNING, __VA_ARGS__)
> > > +#define ERROR(...) PMD_DRV_LOG(ERR, __VA_ARGS__)
> > > +  
> > 
> > Please don't use DEBUG() etc macros. It makes it easier for tools that do
> > global updates or scans if all drivers use the same model of PMD_DRV_LOG  
> 
> The new standard is to use dynamic logtype.

Agree, please use dynamic logging, and also don't redefine new macros like DEBUG/INFO/WARN/ERROR.
Instead use PMD_DRV_LOG or equivalent macros.

The base rule here is that all drivers should look the same as much
as reasonably possible. This makes reviewers of other subsystems more likely
to see problems. It also allows for later changes where some developer does a global
improvement across many PMD's.

Drivers should not be snowflakes, each one is not unique.