From mboxrd@z Thu Jan 1 00:00:00 1970 From: Miquel RAYNAL Subject: Re: [PATCH v3 05/11] thermal: armada: Add support for Armada AP806 Date: Mon, 18 Dec 2017 13:25:00 +0100 Message-ID: <20171218132500.7f7225e9@xps13> References: <20171214103011.24713-1-miquel.raynal@free-electrons.com> <20171214103011.24713-6-miquel.raynal@free-electrons.com> <87y3m5o9h4.fsf@free-electrons.com> <20171218104127.65017555@xps13> <20171218111156.76a66q5kwh3advs7@sapphire.tkos.co.il> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20171218111156.76a66q5kwh3advs7@sapphire.tkos.co.il> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Baruch Siach Cc: Mark Rutland , Andrew Lunn , Jason Cooper , Nadav Haklai , devicetree@vger.kernel.org, Catalin Marinas , Antoine Tenart , linux-pm@vger.kernel.org, Will Deacon , Eduardo Valentin , David Sniatkiwicz , Rob Herring , Gregory CLEMENT , Zhang Rui , Thomas Petazzoni , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth List-Id: linux-pm@vger.kernel.org SGkgQmFydWNoLAoKT24gTW9uLCAxOCBEZWMgMjAxNyAxMzoxMTo1NiArMDIwMApCYXJ1Y2ggU2lh Y2ggPGJhcnVjaEB0a29zLmNvLmlsPiB3cm90ZToKCj4gSGkgTWlxdcOobCwKPiAKPiBPbiBNb24s IERlYyAxOCwgMjAxNyBhdCAxMDo0MToyN0FNICswMTAwLCBNaXF1ZWwgUkFZTkFMIHdyb3RlOgo+ ID4gSGVsbG8gR3JlZ29yeSAmIEJhcnVjaCwKPiA+IAo+ID4gT24gVGh1LCAxNCBEZWMgMjAxNyAx MjowNTo0MyArMDEwMAo+ID4gR3JlZ29yeSBDTEVNRU5UIDxncmVnb3J5LmNsZW1lbnRAZnJlZS1l bGVjdHJvbnMuY29tPiB3cm90ZToKPiA+ICAgCj4gPiA+ID4gQEAgLTE4NCw5ICsyMTQsOSBAQCBz dGF0aWMgaW50IGFybWFkYV9nZXRfdGVtcChzdHJ1Y3QKPiA+ID4gPiB0aGVybWFsX3pvbmVfZGV2 aWNlICp0aGVybWFsLCBkaXYgPSBwcml2LT5kYXRhLT5jb2VmX2RpdjsKPiA+ID4gPiAgCj4gPiA+ ID4gIAlpZiAocHJpdi0+ZGF0YS0+aW52ZXJ0ZWQpCj4gPiA+ID4gLQkJKnRlbXAgPSAoKG0gKiBy ZWcpIC0gYikgLyBkaXY7Cj4gPiA+ID4gKwkJKnRlbXAgPSAoKG0gKiBzYW1wbGUpIC0gYikgLyBk aXY7Cj4gPiA+ID4gIAllbHNlCj4gPiA+ID4gLQkJKnRlbXAgPSAoYiAtIChtICogcmVnKSkgLyBk aXY7Cj4gPiA+ID4gKwkJKnRlbXAgPSAoYiAtIChtICogc2FtcGxlKSkgLyBkaXY7Cj4gPiA+ID4g IAlyZXR1cm4gMDsKPiA+ID4gPiAgfQo+ID4gPiA+ICAKPiA+ID4gPiBAQCAtMjM3LDYgKzI2Nywx OSBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IGFybWFkYV90aGVybWFsX2RhdGEKPiA+ID4gPiBhcm1h ZGEzODBfZGF0YSA9IHsgLmludmVydGVkID0gdHJ1ZSwKPiA+ID4gPiAgfTsKPiA+ID4gPiAgCj4g PiA+ID4gK3N0YXRpYyBjb25zdCBzdHJ1Y3QgYXJtYWRhX3RoZXJtYWxfZGF0YSBhcm1hZGFfYXA4 MDZfZGF0YSA9IHsKPiA+ID4gPiArCS5pc192YWxpZCA9IGFybWFkYV9pc192YWxpZCwKPiA+ID4g PiArCS5pbml0X3NlbnNvciA9IGFybWFkYV9hcDgwNl9pbml0X3NlbnNvciwKPiA+ID4gPiArCS5p c192YWxpZF9iaXQgPSBCSVQoMTYpLAo+ID4gPiA+ICsJLnRlbXBfc2hpZnQgPSAwLAo+ID4gPiA+ ICsJLnRlbXBfbWFzayA9IDB4M2ZmLAo+ID4gPiA+ICsJLmNvZWZfYiA9IC0xNTAwMDAsICAgIAo+ ID4gPiAKPiA+ID4gRG9uJ3QgeW91IGV4cGVjdCBhbnkgc2lkZSBlZmZlY3QgYnkgc3RvcmluZyBh IG5lZ2F0aXZlIHZhbHVlIGluIGEKPiA+ID4gdW5zaWduZWQgdmFyaWFibGU/ICAKPiA+IAo+ID4g VGhhdCBpcyBhIGZhaXIgcXVlc3Rpb24sIEkgZGlkIG5vdCBzcG90IHRoYXQuCj4gPiAKPiA+IEFz IG90aGVyIHZhbHVlcyBhcmUgcmVhbGx5IGNsb3NlIHRvIDJeMzIgSSBkb24ndCBrbm93IHdoYXQg aXMgdGhlCj4gPiBiZXN0IG9wdGlvbiBmb3IgdXMgaW4gdGhpcyBjYXNlLiBTaG91bGQgSToKPiA+ IC0gZG9uJ3QgY2FyZT8KPiA+IC0gdXNlIHNpZ25lZCB2YWx1ZXM/IChkYW5nZXJvdXMgSU1ITykK PiA+IC0gdXNlIGEgdW5pb24gd2l0aCBhIHNpZ25lZCBhbmQgYW4gdW5zaWduZWQgdmFsdWU/IChw cm9ibGVtIG1vdmVkCj4gPiB0byAtPmdldF90ZW1wKCkpICAKPiAKPiBBbm90aGVyIG9wdGlvbiBp cyB0byB1c2UgczY0IHR5cGUuCgpJIHByZWZlciB0aGlzIG9uZSEKClRoYW5rIHlvdSwKTWlxdcOo bAoKPiAKPiBiYXJ1Y2gKPiAKCgoKLS0gCk1pcXVlbCBSYXluYWwsIEZyZWUgRWxlY3Ryb25zCkVt YmVkZGVkIExpbnV4IGFuZCBLZXJuZWwgZW5naW5lZXJpbmcKaHR0cDovL2ZyZWUtZWxlY3Ryb25z LmNvbQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlu dXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRl YWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgt YXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: miquel.raynal@free-electrons.com (Miquel RAYNAL) Date: Mon, 18 Dec 2017 13:25:00 +0100 Subject: [PATCH v3 05/11] thermal: armada: Add support for Armada AP806 In-Reply-To: <20171218111156.76a66q5kwh3advs7@sapphire.tkos.co.il> References: <20171214103011.24713-1-miquel.raynal@free-electrons.com> <20171214103011.24713-6-miquel.raynal@free-electrons.com> <87y3m5o9h4.fsf@free-electrons.com> <20171218104127.65017555@xps13> <20171218111156.76a66q5kwh3advs7@sapphire.tkos.co.il> Message-ID: <20171218132500.7f7225e9@xps13> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Baruch, On Mon, 18 Dec 2017 13:11:56 +0200 Baruch Siach wrote: > Hi Miqu?l, > > On Mon, Dec 18, 2017 at 10:41:27AM +0100, Miquel RAYNAL wrote: > > Hello Gregory & Baruch, > > > > On Thu, 14 Dec 2017 12:05:43 +0100 > > Gregory CLEMENT wrote: > > > > > > @@ -184,9 +214,9 @@ static int armada_get_temp(struct > > > > thermal_zone_device *thermal, div = priv->data->coef_div; > > > > > > > > if (priv->data->inverted) > > > > - *temp = ((m * reg) - b) / div; > > > > + *temp = ((m * sample) - b) / div; > > > > else > > > > - *temp = (b - (m * reg)) / div; > > > > + *temp = (b - (m * sample)) / div; > > > > return 0; > > > > } > > > > > > > > @@ -237,6 +267,19 @@ static const struct armada_thermal_data > > > > armada380_data = { .inverted = true, > > > > }; > > > > > > > > +static const struct armada_thermal_data armada_ap806_data = { > > > > + .is_valid = armada_is_valid, > > > > + .init_sensor = armada_ap806_init_sensor, > > > > + .is_valid_bit = BIT(16), > > > > + .temp_shift = 0, > > > > + .temp_mask = 0x3ff, > > > > + .coef_b = -150000, > > > > > > Don't you expect any side effect by storing a negative value in a > > > unsigned variable? > > > > That is a fair question, I did not spot that. > > > > As other values are really close to 2^32 I don't know what is the > > best option for us in this case. Should I: > > - don't care? > > - use signed values? (dangerous IMHO) > > - use a union with a signed and an unsigned value? (problem moved > > to ->get_temp()) > > Another option is to use s64 type. I prefer this one! Thank you, Miqu?l > > baruch > -- Miquel Raynal, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com