From: Cornelia Huck <cohuck@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: no-reply@patchew.org, qemu-devel@nongnu.org, famz@redhat.com,
stefanb@linux.vnet.ibm.com,
marcandre lureau <marcandre.lureau@redhat.com>,
thuth@redhat.com
Subject: Re: [Qemu-devel] [PATCH] tpm: move qdev_prop_tpm to hw/tpm/
Date: Mon, 18 Dec 2017 17:06:18 +0100 [thread overview]
Message-ID: <20171218170618.69ff1ca1.cohuck@redhat.com> (raw)
In-Reply-To: <180764363.27732961.1513612859884.JavaMail.zimbra@redhat.com>
On Mon, 18 Dec 2017 11:00:59 -0500 (EST)
Paolo Bonzini <pbonzini@redhat.com> wrote:
> > > ../hw/tpm/tpm_tis.o:tpm_tis.c:(.data+0x50): undefined reference to
> > > `qdev_prop_tpm'
> > > collect2: error: ld returned 1 exit status
> > > Makefile:193: recipe for target 'qemu-system-x86_64w.exe' failed
> > > make[1]: *** [qemu-system-x86_64w.exe] Error 1
> > > make: *** [subdir-x86_64-softmmu] Error 2
> > > Makefile:384: recipe for target 'subdir-x86_64-softmmu' failed
> >
> > Seems we need to build tpm_util also when tpm_tis is built (and none of
> > the others).
>
> Or place the property in its own file.
Currently testing building tpm_util all of the time; waiting for a vote
from the tpm maintainer.
[Building a file called 'util' all of the time makes sense to me.]
next prev parent reply other threads:[~2017-12-18 16:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-18 14:00 [Qemu-devel] [PATCH] tpm: move qdev_prop_tpm to hw/tpm/ Cornelia Huck
2017-12-18 14:11 ` Marc-André Lureau
2017-12-18 14:33 ` no-reply
2017-12-18 15:53 ` Cornelia Huck
2017-12-18 16:00 ` Paolo Bonzini
2017-12-18 16:06 ` Cornelia Huck [this message]
2017-12-18 18:33 ` Stefan Berger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171218170618.69ff1ca1.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=famz@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=no-reply@patchew.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanb@linux.vnet.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.