From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brian Norris Subject: Re: [PATCH for-4.15] ASoC: rt5514: don't assume rt5514 component was "attached" Date: Mon, 18 Dec 2017 09:42:36 -0800 Message-ID: <20171218174235.GA113663@google.com> References: <20171216011230.107527-1-briannorris@chromium.org> <20171216031738.GA220575@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-it0-f68.google.com (mail-it0-f68.google.com [209.85.214.68]) by alsa0.perex.cz (Postfix) with ESMTP id E795A267544 for ; Mon, 18 Dec 2017 18:42:41 +0100 (CET) Received: by mail-it0-f68.google.com with SMTP id t1so29153219ite.5 for ; Mon, 18 Dec 2017 09:42:41 -0800 (PST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Cheng-yi Chiang Cc: Oder Chiou , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Jeffy Chen , Takashi Iwai , Liam Girdwood , linux-rockchip@lists.infradead.org, Mark Brown , Bard Liao , Matthias Kaehlcke List-Id: alsa-devel@alsa-project.org Hi! (By the way, your mail is HTML and likely will get rejected by many mailing lists and/or people reading these mailing lists.) On Mon, Dec 18, 2017 at 12:23:18PM +0800, Cheng-yi Chiang wrote: > Hi Brian, > Oder has posted the same fix : [1]https://patchwork.kernel.org/ > patch/10066257/ and it has been applied. OK cool. Obviously I'm biased, but I prefer mine, as it has less needless whitespace, and is appropriately documented ;) But it should be a fine replacement. > Perhaps you can cherry-pick it to v4.15 ? I have no say in that; that would be up to Mark, I think. It's most certainly a regression in 4.15-rc1, so IMO it should be given a proper 'Fixes: e9c50aa6bd39 ("ASoC: rt5514-spi: check irq status to schedule data copy in resume function")' tag and sent for 4.15, not 4.16. Brian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S937544AbdLRRmq (ORCPT ); Mon, 18 Dec 2017 12:42:46 -0500 Received: from mail-it0-f68.google.com ([209.85.214.68]:43171 "EHLO mail-it0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936719AbdLRRml (ORCPT ); Mon, 18 Dec 2017 12:42:41 -0500 X-Google-Smtp-Source: ACJfBosYB8gd7C4cX+n9vW8GWHMzESiTvMgGee3QoxKP/hmOAgMdBpKi1QfV65cK68LM7G03/MY4hw== Date: Mon, 18 Dec 2017 09:42:36 -0800 From: Brian Norris To: Cheng-yi Chiang , Mark Brown Cc: Oder Chiou , Bard Liao , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Matthias Kaehlcke , Jeffy Chen , linux-rockchip@lists.infradead.org Subject: Re: [PATCH for-4.15] ASoC: rt5514: don't assume rt5514 component was "attached" Message-ID: <20171218174235.GA113663@google.com> References: <20171216011230.107527-1-briannorris@chromium.org> <20171216031738.GA220575@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! (By the way, your mail is HTML and likely will get rejected by many mailing lists and/or people reading these mailing lists.) On Mon, Dec 18, 2017 at 12:23:18PM +0800, Cheng-yi Chiang wrote: > Hi Brian, > Oder has posted the same fix : [1]https://patchwork.kernel.org/ > patch/10066257/ and it has been applied. OK cool. Obviously I'm biased, but I prefer mine, as it has less needless whitespace, and is appropriately documented ;) But it should be a fine replacement. > Perhaps you can cherry-pick it to v4.15 ? I have no say in that; that would be up to Mark, I think. It's most certainly a regression in 4.15-rc1, so IMO it should be given a proper 'Fixes: e9c50aa6bd39 ("ASoC: rt5514-spi: check irq status to schedule data copy in resume function")' tag and sent for 4.15, not 4.16. Brian