From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pali =?utf-8?B?Um9ow6Fy?= Subject: Re: [PATCH] platform/x86: dell-wmi: Add an event created by Dell Latitude 5495 Date: Tue, 19 Dec 2017 09:34:55 +0100 Message-ID: <20171219083455.zekue2qqrf46rps6@pali> References: <1513654714-32175-1-git-send-email-sylee@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from mail-wr0-f180.google.com ([209.85.128.180]:36672 "EHLO mail-wr0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757897AbdLSIe6 (ORCPT ); Tue, 19 Dec 2017 03:34:58 -0500 Received: by mail-wr0-f180.google.com with SMTP id u19so11490228wrc.3 for ; Tue, 19 Dec 2017 00:34:57 -0800 (PST) Content-Disposition: inline In-Reply-To: <1513654714-32175-1-git-send-email-sylee@canonical.com> Sender: platform-driver-x86-owner@vger.kernel.org List-ID: To: "Shih-Yuan Lee (FourDollars)" Cc: platform-driver-x86@vger.kernel.org, Matthew Garrett , Darren Hart , Andy Shevchenko On Tuesday 19 December 2017 11:38:34 Shih-Yuan Lee (FourDollars) wrote: > The Dell Latitude 5495 has the mic mute key. > > Signed-off-by: Shih-Yuan Lee (FourDollars) > --- > drivers/platform/x86/dell-wmi.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c > index fb25b20..d40f803 100644 > --- a/drivers/platform/x86/dell-wmi.c > +++ b/drivers/platform/x86/dell-wmi.c > @@ -261,6 +261,9 @@ static const u16 bios_to_linux_keycode[256] = { > * override them. > */ > static const struct key_entry dell_wmi_keymap_type_0010[] = { > + /* Mic mute */ > + { KE_KEY, 0x150, { KEY_F20 } }, Hi! Are you sure that this key code needs to be in 0010 table? Because primary this table is constructed from DMI information. See array bios_to_linux_keycode[]. > + > /* Fn-lock */ > { KE_IGNORE, 0x151, { KEY_RESERVED } }, > -- Pali Rohár pali.rohar@gmail.com