From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935207AbdLSIqo (ORCPT ); Tue, 19 Dec 2017 03:46:44 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:52680 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933975AbdLSIqj (ORCPT ); Tue, 19 Dec 2017 03:46:39 -0500 Date: Tue, 19 Dec 2017 09:46:41 +0100 From: Greg KH To: Yisheng Xie Cc: thomas.lendacky@amd.com, lorenzo.pieralisi@arm.com, bp@suse.de, tglx@linutronix.de, kstewart@linuxfoundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] devres: use MACRO instead of function for devm_ioremap Message-ID: <20171219084641.GA15010@kroah.com> References: <1511601813-20533-1-git-send-email-xieyisheng1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1511601813-20533-1-git-send-email-xieyisheng1@huawei.com> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Nov 25, 2017 at 05:23:33PM +0800, Yisheng Xie wrote: > Default ioremap is ioremap_nocache, so devm_ioremap has the same function > with devm_ioremap_nocache, which may just be killed. However, there are > many places which use devm_ioremap_nocache, while many use devm_ioremap. > > This patch is to use MACRO for devm_ioremap, which will reduce the size of > devres.o from 206824 Bytes to 203768 Bytes. Ok, the idea is good, but why not just get rid of the callers of devm_ioremap_nocache() instead and have them call devm_ioremap() if they really are the same thing? No need to keep a macro around for the duplicate thing, just delete the one and things are much better. thanks, greg k-h