From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
Eric Dumazet <edumazet@google.com>,
Tariq Toukan <tariqt@mellanox.com>,
"David S . Miller" <davem@davemloft.net>,
Komali Katari <komali@chelsio.com>,
"Luis R. Rodriguez" <mcgrof@kernel.org>,
Casey Leedom <leedom@chelsio.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kobject: fix suppressing modalias in uevents delivered over netlink
Date: Tue, 19 Dec 2017 09:48:19 +0100 [thread overview]
Message-ID: <20171219084819.GB15010@kroah.com> (raw)
In-Reply-To: <20171213232122.5ztmwume5kylh4mz@dtor-ws>
On Wed, Dec 13, 2017 at 03:21:22PM -0800, Dmitry Torokhov wrote:
> The commit 4a336a23d619 ("kobject: copy env blob in one go") optimized
> constructing uevent data for delivery over netlink by using the raw
> environment buffer, instead of reconstructing it from individual
> environment pointers. Unfortunately in doing so it broke suppressing
> MODALIAS attribute for KOBJ_UNBIND events, as the code that suppressed this
> attribute only adjusted the environment pointers, but left the buffer
> itself alone. Let's fix it by making sure the offending attribute is
> obliterated form the buffer as well.
>
> Reported-by: Tariq Toukan <tariqt@mellanox.com>
> Reported-by: Casey Leedom <leedom@chelsio.com>
> Fixes: 4a336a23d619 ("kobject: copy env blob in one go")
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
> lib/kobject_uevent.c | 16 ++++++++++++----
> 1 file changed, 12 insertions(+), 4 deletions(-)
Ok, I'm lost here, is this patch still needed for 4.15-final?
And am I supposed to be taking it through my tree as the offending patch
didn't come from me? :)
thanks,
greg k-h
next prev parent reply other threads:[~2017-12-19 8:48 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-13 23:21 [PATCH] kobject: fix suppressing modalias in uevents delivered over netlink Dmitry Torokhov
2017-12-14 20:15 ` Casey Leedom
2017-12-14 20:32 ` Dmitry Torokhov
2017-12-14 21:38 ` Casey Leedom
2017-12-14 21:44 ` Dmitry Torokhov
2017-12-14 22:08 ` Casey Leedom
2017-12-15 18:17 ` Casey Leedom
2017-12-15 18:53 ` Dmitry Torokhov
2017-12-15 19:17 ` Casey Leedom
2017-12-18 19:45 ` Casey Leedom
2017-12-18 20:06 ` Casey Leedom
2017-12-19 21:20 ` Casey Leedom
2017-12-21 5:13 ` Dmitry Torokhov
2017-12-21 20:26 ` Casey Leedom
2017-12-28 1:56 ` Casey Leedom
2017-12-31 10:28 ` Tariq Toukan
2017-12-31 10:39 ` Greg Kroah-Hartman
2017-12-31 10:55 ` Tariq Toukan
2017-12-17 15:29 ` Tariq Toukan
2017-12-17 16:48 ` Tariq Toukan
2017-12-19 8:48 ` Greg Kroah-Hartman [this message]
2017-12-19 9:12 ` Eric Dumazet
2017-12-19 15:41 ` Tariq Toukan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171219084819.GB15010@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=davem@davemloft.net \
--cc=dmitry.torokhov@gmail.com \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=komali@chelsio.com \
--cc=leedom@chelsio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=tariqt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.