From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: USB: serial: option: adding support for YUGA CLM920-NC5 From: Johan Hovold Message-Id: <20171219085423.GA8917@localhost> Date: Tue, 19 Dec 2017 09:54:23 +0100 To: =?iso-8859-1?Q?Bj=F8rn?= Mork Cc: SZ Lin =?utf-8?B?KOael+S4iuaZuik=?= , Johan Hovold , Taiyi TY Wu =?utf-8?B?KOWQs+azsOavhSk=?= , Greg Kroah-Hartman , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" List-ID: T24gVHVlLCBEZWMgMTksIDIwMTcgYXQgMDc6MTQ6MTdBTSArMDEwMCwgQmrDuHJuIE1vcmsgd3Jv dGU6Cj4gIlNaIExpbiAo5p6X5LiK5pm6KSIgPFNaLkxpbkBtb3hhLmNvbT4gd3JpdGVzOgo+ID4+ IEpvaGFuIEhvdm9sZCA8am9oYW5Aa2VybmVsLm9yZz4gd3JpdGVzOgo+ID4+IAo+ID4+ID4+ICtz dGF0aWMgY29uc3Qgc3RydWN0IG9wdGlvbl9ibGFja2xpc3RfaW5mbyB5dWdhX2NsbTkyMF9uYzVf YmxhY2tsaXN0ID0gewo+ID4+ID4+ICsJLnJlc2VydmVkID0gQklUKDApIHwgQklUKDEpIHwgQklU KDQpLCB9Owo+ID4+ID4KPiA+PiA+IERvIHlvdSByZWFsbHkgbmVlZCB0byBibGFja2xpc3QgdGhl IGZpcnN0IGludGVyZmFjZT8KPiA+PiAKPiA+PiBHb29kIHF1ZXN0aW9uLiBJbnRlcmZhY2UgIzAg ZG9lcyBsb29rIGEgbG90IGxpa2UgYSBRdWFsY29tbSBETS9ESUFHCj4gPj4gZnVuY3Rpb24sIGJh c2VkIG9uIHR3byBidWxrIGVuZHBvaW50cywgbm8gYWRkaXRpb25hbCBkZXNjcmlwdG9ycwo+ID4+ IGFuZCB0aGUgZmFjdCB0aGF0IGl0IGlzIHRoZSBmaXJzdCBpbnRlcmZhY2UuICBJZiBzbywgdGhl biB3ZSBkbwo+ID4+IHdhbnQgYSBzZXJpYWwgZHJpdmVyIGZvciBpdC4gIFRoZXJlIGlzIGEgYmFz aWMgbGlicWNkbQo+ID4+IGltcGxlbWVudGF0aW9uIGluIE1vZGVtTWFuYWdlciBpZiB5b3Ugd2Fu dCB0byB0ZXN0IGl0IG91dC4KPiA+Cj4gPkkgaGF2ZSBjb25maXJtZWQgdGhhdCBpbnRlcmZhY2Ug IzAgaXMgUUNETS9ESUFHIHBvcnQgaW4gdGhpcyBtb2R1bGUsCj4gPmFuZCB0aHVzIEkgd2lsbCBy ZW1vdmUgdGhpcyBmcm9tIHJlc2VydmVkIGxpc3QgaW4gbmV4dCBwYXRjaC4KClRoYW5rcyB0byBi b3RoIG9mIHlvdSBmb3IgY29uZmlybWluZy4KCj4gPkZ1cnRoZXJtb3JlLCBpbnRlcmZhY2UgIzEg aXMgQURCIHBvcnQuIFNob3VsZCBJIGFsc28gcmVtb3ZlIHRoaXMgZnJvbQo+ID5yZXNlcnZlZCBs aXN0Pwo+IAo+IE5vLiBBREIgaXMgaGFuZGxlZCBieSB1c2Vyc3BhY2UgdG9vbHMgdXNpbmcgbGli dXNiLiAgSXQgc2hvdWxkIG5vdCBiZQo+IGJvdW5kIHRvIGFueSBzZXJpYWwgZHJpdmVyLCBzbyB5 b3Ugd2lsbCBuZWVkIHRvIGJsYWNrbGlzdCBpdC4gIEJ1dCB5b3UKPiBuZWVkIHRvIGtlZXAgdGhl IGJsYWNrbGlzdCBhbnl3YXkgdG8gaW5jbHVkZSB0aGUgUUNETS9ESUFHIHBvcnQKPgo+IEkgYXNz dW1lIEpvaGFuJ3MgYWx0ZXJuYXRpdmUgd2FzIHRvIG1hdGNoIGNsYXNzL3N1YmNsYXNzL3Byb3Rv Y29sCj4gYWdhaW5zdCBmZi8wMC8wMCwgd2hpY2ggd291bGQgaGF2ZSB3b3JrZWQgaWYgeW91IG9u bHkgd2FudGVkIHRvIGluY2x1ZGUKPiBpbnRlcmZhY2VzIDIgYW5kIDMuCgpJbmRlZWQuCgpKb2hh bgotLS0KVG8gdW5zdWJzY3JpYmUgZnJvbSB0aGlzIGxpc3Q6IHNlbmQgdGhlIGxpbmUgInVuc3Vi c2NyaWJlIGxpbnV4LXVzYiIgaW4KdGhlIGJvZHkgb2YgYSBtZXNzYWdlIHRvIG1ham9yZG9tb0B2 Z2VyLmtlcm5lbC5vcmcKTW9yZSBtYWpvcmRvbW8gaW5mbyBhdCAgaHR0cDovL3ZnZXIua2VybmVs Lm9yZy9tYWpvcmRvbW8taW5mby5odG1sCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966669AbdLSIyc (ORCPT ); Tue, 19 Dec 2017 03:54:32 -0500 Received: from mail-wr0-f181.google.com ([209.85.128.181]:42506 "EHLO mail-wr0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965550AbdLSIy1 (ORCPT ); Tue, 19 Dec 2017 03:54:27 -0500 X-Google-Smtp-Source: ACJfBovge+rdB+QzOUVjmfbn1faHmVnxkq64NDct/iASN/FcWO5ky7Q7zKYd4L5V8LJKk5MVFaGnoQ== Date: Tue, 19 Dec 2017 09:54:23 +0100 From: Johan Hovold To: =?iso-8859-1?Q?Bj=F8rn?= Mork Cc: SZ Lin =?utf-8?B?KOael+S4iuaZuik=?= , Johan Hovold , Taiyi TY Wu =?utf-8?B?KOWQs+azsOavhSk=?= , Greg Kroah-Hartman , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] USB: serial: option: adding support for YUGA CLM920-NC5 Message-ID: <20171219085423.GA8917@localhost> References: <20171215103203.2579-1-sz.lin@moxa.com> <20171218165248.GF3374@localhost> <87lghzc1vs.fsf@miraculix.mork.no> <5942081F7727964D830FC876E62CA85601194755CD@MHQMBX01.moxa.com> <878tdzb5xi.fsf@miraculix.mork.no> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <878tdzb5xi.fsf@miraculix.mork.no> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 19, 2017 at 07:14:17AM +0100, Bjørn Mork wrote: > "SZ Lin (林上智)" writes: > >> Johan Hovold writes: > >> > >> >> +static const struct option_blacklist_info yuga_clm920_nc5_blacklist = { > >> >> + .reserved = BIT(0) | BIT(1) | BIT(4), }; > >> > > >> > Do you really need to blacklist the first interface? > >> > >> Good question. Interface #0 does look a lot like a Qualcomm DM/DIAG > >> function, based on two bulk endpoints, no additional descriptors > >> and the fact that it is the first interface. If so, then we do > >> want a serial driver for it. There is a basic libqcdm > >> implementation in ModemManager if you want to test it out. > > > >I have confirmed that interface #0 is QCDM/DIAG port in this module, > >and thus I will remove this from reserved list in next patch. Thanks to both of you for confirming. > >Furthermore, interface #1 is ADB port. Should I also remove this from > >reserved list? > > No. ADB is handled by userspace tools using libusb. It should not be > bound to any serial driver, so you will need to blacklist it. But you > need to keep the blacklist anyway to include the QCDM/DIAG port > > I assume Johan's alternative was to match class/subclass/protocol > against ff/00/00, which would have worked if you only wanted to include > interfaces 2 and 3. Indeed. Johan