From: Arnd Bergmann <arnd@arndb.de>
To: Steve French <sfrench@samba.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
Pavel Shilovsky <pshilov@microsoft.com>,
Jean Delvare <jdelvare@suse.de>, Long Li <longli@microsoft.com>,
linux-cifs@vger.kernel.org, samba-technical@lists.samba.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] CIFS: SMBD: fix configurations with INFINIBAND=m
Date: Tue, 19 Dec 2017 11:12:57 +0100 [thread overview]
Message-ID: <20171219101327.2165797-1-arnd@arndb.de> (raw)
A built-in SMB file system cannot link against a modular
infiniband core module:
fs/cifs/smbdirect.o: In function `smbd_destroy_rdma_work':
smbdirect.c:(.text+0x28e3): undefined reference to `ib_drain_qp'
smbdirect.c:(.text+0x2915): undefined reference to `rdma_destroy_qp'
smbdirect.c:(.text+0x2d08): undefined reference to `ib_free_cq'
smbdirect.c:(.text+0x2d3d): undefined reference to `ib_free_cq'
smbdirect.c:(.text+0x2d6f): undefined reference to `ib_dealloc_pd'
smbdirect.c:(.text+0x2d9a): undefined reference to `rdma_destroy_id'
fs/cifs/smbdirect.o: In function `smbd_disconnect_rdma_work':
smbdirect.c:(.text+0x3d3e): undefined reference to `rdma_disconnect'
fs/cifs/smbdirect.o: In function `_smbd_get_connection':
smbdirect.c:(.text+0x5bc2): undefined reference to `rdma_create_id'
smbdirect.c:(.text+0x5cc5): undefined reference to `rdma_resolve_addr'
smbdirect.c:(.text+0x5cda): undefined reference to `rdma_destroy_id'
smbdirect.c:(.text+0x5da7): undefined reference to `rdma_destroy_id'
smbdirect.c:(.text+0x5e89): undefined reference to `rdma_resolve_route'
smbdirect.c:(.text+0x5f07): undefined reference to `rdma_destroy_id'
This changes the Kconfig dependency to enforce selecting one of the
valid configurations.
Fixes: bbc50d2ad317 ("CIFS: SMBD: Introduce kernel config option CONFIG_CIFS_SMB_DIRECT")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
fs/cifs/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/cifs/Kconfig b/fs/cifs/Kconfig
index 500fd69fb58b..3bfc55c08bef 100644
--- a/fs/cifs/Kconfig
+++ b/fs/cifs/Kconfig
@@ -199,6 +199,7 @@ config CIFS_SMB311
config CIFS_SMB_DIRECT
bool "SMB Direct support (Experimental)"
depends on CIFS && INFINIBAND
+ depends on CIFS=m || INFINIBAND=y
help
Enables SMB Direct experimental support for SMB 3.0, 3.02 and 3.1.1.
SMB Direct allows transferring SMB packets over RDMA. If unsure,
--
2.9.0
next reply other threads:[~2017-12-19 10:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-19 10:12 Arnd Bergmann [this message]
[not found] ` <20171219101327.2165797-1-arnd-r2nGTMty4D4@public.gmane.org>
2017-12-19 10:33 ` [PATCH] CIFS: SMBD: fix configurations with INFINIBAND=m Stefan Metzmacher
2017-12-19 10:33 ` Stefan Metzmacher
2017-12-19 10:56 ` Arnd Bergmann
[not found] ` <CAK8P3a3TQSt8skuyu7uHBbyG_jHS8wUaPPJ1XSh4u+aHxBzN8w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-12-19 11:01 ` Stefan Metzmacher
2017-12-19 11:01 ` Stefan Metzmacher
2017-12-19 12:39 ` Jean Delvare
2017-12-19 12:39 ` Jean Delvare
2017-12-19 21:21 ` Long Li
2017-12-19 21:21 ` Long Li
[not found] ` <MWHPR21MB08468B3FE04EAF4B41A92B75CE0F0-saRRjQKJ25OdAu0pOMKhMc1VXTxX1y3OvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2017-12-20 6:34 ` Stefan Metzmacher
2017-12-20 6:34 ` Stefan Metzmacher
2017-12-20 8:17 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171219101327.2165797-1-arnd@arndb.de \
--to=arnd@arndb.de \
--cc=jdelvare@suse.de \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=pshilov@microsoft.com \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.