From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pdbViBEd36I19JNUQskQaHx0WbnqXEeOOznNCZBvO5o=; b=nQ6GvE9iMHAPndtemfXq+PsN0TPSBIk/XEX3yhvlMNezuFqf7sDkahRosGU1k14VKd d7I9shbnkPYjR2GP2vGLOVUX/mFTIORnMALJ0Fr++1wW/GAKLsP1iwQzP2qf5z1tJkzM N82nmuz4UDvVENO7qFXwVZSGKtA2UnfC6UOtoS0lMII+OHrpWHMsWObPYK5FiMBTh8+I 3QPoiH7s1ie9CHvdQuZNuFRPbxhxp6lnAmN1oaiO3rY8xQ2tUdAzDG+Mrvb2qN2iPaeT w0nYqdG7nrlo8+D13/4EdnUJFaI4QFrX69hCi5D8XAGwyQIC9K/khPL3X2ARqXYrL84u h+OQ== Date: Tue, 19 Dec 2017 10:32:56 -0800 From: Stephen Hemminger Message-ID: <20171219103256.07405db1@xeon-e3> In-Reply-To: <20171219181053.86320-1-andriy.shevchenko@linux.intel.com> References: <20171219181053.86320-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Bridge] [PATCH v1] bridge: Use helpers to handle MAC address List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andy Shevchenko Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org, "David S. Miller" On Tue, 19 Dec 2017 20:10:53 +0200 Andy Shevchenko wrote: > Use > %pM to print MAC > mac_pton() to convert it from ASCII to binary format, and > ether_addr_copy() to copy. > > Signed-off-by: Andy Shevchenko Looks good Signed-off-by: Stephen Hemminger From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH v1] bridge: Use helpers to handle MAC address Date: Tue, 19 Dec 2017 10:32:56 -0800 Message-ID: <20171219103256.07405db1@xeon-e3> References: <20171219181053.86320-1-andriy.shevchenko@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "David S. Miller" , bridge@lists.linux-foundation.org, netdev@vger.kernel.org To: Andy Shevchenko Return-path: Received: from mail-pf0-f170.google.com ([209.85.192.170]:46333 "EHLO mail-pf0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750825AbdLSSdA (ORCPT ); Tue, 19 Dec 2017 13:33:00 -0500 Received: by mail-pf0-f170.google.com with SMTP id c204so11467054pfc.13 for ; Tue, 19 Dec 2017 10:32:59 -0800 (PST) In-Reply-To: <20171219181053.86320-1-andriy.shevchenko@linux.intel.com> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 19 Dec 2017 20:10:53 +0200 Andy Shevchenko wrote: > Use > %pM to print MAC > mac_pton() to convert it from ASCII to binary format, and > ether_addr_copy() to copy. > > Signed-off-by: Andy Shevchenko Looks good Signed-off-by: Stephen Hemminger