Re: [Qemu-devel] [PATCH v1 01/13] ui: remove 'sync' parametr from vnc_update_client

["Daniel P. Berrange" <berrange@redhat.com>]

Just cc'ing  qemu-devel back on the mail since it was accidentally dropped.

On Tue, Dec 19, 2017 at 07:26:29AM +0000, Darren Kenny wrote:
> Small nit on the subject s/parametr/parameter/
> 
> Otherwise, looks good.
> 
> Reviewed-by: Darren Kenny <darren.kenny@oracle.com>
> 
> Thanks,
> 
> Darren.
> 
> On Mon, Dec 18, 2017 at 07:12:16PM +0000, Daniel P. Berrange wrote:
> > There is only one caller of vnc_update_client and that always passes false
> > for the 'sync' parameter.
> > 
> > Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> > ---
> > ui/vnc.c | 11 +++--------
> > 1 file changed, 3 insertions(+), 8 deletions(-)
> > 
> > diff --git a/ui/vnc.c b/ui/vnc.c
> > index 9f8d5a1b1f..7ba3297dfa 100644
> > --- a/ui/vnc.c
> > +++ b/ui/vnc.c
> > @@ -596,7 +596,7 @@ VncInfo2List *qmp_query_vnc_servers(Error **errp)
> >    3) resolutions > 1024
> > */
> > 
> > -static int vnc_update_client(VncState *vs, int has_dirty, bool sync);
> > +static int vnc_update_client(VncState *vs, int has_dirty);
> > static void vnc_disconnect_start(VncState *vs);
> > 
> > static void vnc_colordepth(VncState *vs);
> > @@ -961,7 +961,7 @@ static int find_and_clear_dirty_height(VncState *vs,
> >     return h;
> > }
> > 
> > -static int vnc_update_client(VncState *vs, int has_dirty, bool sync)
> > +static int vnc_update_client(VncState *vs, int has_dirty)
> > {
> >     if (vs->disconnecting) {
> >         vnc_disconnect_finish(vs);
> > @@ -1025,9 +1025,6 @@ static int vnc_update_client(VncState *vs, int has_dirty, bool sync)
> >         }
> > 
> >         vnc_job_push(job);
> > -        if (sync) {
> > -            vnc_jobs_join(vs);
> > -        }
> >         vs->force_update = 0;
> >         vs->has_dirty = 0;
> >         return n;
> > @@ -1035,8 +1032,6 @@ static int vnc_update_client(VncState *vs, int has_dirty, bool sync)
> > 
> >     if (vs->disconnecting) {
> >         vnc_disconnect_finish(vs);
> > -    } else if (sync) {
> > -        vnc_jobs_join(vs);
> >     }
> > 
> >     return 0;
> > @@ -2863,7 +2858,7 @@ static void vnc_refresh(DisplayChangeListener *dcl)
> >     vnc_unlock_display(vd);
> > 
> >     QTAILQ_FOREACH_SAFE(vs, &vd->clients, next, vn) {
> > -        rects += vnc_update_client(vs, has_dirty, false);
> > +        rects += vnc_update_client(vs, has_dirty);
> >         /* vs might be free()ed here */
> >     }
> > 
> > -- 
> > 2.14.3
> > 
> > 

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|