From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from osg.samsung.com ([64.30.133.232]:63636 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751026AbdLSPiG (ORCPT ); Tue, 19 Dec 2017 10:38:06 -0500 Date: Tue, 19 Dec 2017 13:37:58 -0200 From: Mauro Carvalho Chehab To: Sakari Ailus Cc: Laurent Pinchart , Sakari Ailus , Linux Media Mailing List , Mauro Carvalho Chehab , Hans Verkuil , Laurent Pinchart , Marek Szyprowski , Tomasz Figa , Ramesh Shanmugasundaram , Ricardo Ribalda Delgado Subject: Re: [PATCH 2/8] media: v4l2-ioctl.h: convert debug into an enum of bits Message-ID: <20171219133758.6cf22460@vento.lan> In-Reply-To: <20171219141235.mgiyoeeiyfn2z4zh@paasikivi.fi.intel.com> References: <333b63fa1857f6819ce64666beba969c22e2f468.1513625884.git.mchehab@s-opensource.com> <20171219113927.i2srypzhigkijetf@valkosipuli.retiisi.org.uk> <1615432.c1z8s9p1mm@avalon> <20171219141235.mgiyoeeiyfn2z4zh@paasikivi.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Em Tue, 19 Dec 2017 16:12:35 +0200 Sakari Ailus escreveu: > Hi Laurent, > > On Tue, Dec 19, 2017 at 04:02:02PM +0200, Laurent Pinchart wrote: > > And furthermore using enum types in the uAPI is a bad idea as the enum size is > > architecture-dependent. That's why we use integer types in structures used as > > ioctl arguments. > > I guess we have an argeement on that, enums are a no-go for uAPI, for > reasons not related to the topic at hand. Huh? We're not talking about uAPI. This is kAPI. Using enums there is OK. Thanks, Mauro