From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from newverein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0B17F2035BA04 for ; Tue, 19 Dec 2017 06:58:47 -0800 (PST) Date: Tue, 19 Dec 2017 16:03:32 +0100 From: Christoph Hellwig Subject: Re: [PATCH 14/17] memremap: simplify duplicate region handling in devm_memremap_pages Message-ID: <20171219150332.GB13124@lst.de> References: <20171215140947.26075-1-hch@lst.de> <20171215140947.26075-15-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Dan Williams Cc: "linux-nvdimm@lists.01.org" , X86 ML , "linux-kernel@vger.kernel.org" , Linux MM , =?iso-8859-1?B?Suly9G1l?= Glisse , linuxppc-dev , Christoph Hellwig List-ID: T24gU3VuLCBEZWMgMTcsIDIwMTcgYXQgMDk6MzQ6MTFBTSAtMDgwMCwgRGFuIFdpbGxpYW1zIHdy b3RlOgo+IFRoaXMgaXMgbm90IHJhY3ksIHdlJ2xsIGNhdGNoIHRoZSBlcnJvciBvbiBpbnNlcnQs IGFuZCBJIHRoaW5rIHRoZQo+IGV4dHJhIGRlYnVnIGluZm9ybWF0aW9uIGlzIHVzZWZ1bCBmb3Ig ZGVidWdnaW5nIGEgYnJva2VuIG1lbW9yeSBtYXAgb3IKPiBhbGlnbm1lbnQgbWF0aC4KCldlIGNh biBjaGVjayBmb3IgLdCVRVhJU1QgYW5kIHByaW50IHRoZSB3YXJuaW5nLCBidXQgaXQncyBhIHdl aXJkIHBhdHRlcm4KZm9yIHN1cmUuCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCkxpbnV4LW52ZGltbSBtYWlsaW5nIGxpc3QKTGludXgtbnZkaW1tQGxpc3Rz LjAxLm9yZwpodHRwczovL2xpc3RzLjAxLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LW52ZGlt bQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from newverein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3z1Lkw0Y5PzDx5w for ; Wed, 20 Dec 2017 02:03:36 +1100 (AEDT) Date: Tue, 19 Dec 2017 16:03:32 +0100 From: Christoph Hellwig To: Dan Williams Cc: Christoph Hellwig , =?iso-8859-1?B?Suly9G1l?= Glisse , Logan Gunthorpe , "linux-nvdimm@lists.01.org" , linuxppc-dev , X86 ML , Linux MM , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 14/17] memremap: simplify duplicate region handling in devm_memremap_pages Message-ID: <20171219150332.GB13124@lst.de> References: <20171215140947.26075-1-hch@lst.de> <20171215140947.26075-15-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 In-Reply-To: List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sun, Dec 17, 2017 at 09:34:11AM -0800, Dan Williams wrote: > This is not racy, we'll catch the error on insert, and I think the > extra debug information is useful for debugging a broken memory map or > alignment math. We can check for -Š•EXIST and print the warning, but it's a weird pattern for sure. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f69.google.com (mail-wm0-f69.google.com [74.125.82.69]) by kanga.kvack.org (Postfix) with ESMTP id AC9196B025E for ; Tue, 19 Dec 2017 10:03:33 -0500 (EST) Received: by mail-wm0-f69.google.com with SMTP id f132so1262906wmf.6 for ; Tue, 19 Dec 2017 07:03:33 -0800 (PST) Received: from newverein.lst.de (verein.lst.de. [213.95.11.211]) by mx.google.com with ESMTPS id r13si11685538wrc.91.2017.12.19.07.03.32 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Dec 2017 07:03:32 -0800 (PST) Date: Tue, 19 Dec 2017 16:03:32 +0100 From: Christoph Hellwig Subject: Re: [PATCH 14/17] memremap: simplify duplicate region handling in devm_memremap_pages Message-ID: <20171219150332.GB13124@lst.de> References: <20171215140947.26075-1-hch@lst.de> <20171215140947.26075-15-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Dan Williams Cc: Christoph Hellwig , =?iso-8859-1?B?Suly9G1l?= Glisse , Logan Gunthorpe , "linux-nvdimm@lists.01.org" , linuxppc-dev , X86 ML , Linux MM , "linux-kernel@vger.kernel.org" On Sun, Dec 17, 2017 at 09:34:11AM -0800, Dan Williams wrote: > This is not racy, we'll catch the error on insert, and I think the > extra debug information is useful for debugging a broken memory map or > alignment math. We can check for -D?EXIST and print the warning, but it's a weird pattern for sure. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org